darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-18 07:21:49 -05:00
Code Issues Packages Projects Releases Wiki Activity
Files
56bae2b07758ac2079013d5acef1c46eb1525a81
notifications-api/app/notifications/process_letter_notifications.py

27 lines
1.1 KiB
Python
Raw Normal View History

process letters from api traffic there are three steps to this 1. Create a job * Starts in status 'ready to send' * Created by None, since it's from the API * original file name 'letter submitted via api' 2. Create a single notification for that job * job_row_number 0 * client reference if provided * address line 1 as recipient 3. Trigger the build_dvla_file task we know that all the notifications have been created for this job (since we just created them ourselves synchronously), so this will just create the dvla-format file for the job, and upload it to s3.
2017-07-26 15:57:30 +01:00
from app import create_random_identifier
remove jobs from letter api calls we now no longer create a job. At the end of the post there is no action, as we don't have any tasks to queue immediately - if it's a real notification it'll get picked up in the evening scheduled task. If it's a test notification, we create it with an initial status of sending so that we can be sure it'll never get picked up - and then we trigger the update-letter-notifications-to-sent-to-dvla task to sent the sent-at/by.
2017-09-26 09:56:09 +01:00
from app.models import LETTER_TYPE
process letters from api traffic there are three steps to this 1. Create a job * Starts in status 'ready to send' * Created by None, since it's from the API * original file name 'letter submitted via api' 2. Create a single notification for that job * job_row_number 0 * client reference if provided * address line 1 as recipient 3. Trigger the build_dvla_file task we know that all the notifications have been created for this job (since we just created them ourselves synchronously), so this will just create the dvla-format file for the job, and upload it to s3.
2017-07-26 15:57:30 +01:00
from app.notifications.process_notifications import persist_notification
Removed an update statement to notifications. It's a small change, but we should remove any db operations that are not necessary.
2018-09-20 14:47:24 +01:00
def create_letter_notification(letter_data, template, api_key, status, reply_to_text=None, billable_units=None):
process letters from api traffic there are three steps to this 1. Create a job * Starts in status 'ready to send' * Created by None, since it's from the API * original file name 'letter submitted via api' 2. Create a single notification for that job * job_row_number 0 * client reference if provided * address line 1 as recipient 3. Trigger the build_dvla_file task we know that all the notifications have been created for this job (since we just created them ourselves synchronously), so this will just create the dvla-format file for the job, and upload it to s3.
2017-07-26 15:57:30 +01:00
notification = persist_notification(
remove jobs from letter api and make success/error ftp callback tasks 1. No longer create jobs when creating letters from api :tada: 2. Bulk update notifications based on the notification references after we send them to DVLA - either as success or as error
2017-09-20 11:12:37 +01:00
template_id=template.id,
template_version=template.version,
add tests for letter api notifications
2017-07-27 11:10:22 +01:00
# we only accept addresses_with_underscores from the API (from CSV we also accept dashes, spaces etc)
recipient=letter_data['personalisation']['address_line_1'],
remove jobs from letter api calls we now no longer create a job. At the end of the post there is no action, as we don't have any tasks to queue immediately - if it's a real notification it'll get picked up in the evening scheduled task. If it's a test notification, we create it with an initial status of sending so that we can be sure it'll never get picked up - and then we trigger the update-letter-notifications-to-sent-to-dvla task to sent the sent-at/by.
2017-09-26 09:56:09 +01:00
service=template.service,
process letters from api traffic there are three steps to this 1. Create a job * Starts in status 'ready to send' * Created by None, since it's from the API * original file name 'letter submitted via api' 2. Create a single notification for that job * job_row_number 0 * client reference if provided * address line 1 as recipient 3. Trigger the build_dvla_file task we know that all the notifications have been created for this job (since we just created them ourselves synchronously), so this will just create the dvla-format file for the job, and upload it to s3.
2017-07-26 15:57:30 +01:00
personalisation=letter_data['personalisation'],
notification_type=LETTER_TYPE,
api_key_id=api_key.id,
key_type=api_key.key_type,
remove jobs from letter api and make success/error ftp callback tasks 1. No longer create jobs when creating letters from api :tada: 2. Bulk update notifications based on the notification references after we send them to DVLA - either as success or as error
2017-09-20 11:12:37 +01:00
job_id=None,
job_row_number=None,
process letters from api traffic there are three steps to this 1. Create a job * Starts in status 'ready to send' * Created by None, since it's from the API * original file name 'letter submitted via api' 2. Create a single notification for that job * job_row_number 0 * client reference if provided * address line 1 as recipient 3. Trigger the build_dvla_file task we know that all the notifications have been created for this job (since we just created them ourselves synchronously), so this will just create the dvla-format file for the job, and upload it to s3.
2017-07-26 15:57:30 +01:00
reference=create_random_identifier(),
remove jobs from letter api calls we now no longer create a job. At the end of the post there is no action, as we don't have any tasks to queue immediately - if it's a real notification it'll get picked up in the evening scheduled task. If it's a test notification, we create it with an initial status of sending so that we can be sure it'll never get picked up - and then we trigger the update-letter-notifications-to-sent-to-dvla task to sent the sent-at/by.
2017-09-26 09:56:09 +01:00
client_reference=letter_data.get('reference'),
Set reply_to_text for letter notifications posted to /notifications/letter
2017-11-24 16:17:25 +00:00
status=status,
Removed an update statement to notifications. It's a small change, but we should remove any db operations that are not necessary.
2018-09-20 14:47:24 +01:00
reply_to_text=reply_to_text,
Allow users to set postage per precompiled letter
2019-01-09 17:49:19 +00:00
billable_units=billable_units,
postage=letter_data.get('postage')
process letters from api traffic there are three steps to this 1. Create a job * Starts in status 'ready to send' * Created by None, since it's from the API * original file name 'letter submitted via api' 2. Create a single notification for that job * job_row_number 0 * client reference if provided * address line 1 as recipient 3. Trigger the build_dvla_file task we know that all the notifications have been created for this job (since we just created them ourselves synchronously), so this will just create the dvla-format file for the job, and upload it to s3.
2017-07-26 15:57:30 +01:00
)
return notification
Reference in New Issue Copy Permalink