2017-05-31 14:49:14 +01:00
|
|
|
from datetime import datetime
|
|
|
|
|
|
2017-06-02 12:57:28 +01:00
|
|
|
import pytest
|
2017-06-09 10:34:02 +01:00
|
|
|
from flask import json
|
2017-05-31 14:49:14 +01:00
|
|
|
from freezegun import freeze_time
|
|
|
|
|
|
2017-06-09 10:34:02 +01:00
|
|
|
from tests import create_authorization_header
|
2017-05-31 14:49:14 +01:00
|
|
|
from tests.app.db import create_inbound_sms, create_service
|
|
|
|
|
|
|
|
|
|
|
2017-06-09 10:34:02 +01:00
|
|
|
def test_get_inbound_sms_with_no_params(client, sample_service):
|
|
|
|
|
one = create_inbound_sms(sample_service)
|
|
|
|
|
two = create_inbound_sms(sample_service)
|
|
|
|
|
|
|
|
|
|
auth_header = create_authorization_header()
|
|
|
|
|
|
|
|
|
|
data = {}
|
|
|
|
|
|
|
|
|
|
response = client.post(
|
|
|
|
|
path='/service/{}/inbound-sms'.format(sample_service.id),
|
|
|
|
|
data=json.dumps(data),
|
|
|
|
|
headers=[('Content-Type', 'application/json'), auth_header])
|
|
|
|
|
|
|
|
|
|
json_resp = json.loads(response.get_data(as_text=True))
|
|
|
|
|
sms = json_resp['data']
|
|
|
|
|
|
|
|
|
|
assert len(sms) == 2
|
|
|
|
|
assert {inbound['id'] for inbound in sms} == {str(one.id), str(two.id)}
|
|
|
|
|
assert sms[0]['content'] == 'Hello'
|
|
|
|
|
assert set(sms[0].keys()) == {
|
|
|
|
|
'id',
|
|
|
|
|
'created_at',
|
|
|
|
|
'service_id',
|
|
|
|
|
'notify_number',
|
|
|
|
|
'user_number',
|
|
|
|
|
'content',
|
|
|
|
|
'provider_date',
|
|
|
|
|
'provider_reference'
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_get_inbound_sms_with_limit(client, sample_service):
|
|
|
|
|
with freeze_time('2017-01-01'):
|
|
|
|
|
one = create_inbound_sms(sample_service)
|
|
|
|
|
with freeze_time('2017-01-02'):
|
|
|
|
|
two = create_inbound_sms(sample_service)
|
|
|
|
|
|
|
|
|
|
auth_header = create_authorization_header()
|
|
|
|
|
|
|
|
|
|
data = {'limit': 1}
|
|
|
|
|
|
|
|
|
|
response = client.post(
|
|
|
|
|
path='/service/{}/inbound-sms'.format(sample_service.id),
|
|
|
|
|
data=json.dumps(data),
|
|
|
|
|
headers=[('Content-Type', 'application/json'), auth_header])
|
|
|
|
|
|
|
|
|
|
json_resp = json.loads(response.get_data(as_text=True))
|
|
|
|
|
sms = json_resp['data']
|
|
|
|
|
|
|
|
|
|
assert len(sms) == 1
|
|
|
|
|
assert sms[0]['id'] == str(two.id)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_get_inbound_sms_should_error_with_invalid_limit(client, sample_service):
|
|
|
|
|
|
|
|
|
|
auth_header = create_authorization_header()
|
|
|
|
|
|
|
|
|
|
data = {'limit': 'limit'}
|
|
|
|
|
|
|
|
|
|
response = client.post(
|
|
|
|
|
path='/service/{}/inbound-sms'.format(sample_service.id),
|
|
|
|
|
data=json.dumps(data),
|
|
|
|
|
headers=[('Content-Type', 'application/json'), auth_header])
|
|
|
|
|
|
|
|
|
|
error_resp = json.loads(response.get_data(as_text=True))
|
|
|
|
|
assert error_resp['status_code'] == 400
|
|
|
|
|
assert error_resp['errors'] == [{
|
|
|
|
|
'error': 'ValidationError',
|
|
|
|
|
'message': "limit limit is not of type integer, null"
|
|
|
|
|
}]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_get_inbound_sms_should_error_with_invalid_phone_number(client, sample_service):
|
|
|
|
|
|
|
|
|
|
auth_header = create_authorization_header()
|
|
|
|
|
|
|
|
|
|
data = {'phone_number': 'invalid phone number'}
|
|
|
|
|
|
|
|
|
|
response = client.post(
|
|
|
|
|
path='/service/{}/inbound-sms'.format(sample_service.id),
|
|
|
|
|
data=json.dumps(data),
|
|
|
|
|
headers=[('Content-Type', 'application/json'), auth_header])
|
|
|
|
|
|
|
|
|
|
error_resp = json.loads(response.get_data(as_text=True))
|
|
|
|
|
assert error_resp['status_code'] == 400
|
|
|
|
|
assert error_resp['errors'] == [{
|
|
|
|
|
'error': 'ValidationError',
|
|
|
|
|
'message': "phone_number Must not contain letters or symbols"
|
|
|
|
|
}]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize('user_number', [
|
|
|
|
|
'(07700) 900-001',
|
|
|
|
|
'+4407700900001',
|
|
|
|
|
'447700900001',
|
|
|
|
|
])
|
|
|
|
|
def test_get_inbound_sms_filters_user_number(client, sample_service, user_number):
|
|
|
|
|
# user_number in the db is international and normalised
|
|
|
|
|
one = create_inbound_sms(sample_service, user_number='447700900001')
|
|
|
|
|
two = create_inbound_sms(sample_service, user_number='447700900002')
|
|
|
|
|
|
|
|
|
|
auth_header = create_authorization_header()
|
|
|
|
|
|
|
|
|
|
data = {
|
|
|
|
|
'limit': 1,
|
|
|
|
|
'phone_number': user_number
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
response = client.post(
|
|
|
|
|
path='/service/{}/inbound-sms'.format(sample_service.id),
|
|
|
|
|
data=json.dumps(data),
|
|
|
|
|
headers=[('Content-Type', 'application/json'), auth_header])
|
|
|
|
|
|
|
|
|
|
json_resp = json.loads(response.get_data(as_text=True))
|
|
|
|
|
sms = json_resp['data']
|
|
|
|
|
assert len(sms) == 1
|
|
|
|
|
assert sms[0]['id'] == str(one.id)
|
|
|
|
|
assert sms[0]['user_number'] == str(one.user_number)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_get_inbound_sms_filters_international_user_number(admin_request, sample_service):
|
|
|
|
|
# user_number in the db is international and normalised
|
|
|
|
|
one = create_inbound_sms(sample_service, user_number='12025550104')
|
|
|
|
|
two = create_inbound_sms(sample_service)
|
|
|
|
|
|
|
|
|
|
auth_header = create_authorization_header()
|
|
|
|
|
|
|
|
|
|
data = {
|
|
|
|
|
'limit': 1,
|
|
|
|
|
'phone_number': '+1 (202) 555-0104'
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
response = client.post(
|
|
|
|
|
path='/service/{}/inbound-sms'.format(sample_service.id),
|
|
|
|
|
data=json.dumps(data),
|
|
|
|
|
headers=[('Content-Type', 'application/json'), auth_header])
|
|
|
|
|
|
|
|
|
|
json_resp = json.loads(response.get_data(as_text=True))
|
|
|
|
|
sms = json_resp['data']
|
|
|
|
|
|
|
|
|
|
assert len(sms) == 1
|
|
|
|
|
assert sms[0]['id'] == str(one.id)
|
|
|
|
|
assert sms[0]['user_number'] == str(one.user_number)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
##############################################################
|
|
|
|
|
# REMOVE ONCE ADMIN MIGRATED AND GET ENDPOINT REMOVED
|
|
|
|
|
##############################################################
|
|
|
|
|
|
|
|
|
|
|
2017-05-31 14:49:14 +01:00
|
|
|
def test_get_inbound_sms(admin_request, sample_service):
|
|
|
|
|
one = create_inbound_sms(sample_service)
|
|
|
|
|
two = create_inbound_sms(sample_service)
|
|
|
|
|
|
|
|
|
|
json_resp = admin_request.get(
|
|
|
|
|
'inbound_sms.get_inbound_sms_for_service',
|
2017-06-19 13:49:20 +01:00
|
|
|
service_id=sample_service.id
|
2017-05-31 14:49:14 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
sms = json_resp['data']
|
|
|
|
|
|
|
|
|
|
assert len(sms) == 2
|
|
|
|
|
assert {inbound['id'] for inbound in sms} == {str(one.id), str(two.id)}
|
|
|
|
|
assert sms[0]['content'] == 'Hello'
|
|
|
|
|
assert set(sms[0].keys()) == {
|
|
|
|
|
'id',
|
|
|
|
|
'created_at',
|
|
|
|
|
'service_id',
|
|
|
|
|
'notify_number',
|
|
|
|
|
'user_number',
|
|
|
|
|
'content',
|
|
|
|
|
'provider_date',
|
|
|
|
|
'provider_reference'
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_get_inbound_sms_limits(admin_request, sample_service):
|
|
|
|
|
with freeze_time('2017-01-01'):
|
|
|
|
|
one = create_inbound_sms(sample_service)
|
|
|
|
|
with freeze_time('2017-01-02'):
|
|
|
|
|
two = create_inbound_sms(sample_service)
|
|
|
|
|
|
|
|
|
|
sms = admin_request.get(
|
|
|
|
|
'inbound_sms.get_inbound_sms_for_service',
|
2017-06-19 13:49:20 +01:00
|
|
|
service_id=sample_service.id,
|
|
|
|
|
limit=1,
|
2017-05-31 14:49:14 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
assert len(sms['data']) == 1
|
|
|
|
|
assert sms['data'][0]['id'] == str(two.id)
|
|
|
|
|
|
|
|
|
|
|
2017-06-02 12:57:28 +01:00
|
|
|
@pytest.mark.parametrize('user_number', [
|
|
|
|
|
'(07700) 900-001',
|
|
|
|
|
'+4407700900001',
|
|
|
|
|
'447700900001',
|
|
|
|
|
])
|
|
|
|
|
def test_get_inbound_sms_filters_user_number(admin_request, sample_service, user_number):
|
|
|
|
|
# user_number in the db is international and normalised
|
|
|
|
|
one = create_inbound_sms(sample_service, user_number='447700900001')
|
|
|
|
|
two = create_inbound_sms(sample_service, user_number='447700900002')
|
2017-05-31 14:49:14 +01:00
|
|
|
|
|
|
|
|
sms = admin_request.get(
|
|
|
|
|
'inbound_sms.get_inbound_sms_for_service',
|
2017-06-19 13:49:20 +01:00
|
|
|
service_id=sample_service.id,
|
|
|
|
|
user_number=user_number,
|
2017-05-31 14:49:14 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
assert len(sms['data']) == 1
|
|
|
|
|
assert sms['data'][0]['id'] == str(one.id)
|
2017-06-02 13:34:02 +01:00
|
|
|
assert sms['data'][0]['user_number'] == str(one.user_number)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_get_inbound_sms_filters_international_user_number(admin_request, sample_service):
|
|
|
|
|
# user_number in the db is international and normalised
|
|
|
|
|
one = create_inbound_sms(sample_service, user_number='12025550104')
|
|
|
|
|
two = create_inbound_sms(sample_service)
|
|
|
|
|
|
|
|
|
|
sms = admin_request.get(
|
|
|
|
|
'inbound_sms.get_inbound_sms_for_service',
|
2017-06-19 13:49:20 +01:00
|
|
|
service_id=sample_service.id,
|
|
|
|
|
user_number='+1 (202) 555-0104',
|
2017-06-02 13:34:02 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
assert len(sms['data']) == 1
|
|
|
|
|
assert sms['data'][0]['id'] == str(one.id)
|
2017-05-31 14:49:14 +01:00
|
|
|
assert sms['data'][0]['user_number'] == str(one.user_number)
|
|
|
|
|
|
|
|
|
|
|
2017-06-09 10:34:02 +01:00
|
|
|
##############################
|
|
|
|
|
# End delete section
|
|
|
|
|
##############################
|
|
|
|
|
|
2017-05-31 14:49:14 +01:00
|
|
|
def test_get_inbound_sms_summary(admin_request, sample_service):
|
|
|
|
|
other_service = create_service(service_name='other_service')
|
|
|
|
|
with freeze_time('2017-01-01'):
|
|
|
|
|
create_inbound_sms(sample_service)
|
|
|
|
|
with freeze_time('2017-01-02'):
|
|
|
|
|
create_inbound_sms(sample_service)
|
|
|
|
|
with freeze_time('2017-01-03'):
|
|
|
|
|
create_inbound_sms(other_service)
|
|
|
|
|
|
|
|
|
|
summary = admin_request.get(
|
|
|
|
|
'inbound_sms.get_inbound_sms_summary_for_service',
|
2017-06-19 13:49:20 +01:00
|
|
|
service_id=sample_service.id
|
2017-05-31 14:49:14 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
assert summary == {
|
|
|
|
|
'count': 2,
|
|
|
|
|
'most_recent': datetime(2017, 1, 2).isoformat()
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_get_inbound_sms_summary_with_no_inbound(admin_request, sample_service):
|
|
|
|
|
summary = admin_request.get(
|
|
|
|
|
'inbound_sms.get_inbound_sms_summary_for_service',
|
2017-06-19 13:49:20 +01:00
|
|
|
service_id=sample_service.id
|
2017-05-31 14:49:14 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
assert summary == {
|
|
|
|
|
'count': 0,
|
|
|
|
|
'most_recent': None
|
|
|
|
|
}
|
2017-06-06 17:12:21 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_get_inbound_sms_by_id_returns_200(admin_request, sample_service):
|
|
|
|
|
inbound = create_inbound_sms(sample_service, user_number='447700900001')
|
|
|
|
|
|
|
|
|
|
response = admin_request.get(
|
|
|
|
|
'inbound_sms.get_inbound_by_id',
|
2017-06-19 13:49:20 +01:00
|
|
|
service_id=sample_service.id,
|
|
|
|
|
inbound_sms_id=inbound.id,
|
2017-06-06 17:12:21 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
assert response['user_number'] == '447700900001'
|
|
|
|
|
assert response['service_id'] == str(sample_service.id)
|
|
|
|
|
|
|
|
|
|
|
2017-06-07 14:23:31 +01:00
|
|
|
def test_get_inbound_sms_by_id_invalid_id_returns_404(admin_request, sample_service):
|
2017-06-06 17:12:21 +01:00
|
|
|
assert admin_request.get(
|
|
|
|
|
'inbound_sms.get_inbound_by_id',
|
2017-06-19 13:49:20 +01:00
|
|
|
service_id=sample_service.id,
|
|
|
|
|
inbound_sms_id='bar',
|
|
|
|
|
_expected_status=404
|
2017-06-07 14:23:31 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_get_inbound_sms_by_id_with_invalid_service_id_returns_404(admin_request, sample_service):
|
|
|
|
|
assert admin_request.get(
|
|
|
|
|
'inbound_sms.get_inbound_by_id',
|
2017-06-19 13:49:20 +01:00
|
|
|
service_id='foo',
|
|
|
|
|
inbound_sms_id='2cfbd6a1-1575-4664-8969-f27be0ea40d9',
|
|
|
|
|
_expected_status=404
|
2017-06-06 17:12:21 +01:00
|
|
|
)
|