mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-05-04 08:01:34 -04:00
5bfce61bcf
This naming was introduced in 2016 without explanation [1]. I find it confusing because: - It's reminiscent of "_app", which is a Python convention indicating the variable is internal, so maybe avoid using it. - It suggests there's some other "app" fixture I should be using (there isn't, though). The Python style guide describes using an underscore suffix to avoid clashes with inbuilt names [1], which is sort of applicable if we need to import the "app" module [2]. However, we can also avoid clashes by choosing a different name, without the strange underscore. [1]:3b1d521c10[2]:78824f54fd/tests/app/main/views/test_forgot_password.py (L5)
93 lines
3.3 KiB
Python
93 lines
3.3 KiB
Python
import pytest
|
|
|
|
from app.main.forms import ServiceContactDetailsForm
|
|
|
|
|
|
def test_form_fails_validation_with_no_radio_buttons_selected(notify_admin):
|
|
with notify_admin.test_request_context(method='POST', data={}):
|
|
form = ServiceContactDetailsForm()
|
|
|
|
assert not form.validate_on_submit()
|
|
assert len(form.errors) == 1
|
|
assert form.errors['contact_details_type'] == ['Select an option']
|
|
|
|
|
|
@pytest.mark.parametrize('selected_radio_button, selected_text_box, text_box_data', [
|
|
('email_address', 'url', 'http://www.example.com'),
|
|
('phone_number', 'url', 'http://www.example.com'),
|
|
('url', 'email_address', 'user@example.com'),
|
|
('phone_number', 'email_address', 'user@example.com'),
|
|
('url', 'phone_number', '0207 123 4567'),
|
|
('email_address', 'phone_number', '0207 123 4567'),
|
|
])
|
|
def test_form_fails_validation_when_radio_button_selected_and_text_box_filled_in_do_not_match(
|
|
notify_admin,
|
|
selected_radio_button,
|
|
selected_text_box,
|
|
text_box_data
|
|
):
|
|
data = {'contact_details_type': selected_radio_button, selected_text_box: text_box_data}
|
|
|
|
with notify_admin.test_request_context(method='POST', data=data):
|
|
form = ServiceContactDetailsForm()
|
|
|
|
assert not form.validate_on_submit()
|
|
assert len(form.errors) == 1
|
|
assert form.errors[selected_radio_button] == ['This field is required.']
|
|
|
|
|
|
@pytest.mark.parametrize('selected_field, url, email_address, phone_number', [
|
|
('url', 'http://www.example.com', 'invalid-email.com', 'phone'),
|
|
('email_address', 'www.invalid-url.com', 'me@example.com', 'phone'),
|
|
('phone_number', 'www.invalid-url.com', 'invalid-email.com', '0207 123 4567'),
|
|
])
|
|
def test_form_only_validates_the_field_which_matches_the_selected_radio_button(
|
|
notify_admin,
|
|
selected_field,
|
|
url,
|
|
email_address,
|
|
phone_number,
|
|
):
|
|
data = {'contact_details_type': selected_field,
|
|
'url': url,
|
|
'email_address': email_address,
|
|
'phone_number': phone_number}
|
|
|
|
with notify_admin.test_request_context(method='POST', data=data):
|
|
form = ServiceContactDetailsForm()
|
|
|
|
assert form.validate_on_submit()
|
|
|
|
|
|
def test_form_url_validation_fails_with_invalid_url_field(notify_admin):
|
|
data = {'contact_details_type': 'url', 'url': 'www.example.com'}
|
|
|
|
with notify_admin.test_request_context(method='POST', data=data):
|
|
form = ServiceContactDetailsForm()
|
|
|
|
assert not form.validate_on_submit()
|
|
assert len(form.errors) == 1
|
|
assert len(form.errors['url']) == 1
|
|
|
|
|
|
def test_form_email_validation_fails_with_invalid_email_address_field(notify_admin):
|
|
data = {'contact_details_type': 'email_address', 'email_address': '1@co'}
|
|
|
|
with notify_admin.test_request_context(method='POST', data=data):
|
|
form = ServiceContactDetailsForm()
|
|
|
|
assert not form.validate_on_submit()
|
|
assert len(form.errors) == 1
|
|
assert len(form.errors['email_address']) == 2
|
|
|
|
|
|
def test_form_phone_number_validation_fails_with_invalid_phone_number_field(notify_admin):
|
|
data = {'contact_details_type': 'phone_number', 'phone_number': '1235 A'}
|
|
|
|
with notify_admin.test_request_context(method='POST', data=data):
|
|
form = ServiceContactDetailsForm()
|
|
|
|
assert not form.validate_on_submit()
|
|
assert len(form.errors) == 1
|
|
assert form.errors['phone_number'] == ['Must be a valid phone number']
|