mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-06-07 15:01:55 -04:00
9aa4a7267a
Both `<button type='submit'>Submit<button>` and `<input type='submit' value='Submit'>` can be used to submit a form. We have historically[1] used `<input>` because it’s better-supported by IE6 in that: - the `submit` attribute is mandatory on `<button>`, not on `<input>` - the `innerHTML` of a button will be submitted to the server, not the value (as in other browsers) Reasons to now use `<button>` instead: - IE6/7 support is no longer a concern (especially with deprecation of TLS 1.0 on the way) - Because an `<input>` element can’t have children, the pseudo-element hack[2] used to ensure the top edge of the button is clickable doesn’t work. We’re seeing this bug[3] affect real users in research. 1. We inhereted our buttons from Digital Marketplace, here is me making that change in their code:8df7e2e79e (diff-b1420f7b7a25657d849edf90a70ef541)2.24e1906c0d (diff-ef0e4eb6f1e90b44b0c3fe39dce274a4R79)3. https://github.com/alphagov/govuk_elements/issues/545
32 lines
1.0 KiB
HTML
32 lines
1.0 KiB
HTML
{% extends "views/platform-admin/_base_template.html" %}
|
|
{% from "components/textbox.html" import textbox %}
|
|
{% from "components/big-number.html" import big_number %}
|
|
{% from "components/checkbox.html" import checkbox %}
|
|
{% from "components/page-footer.html" import page_footer %}
|
|
{% from "components/table.html" import mapping_table, field, stats_fields, row_group, row, right_aligned_field_heading, hidden_field_heading, text_field %}
|
|
|
|
{% block per_page_title %}
|
|
Platform admin
|
|
{% endblock %}
|
|
|
|
{% block platform_admin_content %}
|
|
|
|
<h1 class="heading-large">
|
|
Summary
|
|
</h1>
|
|
|
|
<details>
|
|
<summary>Apply filters</summary>
|
|
<form autocomplete="off" method="get">
|
|
{{ textbox(form.start_date, hint="Enter start date in format YYYY-MM-DD") }}
|
|
{{ textbox(form.end_date, hint="Enter end date in format YYYY-MM-DD") }}
|
|
{{ checkbox(form.include_from_test_key) }}
|
|
</br>
|
|
<button type="submit" class="button">Filter</button>
|
|
</form>
|
|
</details>
|
|
|
|
{% include "views/platform-admin/_global_stats.html" %}
|
|
|
|
{% endblock %}
|