mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-06-02 12:30:48 -04:00
9aa4a7267a
Both `<button type='submit'>Submit<button>` and `<input type='submit' value='Submit'>` can be used to submit a form. We have historically[1] used `<input>` because it’s better-supported by IE6 in that: - the `submit` attribute is mandatory on `<button>`, not on `<input>` - the `innerHTML` of a button will be submitted to the server, not the value (as in other browsers) Reasons to now use `<button>` instead: - IE6/7 support is no longer a concern (especially with deprecation of TLS 1.0 on the way) - Because an `<input>` element can’t have children, the pseudo-element hack[2] used to ensure the top edge of the button is clickable doesn’t work. We’re seeing this bug[3] affect real users in research. 1. We inhereted our buttons from Digital Marketplace, here is me making that change in their code:8df7e2e79e (diff-b1420f7b7a25657d849edf90a70ef541)2.24e1906c0d (diff-ef0e4eb6f1e90b44b0c3fe39dce274a4R79)3. https://github.com/alphagov/govuk_elements/issues/545
25 lines
865 B
HTML
25 lines
865 B
HTML
{% macro banner(body, type=None, with_tick=False, delete_button=None, subhead=None) %}
|
|
<div
|
|
class='banner{% if type %}-{{ type }}{% endif %}{% if with_tick %}-with-tick{% endif %}'
|
|
{% if type == 'dangerous' %}
|
|
role='group'
|
|
tabindex='-1'
|
|
{% endif %}
|
|
>
|
|
{% if subhead -%}
|
|
<h1 class="banner-title">{{ subhead }}</h1>
|
|
{%- endif -%}
|
|
{{ body }}
|
|
{% if delete_button %}
|
|
<form method='post'>
|
|
<input type="hidden" name="csrf_token" value="{{ csrf_token() }}" />
|
|
<button type="submit" class="button" name="delete">{{ delete_button }}</button
|
|
</form>
|
|
{% endif %}
|
|
</div>
|
|
{% endmacro %}
|
|
|
|
{% macro banner_wrapper(type=None, with_tick=False, delete_button=None, subhead=None) %}
|
|
{{ banner(caller()|safe, type=type, with_tick=with_tick, delete_button=delete_button, subhead=subhead) }}
|
|
{% endmacro %}
|