mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-02-05 19:03:30 -05:00
64812c1614
Fixed the is_active() method on the Users model, if the user was pending they would come back as active, allowing a user to sign in before being active. There is still a problem with the validate_sms_code and validate_email_code method.
71 lines
3.2 KiB
Python
71 lines
3.2 KiB
Python
from datetime import datetime, timedelta
|
|
|
|
from app.main.dao import verify_codes_dao
|
|
from app.main.forms import TwoFactorForm
|
|
from tests.app.main import create_test_user
|
|
|
|
|
|
def test_form_is_valid_returns_no_errors(notifications_admin, notifications_admin_db, notify_db_session):
|
|
with notifications_admin.test_request_context(method='POST',
|
|
data={'sms_code': '12345'}) as req:
|
|
user = set_up_test_data()
|
|
req.session['user_id'] = user.id
|
|
form = TwoFactorForm(req.request.form)
|
|
assert form.validate() is True
|
|
assert len(form.errors) == 0
|
|
|
|
|
|
def test_returns_errors_when_code_is_too_short(notifications_admin, notifications_admin_db, notify_db_session):
|
|
with notifications_admin.test_request_context(method='POST',
|
|
data={'sms_code': '145'}) as req:
|
|
user = set_up_test_data()
|
|
req.session['user_id'] = user.id
|
|
form = TwoFactorForm(req.request.form)
|
|
assert form.validate() is False
|
|
assert len(form.errors) == 1
|
|
assert set(form.errors) == set({'sms_code': ['Code must be 5 digits', 'Code does not match']})
|
|
|
|
|
|
def test_returns_errors_when_code_is_missing(notifications_admin, notifications_admin_db, notify_db_session):
|
|
with notifications_admin.test_request_context(method='POST',
|
|
data={}) as req:
|
|
user = set_up_test_data()
|
|
req.session['user_id'] = user.id
|
|
form = TwoFactorForm(req.request.form)
|
|
assert form.validate() is False
|
|
assert len(form.errors) == 1
|
|
assert set(form.errors) == set({'sms_code': ['Code must not be empty']})
|
|
|
|
|
|
def test_returns_errors_when_code_contains_letters(notifications_admin, notifications_admin_db, notify_db_session):
|
|
with notifications_admin.test_request_context(method='POST',
|
|
data={'sms_code': 'asdfg'}) as req:
|
|
user = set_up_test_data()
|
|
req.session['user_id'] = user.id
|
|
form = TwoFactorForm(req.request.form)
|
|
assert form.validate() is False
|
|
assert len(form.errors) == 1
|
|
assert set(form.errors) == set({'sms_code': ['Code must be 5 digits', 'Code does not match']})
|
|
|
|
|
|
def test_should_return_errors_when_code_is_expired(notifications_admin, notifications_admin_db, notify_db_session):
|
|
with notifications_admin.test_request_context(method='POST',
|
|
data={'sms_code': '23456'}) as req:
|
|
user = create_test_user('active')
|
|
req.session['user_id'] = user.id
|
|
verify_codes_dao.add_code_with_expiry(user_id=user.id,
|
|
code='23456',
|
|
code_type='sms',
|
|
expiry=datetime.now() + timedelta(hours=-2))
|
|
form = TwoFactorForm(req.request.form)
|
|
assert form.validate() is False
|
|
errors = form.errors
|
|
assert len(errors) == 1
|
|
assert errors == {'sms_code': ['Code has expired']}
|
|
|
|
|
|
def set_up_test_data():
|
|
user = create_test_user('active')
|
|
verify_codes_dao.add_code(user_id=user.id, code='12345', code_type='sms')
|
|
return user
|