mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-09-10 18:22:37 -04:00
Ben Thorner
32efb9a03d
This is a very low impact bug since a user can always create such templates after their service is live and not be subject to checks we do before that point. Still, we may as well fix it. The main benefit of this change is actually to contribute towards moving methods like "get_templates" out of the Service class so we can simplify and cache their results more effectively. Note: I wanted to simplify the Service class further as the two "has_" properties are only used once in the app code. Unfortunately they are tightly coupled in one of the tests as well [^1]. [^1]: https://github.com/alphagov/notifications-admin/blob/bef0382cca16ba87d04430f8cd391092b1dc91ef/tests/app/main/views/service_settings/test_service_settings.py#L1961-L1962