mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-06-08 07:21:13 -04:00
8f9ade7a8b
This should make the ‘All organisations’ page load a lil’ bit quicker. Still worth caching the domains separately so the response is smaller when we only care about domains. This is because the code that uses the domains is part of the sign up flow, so it’s really important that it’s snappy.
141 lines
3.5 KiB
Python
141 lines
3.5 KiB
Python
from unittest.mock import call
|
|
|
|
import pytest
|
|
|
|
from app import organisations_client
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
(
|
|
'client_method,'
|
|
'expected_cache_get_calls,'
|
|
'cache_value,'
|
|
'expected_api_calls,'
|
|
'expected_cache_set_calls,'
|
|
'expected_return_value,'
|
|
),
|
|
[
|
|
(
|
|
'get_domains',
|
|
[
|
|
call('domains'),
|
|
],
|
|
b"""
|
|
[
|
|
{"name": "org 1", "domains": ["a", "b", "c"]},
|
|
{"name": "org 2", "domains": ["c", "d", "e"]}
|
|
]
|
|
""",
|
|
[],
|
|
[],
|
|
['a', 'b', 'c', 'd', 'e'],
|
|
),
|
|
(
|
|
'get_domains',
|
|
[
|
|
call('domains'),
|
|
call('organisations'),
|
|
],
|
|
None,
|
|
[
|
|
call(url='/organisations')
|
|
],
|
|
[
|
|
call(
|
|
'organisations',
|
|
'[{"domains": ["x", "y", "z"]}]',
|
|
ex=604800,
|
|
),
|
|
call(
|
|
'domains',
|
|
'["x", "y", "z"]',
|
|
ex=604800
|
|
),
|
|
],
|
|
'from api',
|
|
),
|
|
(
|
|
'get_organisations',
|
|
[
|
|
call('organisations'),
|
|
],
|
|
b"""
|
|
[
|
|
{"name": "org 1", "domains": ["a", "b", "c"]},
|
|
{"name": "org 2", "domains": ["c", "d", "e"]}
|
|
]
|
|
""",
|
|
[],
|
|
[],
|
|
[
|
|
{"name": "org 1", "domains": ["a", "b", "c"]},
|
|
{"name": "org 2", "domains": ["c", "d", "e"]}
|
|
],
|
|
),
|
|
(
|
|
'get_organisations',
|
|
[
|
|
call('organisations'),
|
|
],
|
|
None,
|
|
[
|
|
call(url='/organisations')
|
|
],
|
|
[
|
|
call(
|
|
'organisations',
|
|
'[{"domains": ["x", "y", "z"]}]',
|
|
ex=604800,
|
|
),
|
|
],
|
|
'from api',
|
|
),
|
|
]
|
|
)
|
|
def test_returns_value_from_cache(
|
|
app_,
|
|
mocker,
|
|
client_method,
|
|
expected_cache_get_calls,
|
|
cache_value,
|
|
expected_return_value,
|
|
expected_api_calls,
|
|
expected_cache_set_calls,
|
|
):
|
|
|
|
mock_redis_get = mocker.patch(
|
|
'app.extensions.RedisClient.get',
|
|
return_value=cache_value,
|
|
)
|
|
mock_api_get = mocker.patch(
|
|
'app.notify_client.NotifyAdminAPIClient.get',
|
|
return_value=[
|
|
{'domains': ['x', 'y', 'z']}
|
|
],
|
|
)
|
|
mock_redis_set = mocker.patch(
|
|
'app.extensions.RedisClient.set',
|
|
)
|
|
|
|
getattr(organisations_client, client_method)()
|
|
|
|
assert mock_redis_get.call_args_list == expected_cache_get_calls
|
|
assert mock_api_get.call_args_list == expected_api_calls
|
|
assert mock_redis_set.call_args_list == expected_cache_set_calls
|
|
|
|
|
|
def test_deletes_domain_cache(
|
|
app_,
|
|
mock_get_user,
|
|
mocker,
|
|
fake_uuid,
|
|
):
|
|
mocker.patch('app.notify_client.current_user', id='1')
|
|
mock_redis_delete = mocker.patch('app.extensions.RedisClient.delete')
|
|
mock_request = mocker.patch('notifications_python_client.base.BaseAPIClient.request')
|
|
|
|
organisations_client.update_organisation(fake_uuid, foo='bar')
|
|
|
|
assert call('domains') in mock_redis_delete.call_args_list
|
|
assert len(mock_request.call_args_list) == 1
|