mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-02-14 23:44:56 -05:00
d69e8b50cd
`_get_current_service` is a function which gets called every time `current_service` is referenced in a view method or Jinja template. Because the service model was getting initialised inside this function it was being reconstructed many times in one request. On the service settings page, for example, it was getting initialised 43 times, adding about 200ms to the response time. This commit moves its initialisation to the point where we’re getting the data from the API, which only happens once per request.
107 lines
3.7 KiB
Python
107 lines
3.7 KiB
Python
import uuid
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
import werkzeug
|
|
|
|
from app.notify_client import NotifyAdminAPIClient
|
|
from app.notify_client.models import Service
|
|
from tests import service_json
|
|
from tests.conftest import api_user_active, platform_admin_user, set_config
|
|
|
|
SAMPLE_API_KEY = '{}-{}'.format('a' * 36, 's' * 36)
|
|
|
|
|
|
@pytest.mark.parametrize('method', [
|
|
'put',
|
|
'post',
|
|
'delete'
|
|
])
|
|
@pytest.mark.parametrize('user', [
|
|
api_user_active(str(uuid.uuid4())),
|
|
platform_admin_user(str(uuid.uuid4()))
|
|
], ids=['api_user', 'platform_admin'])
|
|
@pytest.mark.parametrize('service', [
|
|
service_json(active=True),
|
|
None
|
|
], ids=['active_service', 'no_service'])
|
|
def test_active_service_can_be_modified(app_, method, user, service):
|
|
api_client = NotifyAdminAPIClient(SAMPLE_API_KEY, 'base_url')
|
|
|
|
with app_.test_request_context() as request_context, app_.test_client() as client:
|
|
client.login(user)
|
|
request_context.service = Service(service)
|
|
|
|
with patch.object(api_client, 'request') as request:
|
|
ret = getattr(api_client, method)('url', 'data')
|
|
|
|
assert request.called
|
|
assert ret == request.return_value
|
|
|
|
|
|
@pytest.mark.parametrize('method', [
|
|
'put',
|
|
'post',
|
|
'delete'
|
|
])
|
|
def test_inactive_service_cannot_be_modified_by_normal_user(app_, api_user_active, method):
|
|
api_client = NotifyAdminAPIClient(SAMPLE_API_KEY, 'base_url')
|
|
|
|
with app_.test_request_context() as request_context, app_.test_client() as client:
|
|
client.login(api_user_active)
|
|
request_context.service = Service(service_json(active=False))
|
|
|
|
with patch.object(api_client, 'request') as request:
|
|
with pytest.raises(werkzeug.exceptions.Forbidden):
|
|
getattr(api_client, method)('url', 'data')
|
|
|
|
assert not request.called
|
|
|
|
|
|
@pytest.mark.parametrize('method', [
|
|
'put',
|
|
'post',
|
|
'delete'
|
|
])
|
|
def test_inactive_service_can_be_modified_by_platform_admin(app_, platform_admin_user, method):
|
|
api_client = NotifyAdminAPIClient(SAMPLE_API_KEY, 'base_url')
|
|
|
|
with app_.test_request_context() as request_context, app_.test_client() as client:
|
|
client.login(platform_admin_user)
|
|
request_context.service = Service(service_json(active=False))
|
|
|
|
with patch.object(api_client, 'request') as request:
|
|
ret = getattr(api_client, method)('url', 'data')
|
|
|
|
assert request.called
|
|
assert ret == request.return_value
|
|
|
|
|
|
def test_generate_headers_sets_standard_headers(app_):
|
|
api_client = NotifyAdminAPIClient(SAMPLE_API_KEY, 'base_url')
|
|
with set_config(app_, 'ROUTE_SECRET_KEY_1', 'proxy-secret'):
|
|
api_client.init_app(app_)
|
|
|
|
# with patch('app.notify_client.has_request_context', return_value=False):
|
|
headers = api_client.generate_headers('api_token')
|
|
|
|
assert set(headers.keys()) == {'Authorization', 'Content-type', 'User-agent', 'X-Custom-Forwarder'}
|
|
assert headers['Authorization'] == 'Bearer api_token'
|
|
assert headers['Content-type'] == 'application/json'
|
|
assert headers['User-agent'].startswith('NOTIFY-API-PYTHON-CLIENT')
|
|
assert headers['X-Custom-Forwarder'] == 'proxy-secret'
|
|
|
|
|
|
def test_generate_headers_sets_request_id_if_in_request_context(app_):
|
|
api_client = NotifyAdminAPIClient(SAMPLE_API_KEY, 'base_url')
|
|
api_client.init_app(app_)
|
|
|
|
with app_.test_request_context() as request_context:
|
|
headers = api_client.generate_headers('api_token')
|
|
|
|
assert set(headers.keys()) == {
|
|
'Authorization', 'Content-type', 'User-agent', 'X-Custom-Forwarder', 'X-B3-TraceId', 'X-B3-SpanId',
|
|
}
|
|
assert headers['X-B3-TraceId'] == request_context.request.request_id
|
|
assert headers['X-B3-SpanId'] == request_context.request.span_id
|