mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-02-19 09:54:36 -05:00
99a8a4fd48
When we combine simplified polygons from different areas we try to use the polygons that are defined in metres as a speed optimisation. This doesn’t work when those polygons are in several different projections because the distance in metres is relative to the edge of the projection. Just naively choosing one projection means that some of the polygons will shift position on the earth by 100s of kilometers once they are converted back to degrees. To avoid this we need to: - check for situations where we have polygons in multiple different projections - transforms these polygons back into degrees and let `Polygons` pick a common projection for all of them before doing any merging/smoothing/etc.
134 lines
3.7 KiB
Python
134 lines
3.7 KiB
Python
import pytest
|
|
|
|
from app.broadcast_areas.models import CustomBroadcastAreas
|
|
from app.models.broadcast_message import BroadcastMessage
|
|
from tests import broadcast_message_json
|
|
|
|
|
|
@pytest.mark.parametrize('areas, expected_area_ids', [
|
|
({'simple_polygons': []}, []),
|
|
({'ids': ['123'], 'simple_polygons': []}, ['123'])
|
|
])
|
|
def test_area_ids(
|
|
areas,
|
|
expected_area_ids,
|
|
):
|
|
broadcast_message = BroadcastMessage(broadcast_message_json(
|
|
areas=areas
|
|
))
|
|
|
|
assert broadcast_message.area_ids == expected_area_ids
|
|
|
|
|
|
def test_simple_polygons():
|
|
broadcast_message = BroadcastMessage(broadcast_message_json(
|
|
area_ids=[
|
|
# Hackney Central
|
|
'wd20-E05009372',
|
|
# Hackney Wick
|
|
'wd20-E05009374',
|
|
],
|
|
))
|
|
|
|
assert [
|
|
[
|
|
len(polygon)
|
|
for polygon in broadcast_message.polygons.as_coordinate_pairs_lat_long
|
|
],
|
|
[
|
|
len(polygon)
|
|
for polygon in broadcast_message.simple_polygons.as_coordinate_pairs_lat_long
|
|
],
|
|
] == [
|
|
# One polygon for each area
|
|
[27, 31],
|
|
# Because the areas are close to each other, the simplification
|
|
# and unioning process results in a single polygon with fewer
|
|
# total coordinates
|
|
[57],
|
|
]
|
|
|
|
|
|
def test_content_comes_from_attribute_not_template():
|
|
broadcast_message = BroadcastMessage(broadcast_message_json())
|
|
assert broadcast_message.content == 'This is a test'
|
|
|
|
|
|
@pytest.mark.parametrize(('areas', 'expected_length'), [
|
|
({'ids': []}, 0),
|
|
({'ids': ['wd20-E05009372']}, 1),
|
|
({'no data': 'just created'}, 0),
|
|
({'names': ['somewhere'], 'simple_polygons': [[[3.5, 1.5]]]}, 1)
|
|
])
|
|
def test_areas(
|
|
areas,
|
|
expected_length
|
|
):
|
|
broadcast_message = BroadcastMessage(broadcast_message_json(
|
|
areas=areas
|
|
))
|
|
|
|
assert len(list(broadcast_message.areas)) == expected_length
|
|
|
|
|
|
def test_areas_treats_missing_ids_as_custom_broadcast(notify_admin):
|
|
broadcast_message = BroadcastMessage(broadcast_message_json(
|
|
areas={
|
|
'ids': [
|
|
'wd20-E05009372',
|
|
'something else',
|
|
],
|
|
# although the IDs may no longer be usable, we can
|
|
# expect the broadcast to have names and polygons,
|
|
# which is enough to show the user something
|
|
'names': [
|
|
'wd20 name',
|
|
'something else name'
|
|
],
|
|
'simple_polygons': [[[1, 2]]]
|
|
}
|
|
))
|
|
|
|
assert len(list(broadcast_message.areas)) == 2
|
|
assert type(broadcast_message.areas) == CustomBroadcastAreas
|
|
|
|
|
|
@pytest.mark.parametrize('area_ids, approx_bounds', (
|
|
([
|
|
'ctry19-N92000002', # Northern Ireland (UTM zone 29N)
|
|
'ctry19-W92000004', # Wales (UTM zone 30N)
|
|
], [
|
|
-8.2, 51.5, -2.1, 55.1
|
|
]),
|
|
([
|
|
'lad20-E06000031', # Peterborough (UTM zone 30N)
|
|
'lad20-E07000146', # Kings Lyn and West Norfolk (UTM zone 31N)
|
|
], [
|
|
-0.5, 52.5, 0.8, 53.0
|
|
]),
|
|
([
|
|
'wd20-E05009372', # Hackney Central (UTM zone 30N)
|
|
'wd20-E05009374', # Hackney Wick (UTM zone 30N)
|
|
], [
|
|
-0.1, 51.5, -0.0, 51.6
|
|
]),
|
|
([
|
|
'wd20-E05009372', # Hackney Central (UTM zone 30N)
|
|
'test-santa-claus-village-rovaniemi-a', # (UTM zone 35N)
|
|
], [
|
|
-0.1, 51.5, 25.9, 66.6
|
|
]),
|
|
))
|
|
def test_combining_multiple_areas_keeps_same_bounds(area_ids, approx_bounds):
|
|
broadcast_message = BroadcastMessage(broadcast_message_json(
|
|
areas={'ids': area_ids}
|
|
))
|
|
|
|
assert [
|
|
round(coordinate, 1) for coordinate in broadcast_message.polygons.bounds
|
|
] == [
|
|
round(coordinate, 1) for coordinate in broadcast_message.simple_polygons.bounds
|
|
] == (
|
|
approx_bounds
|
|
)
|