mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-02-11 22:14:06 -05:00
e0b62bed70
This makes it clearer we have tests for the code in forms.py, which I missed initially. In future we could also split up forms.py in a similar way, as it's currently _very long_. As part of grouping tests for code in forms.py, I've extracted some from test_validators.py, so that what remains is focussed on testing the code in validators.py.
129 lines
3.5 KiB
Python
129 lines
3.5 KiB
Python
from unittest.mock import Mock
|
||
|
||
import pytest
|
||
from wtforms import ValidationError
|
||
|
||
from app.main.validators import (
|
||
MustContainAlphanumericCharacters,
|
||
NoCommasInPlaceHolders,
|
||
OnlySMSCharacters,
|
||
ValidGovEmail,
|
||
)
|
||
|
||
|
||
def _gen_mock_field(x):
|
||
return Mock(data=x)
|
||
|
||
|
||
@pytest.mark.parametrize("email", [
|
||
'test@gov.uk',
|
||
'test@GOV.UK',
|
||
'test@gov.uK',
|
||
'test@test.test.gov.uk',
|
||
'test@test.gov.uk',
|
||
'test@nhs.uk',
|
||
'test@gov.nhs.uk',
|
||
'test@nhs.net',
|
||
'test@gov.nhs.net',
|
||
'test@nhs.scot',
|
||
'test@police.uk',
|
||
'test@gov.police.uk',
|
||
'test@GOV.PoliCe.uk',
|
||
'test@cjsm.net',
|
||
'test@example.ac.uk',
|
||
'test@example.sch.uk',
|
||
])
|
||
def test_valid_list_of_white_list_email_domains(
|
||
client_request,
|
||
email,
|
||
):
|
||
email_domain_validators = ValidGovEmail()
|
||
email_domain_validators(None, _gen_mock_field(email))
|
||
|
||
|
||
@pytest.mark.parametrize("email", [
|
||
'test@ukgov.uk',
|
||
'test@gov.uk.uk',
|
||
'test@gov.test.uk',
|
||
'test@ukmod.uk',
|
||
'test@mod.uk.uk',
|
||
'test@mod.test.uk',
|
||
'test@ukddc-mod.org',
|
||
'test@ddc-mod.org.uk',
|
||
'test@ddc-mod.uk.org',
|
||
'test@ukgov.scot',
|
||
'test@gov.scot.uk',
|
||
'test@gov.test.scot',
|
||
'test@ukparliament.uk',
|
||
'test@parliament.uk.uk',
|
||
'test@parliament.test.uk',
|
||
'test@uknhs.uk',
|
||
'test@nhs.uk.uk',
|
||
'test@uknhs.net',
|
||
'test@nhs.net.uk',
|
||
'test@nhs.test.net',
|
||
'test@ukpolice.uk',
|
||
'test@police.uk.uk',
|
||
'test@police.test.uk',
|
||
'test@ucds.com',
|
||
'test@123bl.uk',
|
||
])
|
||
def test_invalid_list_of_white_list_email_domains(
|
||
client_request,
|
||
email,
|
||
mock_get_organisations,
|
||
):
|
||
email_domain_validators = ValidGovEmail()
|
||
with pytest.raises(ValidationError):
|
||
email_domain_validators(None, _gen_mock_field(email))
|
||
|
||
|
||
def test_for_commas_in_placeholders(
|
||
client_request,
|
||
):
|
||
with pytest.raises(ValidationError) as error:
|
||
NoCommasInPlaceHolders()(None, _gen_mock_field('Hello ((name,date))'))
|
||
assert str(error.value) == 'You cannot put commas between double brackets'
|
||
NoCommasInPlaceHolders()(None, _gen_mock_field('Hello ((name))'))
|
||
|
||
|
||
@pytest.mark.parametrize('msg', ['The quick brown fox', 'Thé “quick” bröwn fox\u200B'])
|
||
def test_sms_character_validation(client_request, msg):
|
||
OnlySMSCharacters(template_type='sms')(None, _gen_mock_field(msg))
|
||
|
||
|
||
@pytest.mark.parametrize('data, err_msg', [
|
||
(
|
||
'∆ abc 📲 def 📵 ghi',
|
||
(
|
||
'You cannot use ∆, 📲 or 📵 in text messages. '
|
||
'They will not show up properly on everyone’s phones.'
|
||
)
|
||
),
|
||
(
|
||
'📵',
|
||
(
|
||
'You cannot use 📵 in text messages. '
|
||
'It will not show up properly on everyone’s phones.'
|
||
)
|
||
),
|
||
])
|
||
def test_non_sms_character_validation(data, err_msg, client_request):
|
||
with pytest.raises(ValidationError) as error:
|
||
OnlySMSCharacters(template_type='sms')(None, _gen_mock_field(data))
|
||
|
||
assert str(error.value) == err_msg
|
||
|
||
|
||
@pytest.mark.parametrize("string", [".", "A.", ".8...."])
|
||
def test_if_string_does_not_contain_alphanumeric_characters_raises(string):
|
||
with pytest.raises(ValidationError) as error:
|
||
MustContainAlphanumericCharacters()(None, _gen_mock_field(string))
|
||
|
||
assert str(error.value) == "Must include at least two alphanumeric characters"
|
||
|
||
|
||
@pytest.mark.parametrize("string", [".A8", "AB.", ".42...."])
|
||
def test_if_string_contains_alphanumeric_characters_does_not_raise(string):
|
||
MustContainAlphanumericCharacters()(None, _gen_mock_field(string))
|