mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-07-30 19:29:43 -04:00
eb3734f1d1
Makes uses of the additions to utils in https://github.com/alphagov/notifications-utils/pull/9 This commit strips out a lot of the complex stuff that the views and templates in this app were doing. There is now a cleaner separation of concerns: - utils returns the number and type of errors in the csv - `get_errors_for_csv` helper in this app maps the number and type of errors onto human-friendly error messages - the view and template just doing the glueing-together of all the pieces This is (hopefully) easier to understand, definitely makes the component parts easier to test in isolation, and makes it easier to give more specific error messages.
109 lines
5.1 KiB
Python
109 lines
5.1 KiB
Python
from flask import url_for
|
|
|
|
|
|
def test_render_register_returns_template_with_form(app_):
|
|
response = app_.test_client().get('/register')
|
|
|
|
assert response.status_code == 200
|
|
assert 'Create an account' in response.get_data(as_text=True)
|
|
|
|
|
|
def test_logged_in_user_redirects_to_choose_service(app_,
|
|
api_user_active,
|
|
mock_get_user_by_email,
|
|
mock_send_verify_code,
|
|
mock_login):
|
|
with app_.test_request_context():
|
|
with app_.test_client() as client:
|
|
client.login(api_user_active)
|
|
response = client.get(url_for('main.register'))
|
|
assert response.status_code == 302
|
|
|
|
response = client.get(url_for('main.sign_in', follow_redirects=True))
|
|
assert response.location == url_for('main.choose_service', _external=True)
|
|
|
|
|
|
def test_process_register_creates_new_user(app_,
|
|
mock_send_verify_code,
|
|
mock_register_user,
|
|
mock_get_user_by_email_not_found,
|
|
mock_login):
|
|
user_data = {
|
|
'name': 'Some One Valid',
|
|
'email_address': 'notfound@example.gov.uk',
|
|
'mobile_number': '+4407700900460',
|
|
'password': 'validPassword!'
|
|
}
|
|
|
|
with app_.test_request_context():
|
|
response = app_.test_client().post(url_for('main.register'),
|
|
data=user_data)
|
|
assert response.status_code == 302
|
|
assert response.location == url_for('main.verify', _external=True)
|
|
assert mock_register_user.called
|
|
|
|
|
|
def test_process_register_returns_400_when_mobile_number_is_invalid(app_,
|
|
mock_send_verify_code,
|
|
mock_get_user_by_email_not_found,
|
|
mock_login):
|
|
with app_.test_request_context():
|
|
response = app_.test_client().post(url_for('main.register'),
|
|
data={'name': 'Bad Mobile',
|
|
'email_address': 'bad_mobile@example.gov.uk',
|
|
'mobile_number': 'not good',
|
|
'password': 'validPassword!'})
|
|
|
|
assert response.status_code == 200
|
|
assert 'Must not contain letters or symbols' in response.get_data(as_text=True)
|
|
|
|
|
|
def test_should_return_400_when_email_is_not_gov_uk(app_,
|
|
mock_send_verify_code,
|
|
mock_get_user_by_email,
|
|
mock_login):
|
|
with app_.test_request_context():
|
|
response = app_.test_client().post(url_for('main.register'),
|
|
data={'name': 'Bad Mobile',
|
|
'email_address': 'bad_mobile@example.not.right',
|
|
'mobile_number': '+44123412345',
|
|
'password': 'validPassword!'})
|
|
|
|
assert response.status_code == 200
|
|
assert 'Enter a gov.uk email address' in response.get_data(as_text=True)
|
|
|
|
|
|
def test_should_add_verify_codes_on_session(app_,
|
|
mock_send_verify_code,
|
|
mock_register_user,
|
|
mock_get_user,
|
|
mock_get_user_by_email_not_found,
|
|
mock_login):
|
|
user_data = {
|
|
'name': 'Test Codes',
|
|
'email_address': 'notfound@example.gov.uk',
|
|
'mobile_number': '+4407700900460',
|
|
'password': 'validPassword!'
|
|
}
|
|
|
|
with app_.test_request_context():
|
|
with app_.test_client() as client:
|
|
response = client.post(url_for('main.register'),
|
|
data=user_data)
|
|
assert response.status_code == 302
|
|
assert 'notify_admin_session' in response.headers.get('Set-Cookie')
|
|
|
|
|
|
def test_should_return_400_if_password_is_blacklisted(app_,
|
|
mock_get_user_by_email,
|
|
mock_login):
|
|
with app_.test_request_context():
|
|
response = app_.test_client().post(url_for('main.register'),
|
|
data={'name': 'Bad Mobile',
|
|
'email_address': 'bad_mobile@example.not.right',
|
|
'mobile_number': '+44123412345',
|
|
'password': 'password1234'})
|
|
|
|
response.status_code == 200
|
|
assert 'That password is blacklisted, too common' in response.get_data(as_text=True)
|