mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-04-30 22:21:16 -04:00
This replaces multiple stubs with a single stub on the lower level API client method to return the desired set of templates. You can see this most clearly in the diff for the "_sms_sender_" test: - Add a stub for "get_service_templates" - Remove stubs for "all_templates" and "get_templates" In order to make the change, I had to separate the reply-to set of tests from the "_things_right" tests because "count_of_templates" was actually in conflict with "count_of_email_templates". To make the new test I copied the original and removed unnecessary stubs from both of them depending on what's being tested. I'm not sure what the "_things_right" test name means; the name of the new test is at least consistent with others in the file. Note: I also removed the "assert mock_templates.called is True" lines as they wasn't adding any value that I can see.