mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-05-30 02:50:03 -04:00
c95b2ef8b3
For someone who has retrieved a template ID from their system the only way to find it in Notify is: - hack the URL - click through every template, visually inspecting the ID shown on the page until you find the right one Neither of these is ideal. This commit adds searching by ID, for those services who have an API integration. This means we don’t need to confuse teams who aren’t using the API by talking about IDs. This is similar to how we let these teams search for notifications by reference[1] 1. https://github.com/alphagov/notifications-admin/pull/3223/files
92 lines
2.3 KiB
Python
92 lines
2.3 KiB
Python
from functools import partial
|
|
|
|
import pytest
|
|
from flask import url_for
|
|
|
|
letters_urls = [
|
|
partial(url_for, 'main.add_service_template', template_type='letter'),
|
|
]
|
|
|
|
|
|
@pytest.mark.parametrize('url', letters_urls)
|
|
@pytest.mark.parametrize('permissions, response_code', [
|
|
(['letter'], 200),
|
|
([], 403)
|
|
])
|
|
def test_letters_access_restricted(
|
|
client_request,
|
|
platform_admin_user,
|
|
mocker,
|
|
permissions,
|
|
response_code,
|
|
mock_get_service_templates,
|
|
url,
|
|
service_one,
|
|
):
|
|
service_one['permissions'] = permissions
|
|
client_request.login(platform_admin_user)
|
|
client_request.get_url(
|
|
url(service_id=service_one['id']),
|
|
_follow_redirects=True,
|
|
_expected_status=response_code,
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize('url', letters_urls)
|
|
def test_letters_lets_in_without_permission(
|
|
client,
|
|
mocker,
|
|
mock_login,
|
|
mock_has_permissions,
|
|
api_user_active,
|
|
mock_get_service_templates,
|
|
url,
|
|
service_one
|
|
):
|
|
service_one['permissions'] = ['letter']
|
|
mocker.patch('app.service_api_client.get_service', return_value={"data": service_one})
|
|
|
|
client.login(api_user_active)
|
|
response = client.get(url(service_id=service_one['id']))
|
|
|
|
assert api_user_active['permissions'] == {}
|
|
assert response.status_code == 200
|
|
|
|
|
|
@pytest.mark.parametrize('permissions, choices', [
|
|
(
|
|
['email', 'sms', 'letter'],
|
|
['Email', 'Text message', 'Letter', 'Copy an existing template']
|
|
),
|
|
(
|
|
['email', 'sms'],
|
|
['Email', 'Text message', 'Copy an existing template']
|
|
),
|
|
])
|
|
def test_given_option_to_add_letters_if_allowed(
|
|
client_request,
|
|
service_one,
|
|
mocker,
|
|
mock_get_service_templates,
|
|
mock_get_template_folders,
|
|
mock_get_organisations_and_services_for_user,
|
|
mock_get_api_keys,
|
|
permissions,
|
|
choices,
|
|
):
|
|
service_one['permissions'] = permissions
|
|
|
|
page = client_request.get('main.choose_template', service_id=service_one['id'])
|
|
|
|
radios = page.select('#add_new_template_form input[type=radio]')
|
|
labels = page.select('#add_new_template_form label')
|
|
|
|
assert len(radios) == len(choices)
|
|
assert len(labels) == len(choices)
|
|
|
|
for index, choice in enumerate(permissions):
|
|
assert radios[index]['value'] == choice
|
|
|
|
for index, label in enumerate(choices):
|
|
assert labels[index].text.strip() == label
|