mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-02-26 21:31:11 -05:00
f3a0c505bd
Done using isort[1], with the following command:
```
isort -rc ./app ./tests
```
Adds linting to the `run_tests.sh` script to stop badly-sorted imports
getting re-introduced.
Chosen style is ‘Vertical Hanging Indent’ with trailing commas, because
I think it gives the cleanest diffs, eg:
```
from third_party import (
lib1,
lib2,
lib3,
lib4,
)
```
1. https://pypi.python.org/pypi/isort
83 lines
2.4 KiB
Python
83 lines
2.4 KiB
Python
from app import user_api_client
|
|
from app.main.forms import TwoFactorForm
|
|
|
|
|
|
def test_form_is_valid_returns_no_errors(
|
|
app_,
|
|
mock_check_verify_code,
|
|
):
|
|
with app_.test_request_context(
|
|
method='POST',
|
|
data={'sms_code': '12345'}
|
|
):
|
|
def _check_code(code):
|
|
return user_api_client.check_verify_code('1', code, "sms")
|
|
form = TwoFactorForm(_check_code)
|
|
assert form.validate() is True
|
|
assert len(form.errors) == 0
|
|
|
|
|
|
def test_returns_errors_when_code_is_too_short(
|
|
app_,
|
|
mock_check_verify_code,
|
|
):
|
|
with app_.test_request_context(
|
|
method='POST',
|
|
data={'sms_code': '145'}
|
|
):
|
|
def _check_code(code):
|
|
return user_api_client.check_verify_code('1', code, "sms")
|
|
form = TwoFactorForm(_check_code)
|
|
assert form.validate() is False
|
|
assert len(form.errors) == 1
|
|
assert set(form.errors) == set({'sms_code': ['Code not found', 'Code does not match']})
|
|
|
|
|
|
def test_returns_errors_when_code_is_missing(
|
|
app_,
|
|
mock_check_verify_code,
|
|
):
|
|
with app_.test_request_context(
|
|
method='POST',
|
|
data={}
|
|
):
|
|
def _check_code(code):
|
|
return user_api_client.check_verify_code('1', code, "sms")
|
|
form = TwoFactorForm(_check_code)
|
|
assert form.validate() is False
|
|
assert len(form.errors) == 1
|
|
assert set(form.errors) == set({'sms_code': ['Code must not be empty']})
|
|
|
|
|
|
def test_returns_errors_when_code_contains_letters(
|
|
app_,
|
|
mock_check_verify_code,
|
|
):
|
|
with app_.test_request_context(
|
|
method='POST',
|
|
data={'sms_code': 'asdfg'}
|
|
):
|
|
def _check_code(code):
|
|
return user_api_client.check_verify_code('1', code, "sms")
|
|
form = TwoFactorForm(_check_code)
|
|
assert form.validate() is False
|
|
assert len(form.errors) == 1
|
|
assert set(form.errors) == set({'sms_code': ['Code not found', 'Code does not match']})
|
|
|
|
|
|
def test_should_return_errors_when_code_is_expired(
|
|
app_,
|
|
mock_check_verify_code_code_expired,
|
|
):
|
|
with app_.test_request_context(
|
|
method='POST',
|
|
data={'sms_code': '23456'}
|
|
):
|
|
def _check_code(code):
|
|
return user_api_client.check_verify_code('1', code, "sms")
|
|
form = TwoFactorForm(_check_code)
|
|
assert form.validate() is False
|
|
errors = form.errors
|
|
assert len(errors) == 1
|
|
assert errors == {'sms_code': ['Code has expired']}
|