Files
notifications-admin/tests/app/main/views/test_user_profile.py
Leo Hemsted 4df12f5f4e ensure other 2FA pages also handle session id
specifically, the 2FA page when you first create an account is different to the login 2FA page
and also the 2FA page when you change your phone number is different as well
2017-02-24 16:32:59 +00:00

250 lines
7.9 KiB
Python

import uuid
import json
from flask import url_for
from notifications_utils.url_safe_token import generate_token
from tests.conftest import api_user_active as create_user
def test_should_show_overview_page(
logged_in_client,
):
response = logged_in_client.get(url_for('main.user_profile'))
assert 'Your profile' in response.get_data(as_text=True)
assert response.status_code == 200
def test_should_show_name_page(
logged_in_client
):
response = logged_in_client.get(url_for('main.user_profile_name'))
assert 'Change your name' in response.get_data(as_text=True)
assert response.status_code == 200
def test_should_redirect_after_name_change(
logged_in_client,
api_user_active,
mock_update_user_attribute,
):
new_name = 'New Name'
data = {'new_name': new_name}
response = logged_in_client.post(url_for(
'main.user_profile_name'), data=data)
assert response.status_code == 302
assert response.location == url_for('main.user_profile', _external=True)
assert mock_update_user_attribute.called
def test_should_show_email_page(
logged_in_client,
):
response = logged_in_client.get(url_for(
'main.user_profile_email'))
assert 'Change your email address' in response.get_data(as_text=True)
assert response.status_code == 200
def test_should_redirect_after_email_change(
logged_in_client,
mock_login,
mock_is_email_unique,
):
data = {'email_address': 'new_notify@notify.gov.uk'}
response = logged_in_client.post(
url_for('main.user_profile_email'),
data=data)
assert response.status_code == 302
assert response.location == url_for(
'main.user_profile_email_authenticate', _external=True)
def test_should_show_authenticate_after_email_change(
logged_in_client,
):
with logged_in_client.session_transaction() as session:
session['new-email'] = 'new_notify@notify.gov.uk'
response = logged_in_client.get(url_for('main.user_profile_email_authenticate'))
assert response.status_code == 200
assert 'Change your email address' in response.get_data(as_text=True)
assert 'Confirm' in response.get_data(as_text=True)
def test_should_render_change_email_continue_after_authenticate_email(
logged_in_client,
mock_verify_password,
mock_send_change_email_verification,
):
data = {'password': '12345'}
with logged_in_client.session_transaction() as session:
session['new-email'] = 'new_notify@notify.gov.uk'
response = logged_in_client.post(
url_for('main.user_profile_email_authenticate'),
data=data)
assert response.status_code == 200
assert 'Click the link in the email to confirm the change to your email address.' \
in response.get_data(as_text=True)
def test_should_redirect_to_user_profile_when_user_confirms_email_link(
app_,
logged_in_client,
api_user_active,
mock_update_user_attribute,
):
token = generate_token(payload=json.dumps({'user_id': api_user_active.id, 'email': 'new_email@gov.uk'}),
secret=app_.config['SECRET_KEY'], salt=app_.config['DANGEROUS_SALT'])
response = logged_in_client.get(url_for('main.user_profile_email_confirm', token=token))
assert response.status_code == 302
assert response.location == url_for('main.user_profile', _external=True)
def test_should_show_mobile_number_page(
logged_in_client,
):
response = logged_in_client.get(url_for('main.user_profile_mobile_number'))
assert 'Change your mobile number' in response.get_data(as_text=True)
assert response.status_code == 200
def test_should_redirect_after_mobile_number_change(
logged_in_client,
):
data = {'mobile_number': '07121231234'}
response = logged_in_client.post(
url_for('main.user_profile_mobile_number'),
data=data)
assert response.status_code == 302
assert response.location == url_for(
'main.user_profile_mobile_number_authenticate', _external=True)
def test_should_show_authenticate_after_mobile_number_change(
logged_in_client,
):
with logged_in_client.session_transaction() as session:
session['new-mob'] = '+441234123123'
response = logged_in_client.get(
url_for('main.user_profile_mobile_number_authenticate'))
assert 'Change your mobile number' in response.get_data(as_text=True)
assert 'Confirm' in response.get_data(as_text=True)
assert response.status_code == 200
def test_should_redirect_after_mobile_number_authenticate(
logged_in_client,
mock_verify_password,
mock_send_verify_code,
):
with logged_in_client.session_transaction() as session:
session['new-mob'] = '+441234123123'
data = {'password': '12345667'}
response = logged_in_client.post(
url_for('main.user_profile_mobile_number_authenticate'),
data=data)
assert response.status_code == 302
assert response.location == url_for(
'main.user_profile_mobile_number_confirm', _external=True)
def test_should_show_confirm_after_mobile_number_change(
logged_in_client,
):
with logged_in_client.session_transaction() as session:
session['new-mob-password-confirmed'] = True
response = logged_in_client.get(
url_for('main.user_profile_mobile_number_confirm'))
assert 'Change your mobile number' in response.get_data(as_text=True)
assert 'Confirm' in response.get_data(as_text=True)
assert response.status_code == 200
def test_should_redirect_after_mobile_number_confirm(
logged_in_client,
mocker,
mock_update_user_attribute,
mock_check_verify_code,
fake_uuid
):
user_before = create_user(fake_uuid)
user_after = create_user(fake_uuid)
user_before.current_session_id = str(uuid.UUID(int=1))
user_after.current_session_id = str(uuid.UUID(int=2))
# first time (login decorator) return normally, second time (after 2FA return with new session id)
mocker.patch('app.user_api_client.get_user', side_effect=[user_before, user_after])
with logged_in_client.session_transaction() as session:
session['new-mob-password-confirmed'] = True
session['new-mob'] = '+441234123123'
session['current_session_id'] = user_before.current_session_id
data = {'sms_code': '12345'}
response = logged_in_client.post(
url_for('main.user_profile_mobile_number_confirm'),
data=data)
assert response.status_code == 302
assert response.location == url_for(
'main.user_profile', _external=True)
# make sure the current_session_id has changed to what the API returned
with logged_in_client.session_transaction() as session:
assert session['current_session_id'] == user_after.current_session_id
def test_should_show_password_page(
logged_in_client,
):
response = logged_in_client.get(url_for('main.user_profile_password'))
assert 'Change your password' in response.get_data(as_text=True)
assert response.status_code == 200
def test_should_redirect_after_password_change(
logged_in_client,
mock_update_user_password,
mock_verify_password,
):
data = {
'new_password': 'the new password',
'old_password': 'the old password'}
response = logged_in_client.post(
url_for('main.user_profile_password'),
data=data)
assert response.status_code == 302
assert response.location == url_for(
'main.user_profile', _external=True)
def test_non_gov_user_cannot_see_change_email_link(
logged_in_client,
mock_get_non_govuser,
):
response = logged_in_client.get(url_for('main.user_profile'))
assert '<a href="/user-profile/email">' not in response.get_data(as_text=True)
assert 'Your profile' in response.get_data(as_text=True)
assert response.status_code == 200
def test_non_gov_user_cannot_access_change_email_page(
logged_in_client,
mock_get_non_govuser,
):
response = logged_in_client.get(url_for('main.user_profile_email'))
assert response.status_code == 403