mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-02-23 20:01:01 -05:00
ef335e7601
We mostly rely on the API returning a 404 to generate 404s for trying to get things with non-UUID IDs. This is fine, except our tests often mock these API calls. So it could look like everything is working fine, except the thing your passing in might never be a valid UUID, and thus would 404 in a non-test environment. So this commit: 1. uses the `uuid` URL converter everywhere there’s something that looks like an ID in a URL parameter 2. adds a test which automates checking for 1.
46 lines
1.5 KiB
Python
46 lines
1.5 KiB
Python
from flask import flash, redirect, render_template, request, url_for
|
|
from flask_login import current_user
|
|
|
|
from app import user_api_client
|
|
from app.event_handlers import create_archive_user_event
|
|
from app.main import main
|
|
from app.main.forms import SearchUsersByEmailForm
|
|
from app.models.user import User
|
|
from app.utils import user_is_platform_admin
|
|
|
|
|
|
@main.route("/find-users-by-email", methods=['GET', 'POST'])
|
|
@user_is_platform_admin
|
|
def find_users_by_email():
|
|
form = SearchUsersByEmailForm()
|
|
users_found = None
|
|
if form.validate_on_submit():
|
|
users_found = user_api_client.find_users_by_full_or_partial_email(form.search.data)['data']
|
|
return render_template(
|
|
'views/find-users/find-users-by-email.html',
|
|
form=form,
|
|
users_found=users_found
|
|
)
|
|
|
|
|
|
@main.route("/users/<uuid:user_id>", methods=['GET'])
|
|
@user_is_platform_admin
|
|
def user_information(user_id):
|
|
return render_template(
|
|
'views/find-users/user-information.html',
|
|
user=User.from_id(user_id),
|
|
)
|
|
|
|
|
|
@main.route("/users/<uuid:user_id>/archive", methods=['GET', 'POST'])
|
|
@user_is_platform_admin
|
|
def archive_user(user_id):
|
|
if request.method == 'POST':
|
|
user_api_client.archive_user(user_id)
|
|
create_archive_user_event(str(user_id), current_user.id)
|
|
|
|
return redirect(url_for('.user_information', user_id=user_id))
|
|
else:
|
|
flash('There\'s no way to reverse this! Are you sure you want to archive this user?', 'delete')
|
|
return user_information(user_id)
|