Ben Thorner b3f48c1a84 Backup original precompiled uploads to S3 ...

This continues the work from Template Preview [1], so that we have
a complete store of original PDFs to use for testing changes to it.

Previously we did store some originals, but these were only invalid
PDFs that had failed sanitisation; for valid PDFs, the "transient"
bucket only contains the sanitised versions, which the API deletes
/ moves when the notification is sent [2].

Since the notification is only created at a later stage [3], there's
no easy way to get the final name of the PDF we send to DVLA. Instead,
we use the "upload_id", which eventually becomes the notification ID
[4]. This should be enough to trace the file for specific debugging.

Note that we only want to store original PDFs if they're valid (and
virus free!), since there's no point testing changes with bad data.

[1]: https://github.com/alphagov/notifications-template-preview/pull/545
[2]: c44ec57c17/app/service/send_notification.py (L212)
[3]: 7930a53a58/app/main/views/uploads.py (L362)
[4]: 7930a53a58/app/main/views/uploads.py (L373)

2021-06-24 12:21:05 +01:00

..

__init__.py

…

s3_csv_client.py

Delete unused function

2020-10-29 13:53:50 +00:00

s3_letter_upload_client.py

Backup original precompiled uploads to S3

2021-06-24 12:21:05 +01:00

s3_logo_client.py

…

s3_mou_client.py

…