mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-07-08 10:28:57 -04:00
Anyone choosing ‘NHS’ for their organisation type gets should get the NHS branding. We don’t want to hard-code an ID for NHS branding anywhere because it won’t be consistent between environments. So instead we can say that anyone who chooses ‘NHS’ as their organisation type should get whatever branding has `nhs.uk` as its domain. This allows us to easily manage the branding the same way we do other brands, but gives us the efficiency of having it auto applied.
201 lines
6.3 KiB
Python
201 lines
6.3 KiB
Python
import pytest
|
||
from flask import session, url_for
|
||
|
||
from app.utils import is_gov_user
|
||
|
||
|
||
def test_non_gov_user_cannot_see_add_service_button(
|
||
client,
|
||
mock_login,
|
||
mock_get_non_govuser,
|
||
api_nongov_user_active,
|
||
mock_get_organisations_and_services_for_user
|
||
):
|
||
client.login(api_nongov_user_active)
|
||
response = client.get(url_for('main.choose_account'))
|
||
assert 'Add a new service' not in response.get_data(as_text=True)
|
||
assert response.status_code == 200
|
||
|
||
|
||
def test_get_should_render_add_service_template(
|
||
logged_in_client
|
||
):
|
||
response = logged_in_client.get(url_for('main.add_service'))
|
||
assert response.status_code == 200
|
||
assert 'About your service' in response.get_data(as_text=True)
|
||
|
||
|
||
def test_should_add_service_and_redirect_to_tour_when_no_services(
|
||
app_,
|
||
logged_in_client,
|
||
mock_create_service,
|
||
mock_create_service_template,
|
||
mock_get_services_with_no_services,
|
||
api_user_active,
|
||
mock_create_or_update_free_sms_fragment_limit,
|
||
mock_get_all_email_branding,
|
||
):
|
||
response = logged_in_client.post(
|
||
url_for('main.add_service'),
|
||
data={
|
||
'name': 'testing the post',
|
||
'organisation_type': 'local',
|
||
}
|
||
)
|
||
assert mock_get_services_with_no_services.called
|
||
mock_create_service.assert_called_once_with(
|
||
service_name='testing the post',
|
||
organisation_type='local',
|
||
message_limit=app_.config['DEFAULT_SERVICE_LIMIT'],
|
||
restricted=True,
|
||
user_id=api_user_active.id,
|
||
email_from='testing.the.post'
|
||
)
|
||
mock_create_service_template.assert_called_once_with(
|
||
'Example text message template',
|
||
'sms',
|
||
(
|
||
'Hey ((name)), I’m trying out Notify. Today is '
|
||
'((day of week)) and my favourite colour is ((colour)).'
|
||
),
|
||
101,
|
||
)
|
||
assert session['service_id'] == 101
|
||
assert response.status_code == 302
|
||
assert response.location == url_for(
|
||
'main.start_tour',
|
||
service_id=101,
|
||
template_id="Example%20text%20message%20template",
|
||
_external=True
|
||
)
|
||
mock_create_or_update_free_sms_fragment_limit.assert_called_once_with(101, 25000)
|
||
|
||
|
||
@pytest.mark.parametrize('organisation_type, free_allowance', [
|
||
('central', 250 * 1000),
|
||
('local', 25 * 1000),
|
||
('nhs', 25 * 1000),
|
||
])
|
||
def test_should_add_service_and_redirect_to_dashboard_when_existing_service(
|
||
app_,
|
||
logged_in_client,
|
||
mock_create_service,
|
||
mock_create_service_template,
|
||
mock_get_services,
|
||
mock_update_service,
|
||
api_user_active,
|
||
organisation_type,
|
||
free_allowance,
|
||
mock_create_or_update_free_sms_fragment_limit,
|
||
mock_get_all_email_branding,
|
||
):
|
||
response = logged_in_client.post(
|
||
url_for('main.add_service'),
|
||
data={
|
||
'name': 'testing the post',
|
||
'organisation_type': organisation_type,
|
||
}
|
||
)
|
||
assert mock_get_services.called
|
||
mock_create_service.assert_called_once_with(
|
||
service_name='testing the post',
|
||
organisation_type=organisation_type,
|
||
message_limit=app_.config['DEFAULT_SERVICE_LIMIT'],
|
||
restricted=True,
|
||
user_id=api_user_active.id,
|
||
email_from='testing.the.post'
|
||
)
|
||
mock_create_or_update_free_sms_fragment_limit.assert_called_once_with(101, free_allowance)
|
||
assert len(mock_create_service_template.call_args_list) == 0
|
||
assert session['service_id'] == 101
|
||
assert response.status_code == 302
|
||
assert response.location == url_for('main.service_dashboard', service_id=101, _external=True)
|
||
|
||
|
||
@pytest.mark.parametrize('organisation_type, email_address, expected_branding', [
|
||
('central', 'test@example.voa.gsi.gov.uk', '5'),
|
||
('central', 'test@example.voa.gov.uk', '5'),
|
||
('central', 'test@example.gov.uk', None),
|
||
# Anyone choosing ‘NHS’ for organisation type gets NHS branding no
|
||
# matter what their email domain is (but we look it up based on the
|
||
# `nhs.uk` domain to avoid hard-coding a branding ID anywhere)
|
||
('nhs', 'test@example.voa.gov.uk', '4'),
|
||
('nhs', 'test@nhs.uk', '4'),
|
||
])
|
||
def test_should_lookup_branding_for_known_domain(
|
||
app_,
|
||
client_request,
|
||
active_user_with_permissions,
|
||
mock_create_service,
|
||
mock_get_services,
|
||
mock_update_service,
|
||
mock_create_or_update_free_sms_fragment_limit,
|
||
mock_get_all_email_branding,
|
||
organisation_type,
|
||
email_address,
|
||
expected_branding,
|
||
):
|
||
active_user_with_permissions.email_address = email_address
|
||
client_request.login(active_user_with_permissions)
|
||
client_request.post(
|
||
'main.add_service',
|
||
_data={
|
||
'name': 'testing the post',
|
||
'organisation_type': organisation_type,
|
||
}
|
||
)
|
||
mock_get_all_email_branding.assert_called_once_with()
|
||
assert mock_create_service.called is True
|
||
if expected_branding:
|
||
mock_update_service.assert_called_once_with(
|
||
101,
|
||
email_branding=expected_branding,
|
||
)
|
||
else:
|
||
assert mock_update_service.called is False
|
||
|
||
|
||
def test_should_return_form_errors_when_service_name_is_empty(
|
||
logged_in_client
|
||
):
|
||
response = logged_in_client.post(url_for('main.add_service'), data={})
|
||
assert response.status_code == 200
|
||
assert 'Can’t be empty' in response.get_data(as_text=True)
|
||
|
||
|
||
def test_should_return_form_errors_with_duplicate_service_name_regardless_of_case(
|
||
logged_in_client,
|
||
mock_create_duplicate_service,
|
||
mock_get_all_email_branding,
|
||
):
|
||
response = logged_in_client.post(
|
||
url_for('main.add_service'),
|
||
data={
|
||
'name': 'SERVICE ONE',
|
||
'organisation_type': 'central',
|
||
},
|
||
)
|
||
|
||
assert response.status_code == 200
|
||
assert 'This service name is already in use' in response.get_data(as_text=True)
|
||
|
||
|
||
def test_non_whitelist_user_cannot_access_create_service_page(
|
||
logged_in_client,
|
||
mock_get_non_govuser,
|
||
api_nongov_user_active,
|
||
):
|
||
assert not is_gov_user(api_nongov_user_active.email_address)
|
||
response = logged_in_client.get(url_for('main.add_service'))
|
||
assert response.status_code == 403
|
||
|
||
|
||
def test_non_whitelist_user_cannot_create_service(
|
||
logged_in_client,
|
||
mock_get_non_govuser,
|
||
api_nongov_user_active,
|
||
):
|
||
assert not is_gov_user(api_nongov_user_active.email_address)
|
||
response = logged_in_client.post(url_for('main.add_service'), data={'name': 'SERVICE TWO'})
|
||
assert response.status_code == 403
|