mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-02-10 05:14:05 -05:00
Done using isort[1], with the following command:
```
isort -rc ./app ./tests
```
Adds linting to the `run_tests.sh` script to stop badly-sorted imports
getting re-introduced.
Chosen style is ‘Vertical Hanging Indent’ with trailing commas, because
I think it gives the cleanest diffs, eg:
```
from third_party import (
lib1,
lib2,
lib3,
lib4,
)
```
1. https://pypi.python.org/pypi/isort
54 lines
1.4 KiB
Python
54 lines
1.4 KiB
Python
import importlib
|
|
import os
|
|
from unittest import mock
|
|
|
|
import pytest
|
|
|
|
from app import config
|
|
|
|
|
|
def cf_conf():
|
|
os.environ['API_HOST_NAME'] = 'cf'
|
|
|
|
|
|
@pytest.fixture
|
|
def reload_config():
|
|
"""
|
|
Reset config, by simply re-running config.py from a fresh environment
|
|
"""
|
|
old_env = os.environ.copy()
|
|
|
|
yield
|
|
|
|
os.environ = old_env
|
|
importlib.reload(config)
|
|
|
|
|
|
def test_load_cloudfoundry_config_if_available(monkeypatch, reload_config):
|
|
os.environ['API_HOST_NAME'] = 'env'
|
|
monkeypatch.setenv('VCAP_APPLICATION', 'some json blob')
|
|
|
|
with mock.patch('app.cloudfoundry_config.extract_cloudfoundry_config', side_effect=cf_conf) as cf_config:
|
|
# reload config so that its module level code (ie: all of it) is re-instantiated
|
|
importlib.reload(config)
|
|
|
|
assert cf_config.called
|
|
|
|
assert os.environ['API_HOST_NAME'] == 'cf'
|
|
assert config.Config.API_HOST_NAME == 'cf'
|
|
|
|
|
|
def test_load_config_if_cloudfoundry_not_available(monkeypatch, reload_config):
|
|
os.environ['API_HOST_NAME'] = 'env'
|
|
|
|
monkeypatch.delenv('VCAP_APPLICATION', raising=False)
|
|
|
|
with mock.patch('app.cloudfoundry_config.extract_cloudfoundry_config') as cf_config:
|
|
# reload config so that its module level code (ie: all of it) is re-instantiated
|
|
importlib.reload(config)
|
|
|
|
assert not cf_config.called
|
|
|
|
assert os.environ['API_HOST_NAME'] == 'env'
|
|
assert config.Config.API_HOST_NAME == 'env'
|