Ben Thorner 4fef2861c6 Catch error if letter does not exist on send ...

This repeats the pattern we already have for previewing a letter,
where we assume the error is because the notification has already
been sent and redirect the user to see it.

I've improved the original pattern a bit:

- I've DRYed-up the low-level boto code and moved the error handler
there so it can be reused.

- I've introduced a custom exception, which the calling code can
choose to log.

- I've introduced the moto library, which we use elsewhere, to make
it easier to test S3 code.

I've used an error level log when sending a notification - now that
we have a more descriptive log, we can verify the assumption is true
and then make an informed decision to downgrade the log.

In future we may want to merge this handler with the similar code
in utils [1], but we'll need to be careful as the utils handler is
superficial - it doesn't check the reason for the error.

[1]: bce0f4e596/notifications_utils/s3.py (L52)

2022-02-18 14:52:27 +00:00

..

__init__.py

…

s3_csv_client.py

Delete unused function

2020-10-29 13:53:50 +00:00

s3_letter_upload_client.py

Catch error if letter does not exist on send

2022-02-18 14:52:27 +00:00

s3_logo_client.py

don't convert letter logo svgs to pngs

2020-03-02 18:00:26 +00:00

s3_mou_client.py

…