mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-06-24 09:21:06 -04:00
85aeebcdd5
The original code to raise the exception was flawed: if a broadcast
only had a single area that was invalid, we would assume it was a
custom broadcast [1]. Since the recent changes [2] fixed the flaw
we're now getting exceptions for broadcasts of this kind.
It's not practical to go and manually fix the invalid broadcasts,
and the likelihood is there will be more in future as the set of
areas we support changes. This takes a pragmatic approach of simply
logging the issue and pretending such broadcasts are custom.
[1]: 926ada2f21
[2]: https://github.com/alphagov/notifications-admin/pull/4014/files#diff-2dd8f77d6df281e7674b20263cdf27a3d58b839dc5930c0087ac8b9749b313e4R92
94 lines
2.6 KiB
Python
94 lines
2.6 KiB
Python
import pytest
|
|
|
|
from app.broadcast_areas.models import CustomBroadcastAreas
|
|
from app.models.broadcast_message import BroadcastMessage
|
|
from tests import broadcast_message_json
|
|
|
|
|
|
@pytest.mark.parametrize('areas, expected_area_ids', [
|
|
({'simple_polygons': []}, []),
|
|
({'ids': ['123'], 'simple_polygons': []}, ['123'])
|
|
])
|
|
def test_area_ids(
|
|
areas,
|
|
expected_area_ids,
|
|
):
|
|
broadcast_message = BroadcastMessage(broadcast_message_json(
|
|
areas=areas
|
|
))
|
|
|
|
assert broadcast_message.area_ids == expected_area_ids
|
|
|
|
|
|
def test_simple_polygons():
|
|
broadcast_message = BroadcastMessage(broadcast_message_json(
|
|
area_ids=[
|
|
# Hackney Central
|
|
'wd20-E05009372',
|
|
# Hackney Wick
|
|
'wd20-E05009374',
|
|
],
|
|
))
|
|
|
|
assert [
|
|
[
|
|
len(polygon)
|
|
for polygon in broadcast_message.polygons.as_coordinate_pairs_lat_long
|
|
],
|
|
[
|
|
len(polygon)
|
|
for polygon in broadcast_message.simple_polygons.as_coordinate_pairs_lat_long
|
|
],
|
|
] == [
|
|
# One polygon for each area
|
|
[27, 31],
|
|
# Because the areas are close to each other, the simplification
|
|
# and unioning process results in a single polygon with fewer
|
|
# total coordinates
|
|
[54],
|
|
]
|
|
|
|
|
|
def test_content_comes_from_attribute_not_template():
|
|
broadcast_message = BroadcastMessage(broadcast_message_json())
|
|
assert broadcast_message.content == 'This is a test'
|
|
|
|
|
|
@pytest.mark.parametrize(('areas', 'expected_length'), [
|
|
({'ids': []}, 0),
|
|
({'ids': ['wd20-E05009372']}, 1),
|
|
({'no data': 'just created'}, 0),
|
|
({'names': ['somewhere'], 'simple_polygons': [[[3.5, 1.5]]]}, 1)
|
|
])
|
|
def test_areas(
|
|
areas,
|
|
expected_length
|
|
):
|
|
broadcast_message = BroadcastMessage(broadcast_message_json(
|
|
areas=areas
|
|
))
|
|
|
|
assert len(list(broadcast_message.areas)) == expected_length
|
|
|
|
|
|
def test_areas_treats_missing_ids_as_custom_broadcast(notify_admin):
|
|
broadcast_message = BroadcastMessage(broadcast_message_json(
|
|
areas={
|
|
'ids': [
|
|
'wd20-E05009372',
|
|
'something else',
|
|
],
|
|
# although the IDs may no longer be usable, we can
|
|
# expect the broadcast to have names and polygons,
|
|
# which is enough to show the user something
|
|
'names': [
|
|
'wd20 name',
|
|
'something else name'
|
|
],
|
|
'simple_polygons': [[[1, 2]]]
|
|
}
|
|
))
|
|
|
|
assert len(list(broadcast_message.areas)) == 2
|
|
assert type(broadcast_message.areas) == CustomBroadcastAreas
|