mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-02-05 19:03:30 -05:00
939954cd64
We used to do this by redirecting on the choose service page. However when we
lost the dropdown and this page also became the page for adding a new service
(in 3617f2e936) the redirect was removed.
This commit re-adds the redirect on the two factor page, so that it only happens
on first login.
So the flows are:
**Multiple services**
```
`Sign in` → `Enter two factor code` → `Choose service` → `Service dashboard`
```
**One service**
```
`Sign in` → `Enter two factor code` → `Service dashboard`
```
**No services (you’ve deleted all your services)**
`Sign in` → `Enter two factor code` → `Choose service` → `Add new service`
95 lines
4.8 KiB
Python
95 lines
4.8 KiB
Python
from flask import url_for
|
|
|
|
from tests import create_test_user
|
|
|
|
|
|
def test_should_render_two_factor_page(app_,
|
|
api_user_active,
|
|
mock_get_user_by_email):
|
|
with app_.test_request_context():
|
|
with app_.test_client() as client:
|
|
# TODO this lives here until we work out how to
|
|
# reassign the session after it is lost mid register process
|
|
with client.session_transaction() as session:
|
|
session['user_details'] = {
|
|
'id': api_user_active.id,
|
|
'email': api_user_active.email_address}
|
|
response = client.get(url_for('main.two_factor'))
|
|
assert response.status_code == 200
|
|
assert '''We've sent you a text message with a verification code.''' in response.get_data(as_text=True)
|
|
|
|
|
|
def test_should_login_user_and_redirect_to_service_dashboard(app_,
|
|
api_user_active,
|
|
mock_get_user,
|
|
mock_get_user_by_email,
|
|
mock_check_verify_code,
|
|
mock_get_services_with_one_service):
|
|
with app_.test_request_context():
|
|
with app_.test_client() as client:
|
|
with client.session_transaction() as session:
|
|
session['user_details'] = {
|
|
'id': api_user_active.id,
|
|
'email': api_user_active.email_address}
|
|
response = client.post(url_for('main.two_factor'),
|
|
data={'sms_code': '12345'})
|
|
|
|
assert response.status_code == 302
|
|
assert response.location == url_for(
|
|
'main.service_dashboard',
|
|
service_id="596364a0-858e-42c8-9062-a8fe822260eb",
|
|
_external=True
|
|
)
|
|
|
|
|
|
def test_should_login_user_and_redirect_to_choose_services(app_,
|
|
api_user_active,
|
|
mock_get_user,
|
|
mock_get_user_by_email,
|
|
mock_check_verify_code,
|
|
mock_get_services):
|
|
with app_.test_request_context():
|
|
with app_.test_client() as client:
|
|
with client.session_transaction() as session:
|
|
session['user_details'] = {
|
|
'id': api_user_active.id,
|
|
'email': api_user_active.email_address}
|
|
response = client.post(url_for('main.two_factor'),
|
|
data={'sms_code': '12345'})
|
|
|
|
assert response.status_code == 302
|
|
assert response.location == url_for('main.choose_service', _external=True)
|
|
|
|
|
|
def test_should_return_200_with_sms_code_error_when_sms_code_is_wrong(app_,
|
|
api_user_active,
|
|
mock_get_user_by_email,
|
|
mock_check_verify_code_code_not_found):
|
|
with app_.test_request_context():
|
|
with app_.test_client() as client:
|
|
with client.session_transaction() as session:
|
|
session['user_details'] = {
|
|
'id': api_user_active.id,
|
|
'email': api_user_active.email_address}
|
|
response = client.post(url_for('main.two_factor'),
|
|
data={'sms_code': '23456'})
|
|
assert response.status_code == 200
|
|
assert 'Code not found' in response.get_data(as_text=True)
|
|
|
|
|
|
def test_should_login_user_when_multiple_valid_codes_exist(app_,
|
|
api_user_active,
|
|
mock_get_user,
|
|
mock_get_user_by_email,
|
|
mock_check_verify_code,
|
|
mock_get_services_with_one_service):
|
|
with app_.test_request_context():
|
|
with app_.test_client() as client:
|
|
with client.session_transaction() as session:
|
|
session['user_details'] = {
|
|
'id': api_user_active.id,
|
|
'email': api_user_active.email_address}
|
|
response = client.post(url_for('main.two_factor'),
|
|
data={'sms_code': '23456'})
|
|
assert response.status_code == 302
|