Chris Hill-Scott 888821d1b4 Don’t 500 when a CSV is missing rows ...

> When the CSV is missing the header row, we get an error and the user
> will see "Sorry, we are experiencing technical difficulties..."
>
> We should return a better error message for the user.

– https://www.pivotaltracker.com/story/show/140668615

This was caused by an attempt to access the `first_recipient` variable
before it was assigned. It would only be assigned when there was at
least one row in the file.

Fixing this means doing two things:
- defaulting `first_recipient` to be `None` before looking in the file
- adding an error message for when we can’t extract any rows out of the
  file (which is more nuanced than the file just being completely empty)

(There’s a nasty `sort` in the Jinja template because when there are no
rows in the file the order of the required column headers is not
deterministic.)

2017-02-27 14:46:01 +00:00

..

app

Don’t 500 when a CSV is missing rows

2017-02-27 14:46:01 +00:00

non_spreadsheet_files

…

spreadsheet_files

…

__init__.py

TestClient now sets up app.current_session correctly

2017-02-02 15:18:41 +00:00

conftest.py

add tests for gsm handling in save/edit template

2017-02-17 10:39:52 +00:00