mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-06-09 07:51:21 -04:00
c551ce9a42
There are some teams who send jobs on a daily/weekly basis. They have team members who only use Notify for this purpose. So they would probably benefit from basic view, because they don’t need to see the dashboard. This commit: - adds a new item (uploaded files) to the basic view navigation for teams that have sent at least one job - makes the job pages visible to basic view users I think we should do this now, rather than as a later enhancement to basic view. We only have one chance to announce the feature, so teams who do send jobs may otherwise discount it as not useful for them and the opportunity to have them use it is lost.
396 lines
10 KiB
Python
396 lines
10 KiB
Python
import base64
|
||
from functools import partial
|
||
from unittest.mock import mock_open
|
||
|
||
import pytest
|
||
from flask import url_for
|
||
from freezegun import freeze_time
|
||
from notifications_python_client.errors import APIError
|
||
|
||
from tests.conftest import (
|
||
SERVICE_ONE_ID,
|
||
active_caseworking_user,
|
||
active_user_with_permissions,
|
||
mock_get_notification,
|
||
normalize_spaces,
|
||
)
|
||
|
||
|
||
@pytest.mark.parametrize('notification_status, expected_status', [
|
||
('created', 'Sending'),
|
||
('sending', 'Sending'),
|
||
('delivered', 'Delivered'),
|
||
('failed', 'Failed'),
|
||
('temporary-failure', 'Phone not accepting messages right now'),
|
||
('permanent-failure', 'Phone number doesn’t exist'),
|
||
('technical-failure', 'Technical failure'),
|
||
])
|
||
@pytest.mark.parametrize('user', [
|
||
active_user_with_permissions,
|
||
active_caseworking_user,
|
||
])
|
||
@freeze_time("2016-01-01 11:09:00.061258")
|
||
def test_notification_status_page_shows_details(
|
||
client_request,
|
||
mocker,
|
||
mock_has_no_jobs,
|
||
service_one,
|
||
fake_uuid,
|
||
user,
|
||
notification_status,
|
||
expected_status,
|
||
):
|
||
|
||
mocker.patch('app.user_api_client.get_user', return_value=user(fake_uuid))
|
||
|
||
_mock_get_notification = mock_get_notification(
|
||
mocker,
|
||
fake_uuid,
|
||
notification_status=notification_status
|
||
)
|
||
|
||
page = client_request.get(
|
||
'main.view_notification',
|
||
service_id=service_one['id'],
|
||
notification_id=fake_uuid
|
||
)
|
||
|
||
assert normalize_spaces(page.select('.sms-message-recipient')[0].text) == (
|
||
'To: 07123456789'
|
||
)
|
||
assert normalize_spaces(page.select('.sms-message-wrapper')[0].text) == (
|
||
'service one: hello Jo'
|
||
)
|
||
assert normalize_spaces(page.select('.ajax-block-container p')[0].text) == (
|
||
expected_status
|
||
)
|
||
|
||
_mock_get_notification.assert_called_with(
|
||
service_one['id'],
|
||
fake_uuid
|
||
)
|
||
|
||
|
||
@pytest.mark.parametrize('template_redaction_setting, expected_content', [
|
||
(False, 'service one: hello Jo'),
|
||
(True, 'service one: hello hidden'),
|
||
])
|
||
@freeze_time("2016-01-01 11:09:00.061258")
|
||
def test_notification_status_page_respects_redaction(
|
||
client_request,
|
||
mocker,
|
||
service_one,
|
||
fake_uuid,
|
||
template_redaction_setting,
|
||
expected_content,
|
||
):
|
||
|
||
_mock_get_notification = mock_get_notification(
|
||
mocker,
|
||
fake_uuid,
|
||
redact_personalisation=template_redaction_setting,
|
||
)
|
||
|
||
page = client_request.get(
|
||
'main.view_notification',
|
||
service_id=service_one['id'],
|
||
notification_id=fake_uuid
|
||
)
|
||
|
||
assert normalize_spaces(page.select('.sms-message-wrapper')[0].text) == expected_content
|
||
|
||
_mock_get_notification.assert_called_with(
|
||
service_one['id'],
|
||
fake_uuid,
|
||
)
|
||
|
||
|
||
@freeze_time("2012-01-01 01:01")
|
||
def test_notification_page_doesnt_link_to_template_in_tour(
|
||
client_request,
|
||
fake_uuid,
|
||
mock_get_notification,
|
||
):
|
||
|
||
page = client_request.get(
|
||
'main.view_notification',
|
||
service_id=SERVICE_ONE_ID,
|
||
notification_id=fake_uuid,
|
||
help=3,
|
||
)
|
||
|
||
assert normalize_spaces(page.select('main p:nth-of-type(1)')[0].text) == (
|
||
'sample template sent by Test User on 1 January at 1:01am'
|
||
)
|
||
assert len(page.select('main p:nth-of-type(1) a')) == 0
|
||
|
||
|
||
@freeze_time("2016-01-01 01:01")
|
||
def test_notification_page_shows_page_for_letter_notification(
|
||
client_request,
|
||
mocker,
|
||
fake_uuid,
|
||
):
|
||
|
||
count_of_pages = 3
|
||
|
||
mock_get_notification(mocker, fake_uuid, template_type='letter')
|
||
mocker.patch(
|
||
'app.main.views.notifications.get_page_count_for_letter',
|
||
return_value=count_of_pages
|
||
)
|
||
|
||
page = client_request.get(
|
||
'main.view_notification',
|
||
service_id=SERVICE_ONE_ID,
|
||
notification_id=fake_uuid,
|
||
)
|
||
|
||
assert normalize_spaces(page.select('main p:nth-of-type(1)')[0].text) == (
|
||
'sample template sent by Test User on 1 January at 1:01am'
|
||
)
|
||
assert normalize_spaces(page.select('main p:nth-of-type(2)')[0].text) == (
|
||
'Estimated delivery date: 6 January'
|
||
)
|
||
assert page.select('p.notification-status') == []
|
||
|
||
letter_images = page.select('main img')
|
||
|
||
assert len(letter_images) == count_of_pages
|
||
|
||
for index in range(1, count_of_pages + 1):
|
||
assert page.select('img')[index]['src'].endswith(
|
||
'.png?page={}'.format(index)
|
||
)
|
||
|
||
|
||
@pytest.mark.parametrize('filetype', [
|
||
'pdf', 'png'
|
||
])
|
||
def test_should_show_image_of_letter_notification(
|
||
logged_in_client,
|
||
fake_uuid,
|
||
mocker,
|
||
filetype,
|
||
):
|
||
|
||
mock_get_notification(mocker, fake_uuid, template_type='letter')
|
||
|
||
mocker.patch(
|
||
'app.main.views.notifications.notification_api_client.get_notification_letter_preview',
|
||
return_value={
|
||
'content': base64.b64encode(b'foo').decode('utf-8')
|
||
}
|
||
)
|
||
|
||
response = logged_in_client.get(url_for(
|
||
'main.view_letter_notification_as_preview',
|
||
service_id=SERVICE_ONE_ID,
|
||
notification_id=fake_uuid,
|
||
filetype=filetype
|
||
))
|
||
|
||
assert response.status_code == 200
|
||
assert response.get_data(as_text=True) == 'foo'
|
||
|
||
|
||
def test_should_show_preview_error_image_letter_notification_on_preview_error(
|
||
logged_in_client,
|
||
fake_uuid,
|
||
mocker,
|
||
):
|
||
|
||
mock_get_notification(mocker, fake_uuid, template_type='letter')
|
||
|
||
mocker.patch(
|
||
'app.main.views.notifications.notification_api_client.get_notification_letter_preview',
|
||
side_effect=APIError
|
||
)
|
||
|
||
mocker.patch("builtins.open", mock_open(read_data="preview error image"))
|
||
|
||
response = logged_in_client.get(url_for(
|
||
'main.view_letter_notification_as_preview',
|
||
service_id=SERVICE_ONE_ID,
|
||
notification_id=fake_uuid,
|
||
filetype='png'
|
||
))
|
||
|
||
assert response.status_code == 200
|
||
assert response.get_data(as_text=True) == 'preview error image'
|
||
|
||
|
||
def test_should_404_for_unknown_extension(
|
||
client_request,
|
||
fake_uuid,
|
||
):
|
||
client_request.get(
|
||
'main.view_letter_notification_as_preview',
|
||
service_id=SERVICE_ONE_ID,
|
||
notification_id=fake_uuid,
|
||
filetype='docx',
|
||
_expected_status=404,
|
||
)
|
||
|
||
|
||
@pytest.mark.parametrize('service_permissions, template_type, link_expected', [
|
||
([], '', False),
|
||
(['inbound_sms'], 'email', False),
|
||
(['inbound_sms'], 'letter', False),
|
||
(['inbound_sms'], 'sms', True),
|
||
])
|
||
def test_notification_page_has_link_to_send_another_for_sms(
|
||
client_request,
|
||
mocker,
|
||
fake_uuid,
|
||
service_one,
|
||
service_permissions,
|
||
template_type,
|
||
link_expected,
|
||
):
|
||
|
||
service_one['permissions'] = service_permissions
|
||
mock_get_notification(mocker, fake_uuid, template_type=template_type)
|
||
mocker.patch(
|
||
'app.main.views.notifications.get_page_count_for_letter',
|
||
return_value=1
|
||
)
|
||
|
||
page = client_request.get(
|
||
'main.view_notification',
|
||
service_id=SERVICE_ONE_ID,
|
||
notification_id=fake_uuid,
|
||
)
|
||
|
||
last_paragraph = page.select('main p')[-1]
|
||
conversation_link = url_for(
|
||
'.conversation',
|
||
service_id=SERVICE_ONE_ID,
|
||
notification_id=fake_uuid,
|
||
_anchor='n{}'.format(fake_uuid),
|
||
)
|
||
|
||
if link_expected:
|
||
assert normalize_spaces(last_paragraph.text) == (
|
||
'See all text messages sent to this phone number'
|
||
)
|
||
assert last_paragraph.select_one('a')['href'] == conversation_link
|
||
else:
|
||
assert conversation_link not in str(page.select_one('main'))
|
||
|
||
|
||
@pytest.mark.parametrize('template_type, expected_link', [
|
||
('email', lambda notification_id: None),
|
||
('sms', lambda notification_id: None),
|
||
('letter', partial(
|
||
url_for,
|
||
'main.view_letter_notification_as_preview',
|
||
service_id=SERVICE_ONE_ID,
|
||
filetype='pdf'
|
||
)),
|
||
])
|
||
def test_notification_page_has_link_to_download_letter(
|
||
client_request,
|
||
mocker,
|
||
fake_uuid,
|
||
service_one,
|
||
template_type,
|
||
expected_link,
|
||
):
|
||
|
||
mock_get_notification(mocker, fake_uuid, template_type=template_type)
|
||
mocker.patch(
|
||
'app.main.views.notifications.get_page_count_for_letter',
|
||
return_value=1
|
||
)
|
||
|
||
page = client_request.get(
|
||
'main.view_notification',
|
||
service_id=SERVICE_ONE_ID,
|
||
notification_id=fake_uuid,
|
||
)
|
||
|
||
try:
|
||
download_link = page.select_one('a[download]')['href']
|
||
except TypeError:
|
||
download_link = None
|
||
|
||
assert download_link == expected_link(notification_id=fake_uuid)
|
||
|
||
|
||
@pytest.mark.parametrize('is_precompiled_letter, has_template_link', [
|
||
(True, False),
|
||
(False, True),
|
||
])
|
||
def test_notification_page_has_expected_template_link_for_letter(
|
||
client_request,
|
||
mocker,
|
||
fake_uuid,
|
||
service_one,
|
||
is_precompiled_letter,
|
||
has_template_link
|
||
):
|
||
|
||
mocker.patch(
|
||
'app.main.views.notifications.view_letter_notification_as_preview',
|
||
return_value=b'foo'
|
||
)
|
||
|
||
mocker.patch(
|
||
'app.main.views.notifications.pdf_page_count',
|
||
return_value=1
|
||
)
|
||
|
||
mock_get_notification(
|
||
mocker, fake_uuid, template_type='letter', is_precompiled_letter=is_precompiled_letter)
|
||
|
||
mocker.patch(
|
||
'app.main.views.notifications.get_page_count_for_letter',
|
||
return_value=1
|
||
)
|
||
|
||
page = client_request.get(
|
||
'main.view_notification',
|
||
service_id=SERVICE_ONE_ID,
|
||
notification_id=fake_uuid,
|
||
)
|
||
|
||
link = page.select_one('main > p:nth-of-type(1) > a')
|
||
|
||
if has_template_link:
|
||
assert link
|
||
else:
|
||
assert link is None
|
||
|
||
|
||
def test_should_show_image_of_precompiled_letter_notification(
|
||
logged_in_client,
|
||
fake_uuid,
|
||
mocker,
|
||
):
|
||
|
||
mock_get_notification(mocker, fake_uuid, template_type='letter', is_precompiled_letter=True)
|
||
|
||
mock_pdf_page_count = mocker.patch(
|
||
'app.main.views.notifications.pdf_page_count',
|
||
return_value=1
|
||
)
|
||
|
||
mocker.patch(
|
||
'app.main.views.notifications.notification_api_client.get_notification_letter_preview',
|
||
return_value={
|
||
'content': base64.b64encode(b'foo').decode('utf-8')
|
||
}
|
||
)
|
||
|
||
response = logged_in_client.get(url_for(
|
||
'main.view_letter_notification_as_preview',
|
||
service_id=SERVICE_ONE_ID,
|
||
notification_id=fake_uuid,
|
||
filetype="png"
|
||
))
|
||
|
||
assert response.status_code == 200
|
||
assert response.get_data(as_text=True) == 'foo'
|
||
assert mock_pdf_page_count.called_once()
|