mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-08-15 07:18:58 -04:00
The GDS Way™[1] recommends using Flake8 to lint Python projects.
This commit takes the Flake8 config from Digital Marketplace API[2] and
removes the bits we don’t need.
It changes the `max_complexity` setting to 14, which is the most complex
code we have in this repo currently (we shouldn’t be writing code _more_
complex than what we already have).
This commit also fixes the errors found by Flake8, which includes 6(!)
tests which were never getting run because they had the same names as
existing tests.
Here is a full list of the errors that were found and fixed:
```
./app/__init__.py:2:1: F401 're' imported but unused
./app/__init__.py:4:1: F401 'json' imported but unused
./app/__init__.py:8:1: F401 'dateutil' imported but unused
./app/__init__.py:11:1: F401 'flask.escape' imported but unused
./app/__init__.py:41:1: F401 'app.proxy_fix' imported but unused
./app/__init__.py:129:5: F821 undefined name 'proxy_fix'
./app/__init__.py:221:19: F821 undefined name 'highlight'
./app/__init__.py:221:35: F821 undefined name 'JavascriptLexer'
./app/__init__.py:221:54: F821 undefined name 'HtmlFormatter'
./app/config.py:2:1: F401 'datetime.timedelta' imported but unused
./app/event_handlers.py:2:1: F401 'flask_login.current_user' imported but unused
./app/utils.py:11:1: F401 'dateutil.parser' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.two_factor' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.notifications' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.add_service' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.forgot_password' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.inbound_number' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.styleguide' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.organisations' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.letter_jobs' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.verify' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.conversation' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.api_keys' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.send' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.dashboard' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.jobs' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.manage_users' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.sign_in' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.sign_out' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.code_not_received' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.invites' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.platform_admin' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.providers' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.service_settings' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.index' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.new_password' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.user_profile' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.feedback' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.choose_service' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.templates' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.register' imported but unused
./app/main/forms.py:12:1: F401 'wtforms.SelectField' imported but unused
./app/main/views/api_keys.py:37:29: E241 multiple spaces after ':'
./app/main/views/feedback.py:3:1: F401 'flask.flash' imported but unused
./app/main/views/feedback.py:122:17: E123 closing bracket does not match indentation of opening bracket's line
./app/main/views/inbound_number.py:1:1: F401 'flask.url_for' imported but unused
./app/main/views/inbound_number.py:1:1: F401 'flask.session' imported but unused
./app/main/views/inbound_number.py:1:1: F401 'flask.redirect' imported but unused
./app/main/views/inbound_number.py:1:1: F401 'flask.request' imported but unused
./app/main/views/inbound_number.py:13:1: F401 'flask.jsonify' imported but unused
./app/main/views/jobs.py:31:1: F401 'app.utils.get_template' imported but unused
./app/main/views/letter_jobs.py:1:1: F401 'datetime' imported but unused
./app/main/views/letter_jobs.py:6:1: F401 'app.format_datetime_24h' imported but unused
./app/main/views/manage_users.py:111:9: E123 closing bracket does not match indentation of opening bracket's line
./app/main/views/notifications.py:121:5: F841 local variable 'status_args' is assigned to but never used
./app/main/views/organisations.py:1:1: F401 'flask.request' imported but unused
./app/main/views/service_settings.py:77:9: E123 closing bracket does not match indentation of opening bracket's line
./app/main/views/service_settings.py:82:9: E123 closing bracket does not match indentation of opening bracket's line
./app/main/views/service_settings.py:420:13: E123 closing bracket does not match indentation of opening bracket's line
./app/main/views/sign_in.py:12:1: F401 'flask_login.confirm_login' imported but unused
./app/main/views/sign_in.py:17:1: F401 'app.service_api_client' imported but unused
./app/main/views/sign_in.py:62:13: E123 closing bracket does not match indentation of opening bracket's line
./app/main/views/templates.py:4:1: F401 'flask.json' imported but unused
./app/main/views/templates.py:17:1: F401 'notifications_utils.formatters.escape_html' imported but unused
./app/main/views/templates.py:23:1: F401 'app.utils.get_help_argument' imported but unused
./app/main/views/templates.py:64:13: E123 closing bracket does not match indentation of opening bracket's line
./app/notify_client/service_api_client.py:6:1: F401 '.notification_api_client' imported but unused
./app/notify_client/user_api_client.py:1:1: F401 'uuid' imported but unused
./app/notify_client/user_api_client.py:3:1: F401 'flask.session' imported but unused
./tests/__init__.py:1:1: F401 'csv' imported but unused
./tests/app/main/test_asset_fingerprinter.py:2:1: F401 'os' imported but unused
./tests/app/main/test_asset_fingerprinter.py:4:1: F401 'unittest.mock' imported but unused
./tests/app/main/test_asset_fingerprinter.py:98:9: F841 local variable 'string_with_unicode_character' is assigned to but never used
./tests/app/main/test_errorhandlers.py:2:1: F401 'flask.url_for' imported but unused
./tests/app/main/test_permissions.py:26:13: F841 local variable 'response' is assigned to but never used
./tests/app/main/test_placeholder_form.py:3:1: F401 'wtforms.Label' imported but unused
./tests/app/main/test_placeholder_form.py:11:10: F841 local variable 'req' is assigned to but never used
./tests/app/main/test_two_factor_form.py:10:67: F841 local variable 'req' is assigned to but never used
./tests/app/main/test_two_factor_form.py:23:65: F841 local variable 'req' is assigned to but never used
./tests/app/main/test_two_factor_form.py:37:48: F841 local variable 'req' is assigned to but never used
./tests/app/main/test_two_factor_form.py:51:67: F841 local variable 'req' is assigned to but never used
./tests/app/main/test_two_factor_form.py:65:67: F841 local variable 'req' is assigned to but never used
./tests/app/main/views/test_accept_invite.py:356:5: F841 local variable 'element' is assigned to but never used
./tests/app/main/views/test_activity.py:11:1: F811 redefinition of unused 'mock_get_notifications' from line 11
./tests/app/main/views/test_activity.py:18:1: F401 'datetime.datetime' imported but unused
./tests/app/main/views/test_activity.py:102:5: F841 local variable 'content' is assigned to but never used
./tests/app/main/views/test_activity.py:104:5: F841 local variable 'notification' is assigned to but never used
./tests/app/main/views/test_activity.py:337:5: F841 local variable '_notifications_mock' is assigned to but never used
./tests/app/main/views/test_activity.py:373:13: E126 continuation line over-indented for hanging indent
./tests/app/main/views/test_activity.py:378:9: E121 continuation line under-indented for hanging indent
./tests/app/main/views/test_activity.py:404:13: E126 continuation line over-indented for hanging indent
./tests/app/main/views/test_activity.py:407:9: E121 continuation line under-indented for hanging indent
./tests/app/main/views/test_api_keys.py:354:5: F841 local variable 'response' is assigned to but never used
./tests/app/main/views/test_conversation.py:5:1: F401 'bs4.BeautifulSoup' imported but unused
./tests/app/main/views/test_conversation.py:198:5: F841 local variable 'mock_get_inbound_sms' is assigned to but never used
./tests/app/main/views/test_dashboard.py:53:5: F841 local variable 'mock_template_stats' is assigned to but never used
./tests/app/main/views/test_dashboard.py:72:5: F841 local variable 'mock_template_stats' is assigned to but never used
./tests/app/main/views/test_jobs.py:2:1: F401 'uuid' imported but unused
./tests/app/main/views/test_jobs.py:3:1: F401 'urllib.parse.urlparse' imported but unused
./tests/app/main/views/test_jobs.py:3:1: F401 'urllib.parse.quote' imported but unused
./tests/app/main/views/test_jobs.py:3:1: F401 'urllib.parse.parse_qs' imported but unused
./tests/app/main/views/test_jobs.py:9:1: F401 'app.main.views.jobs.get_status_filters' imported but unused
./tests/app/main/views/test_jobs.py:10:1: F401 'tests.notification_json' imported but unused
./tests/app/main/views/test_letters.py:6:1: F401 'tests.service_json' imported but unused
./tests/app/main/views/test_notifications.py:5:1: F401 'app.utils.REQUESTED_STATUSES' imported but unused
./tests/app/main/views/test_notifications.py:5:1: F401 'app.utils.DELIVERED_STATUSES' imported but unused
./tests/app/main/views/test_notifications.py:5:1: F401 'app.utils.SENDING_STATUSES' imported but unused
./tests/app/main/views/test_notifications.py:5:1: F401 'app.utils.FAILURE_STATUSES' imported but unused
./tests/app/main/views/test_platform_admin.py:242:13: E126 continuation line over-indented for hanging indent
./tests/app/main/views/test_platform_admin.py:247:13: E126 continuation line over-indented for hanging indent
./tests/app/main/views/test_send.py:3:1: F401 'unittest.mock.Mock' imported but unused
./tests/app/main/views/test_send.py:18:1: F811 redefinition of unused 'mock_get_service' from line 18
./tests/app/main/views/test_send.py:18:1: F401 'tests.conftest.multiple_letter_contact_blocks' imported but unused
./tests/app/main/views/test_send.py:18:1: F401 'tests.conftest.no_sms_senders' imported but unused
./tests/app/main/views/test_send.py:18:1: F401 'tests.conftest.multiple_sms_senders' imported but unused
./tests/app/main/views/test_send.py:18:1: F401 'tests.conftest.no_letter_contact_blocks' imported but unused
./tests/app/main/views/test_send.py:102:5: F841 local variable 'response' is assigned to but never used
./tests/app/main/views/test_send.py:870:5: F841 local variable 'response' is assigned to but never used
./tests/app/main/views/test_send.py:1367:5: F841 local variable 'service_id' is assigned to but never used
./tests/app/main/views/test_send.py:1451:13: E126 continuation line over-indented for hanging indent
./tests/app/main/views/test_send.py:1620:80: E226 missing whitespace around arithmetic operator
./tests/app/main/views/test_send.py:1909:13: E126 continuation line over-indented for hanging indent
./tests/app/main/views/test_send.py:1912:9: E121 continuation line under-indented for hanging indent
./tests/app/main/views/test_service_settings.py:13:1: F811 redefinition of unused 'no_reply_to_email_addresses' from line 13
./tests/app/main/views/test_service_settings.py:13:1: F401 'tests.conftest.single_reply_to_email_address' imported but unused
./tests/app/main/views/test_service_settings.py:28:5: E123 closing bracket does not match indentation of opening bracket's line
./tests/app/main/views/test_service_settings.py:104:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:166:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:186:5: F841 local variable 'mocked_get_fn' is assigned to but never used
./tests/app/main/views/test_service_settings.py:217:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:237:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:257:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:307:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:340:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:466:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:555:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:615:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:719:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:874:5: F841 local variable 'page' is assigned to but never used
./tests/app/main/views/test_service_settings.py:902:5: F841 local variable 'page' is assigned to but never used
./tests/app/main/views/test_service_settings.py:954:5: F841 local variable 'page' is assigned to but never used
./tests/app/main/views/test_service_settings.py:986:5: F841 local variable 'page' is assigned to but never used
./tests/app/main/views/test_service_settings.py:1101:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1121:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1271:1: F811 redefinition of unused 'test_set_letter_contact_block_saves' from line 1189
./tests/app/main/views/test_service_settings.py:1433:5: F841 local variable 'page' is assigned to but never used
./tests/app/main/views/test_service_settings.py:1495:5: F841 local variable 'mocked_get_fn' is assigned to but never used
./tests/app/main/views/test_service_settings.py:1540:5: F841 local variable 'mocked_get_fn' is assigned to but never used
./tests/app/main/views/test_service_settings.py:1570:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1589:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1621:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1641:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1658:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1676:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1697:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1759:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1775:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_templates.py:3:1: F401 'uuid' imported but unused
./tests/app/main/views/test_templates.py:11:1: F401 'tests.conftest.mock_get_user' imported but unused
./tests/app/main/views/test_templates.py:514:1: F811 redefinition of unused 'mock_get_user' from line 11
./tests/app/main/views/test_templates.py:672:1: F811 redefinition of unused 'mock_get_user' from line 11
./tests/app/main/views/test_templates.py:795:1: F811 redefinition of unused 'mock_get_user' from line 11
./tests/app/main/views/test_templates.py:835:1: F811 redefinition of unused 'mock_get_user' from line 11
./tests/app/main/views/test_two_factor.py:67:13: E126 continuation line over-indented for hanging indent
./tests/app/notify_client/test_notification_client.py:79:5: F841 local variable 'mock_post' is assigned to but never used
```
1. https://gds-way.cloudapps.digital/manuals/programming-languages/python/linting.html#how-to-use-flake8
2. d5ab8afef4/.flake8
333 lines
9.7 KiB
Python
333 lines
9.7 KiB
Python
import json
|
||
|
||
import pytest
|
||
from flask import url_for
|
||
from bs4 import BeautifulSoup
|
||
|
||
from app.main.views.jobs import get_time_left
|
||
from tests.conftest import SERVICE_ONE_ID, normalize_spaces, mock_get_notifications
|
||
from freezegun import freeze_time
|
||
|
||
|
||
def test_get_jobs_should_return_list_of_all_real_jobs(
|
||
logged_in_client,
|
||
service_one,
|
||
active_user_with_permissions,
|
||
mock_get_jobs,
|
||
mocker,
|
||
):
|
||
response = logged_in_client.get(url_for('main.view_jobs', service_id=service_one['id']))
|
||
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
assert page.h1.string == 'Uploaded files'
|
||
jobs = [x.text for x in page.tbody.find_all('a', {'class': 'file-list-filename'})]
|
||
assert len(jobs) == 4
|
||
|
||
|
||
def test_get_jobs_shows_page_links(
|
||
logged_in_client,
|
||
service_one,
|
||
active_user_with_permissions,
|
||
mock_get_jobs,
|
||
mocker,
|
||
):
|
||
response = logged_in_client.get(url_for('main.view_jobs', service_id=service_one['id']))
|
||
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
assert 'Next page' in page.find('li', {'class': 'next-page'}).text
|
||
assert 'Previous page' in page.find('li', {'class': 'previous-page'}).text
|
||
|
||
|
||
@pytest.mark.parametrize(
|
||
"status_argument, expected_api_call", [
|
||
(
|
||
'',
|
||
[
|
||
'created', 'pending', 'sending',
|
||
'delivered', 'sent',
|
||
'failed', 'temporary-failure', 'permanent-failure', 'technical-failure',
|
||
]
|
||
),
|
||
(
|
||
'sending',
|
||
['sending', 'created', 'pending']
|
||
),
|
||
(
|
||
'delivered',
|
||
['delivered', 'sent']
|
||
),
|
||
(
|
||
'failed',
|
||
['failed', 'temporary-failure', 'permanent-failure', 'technical-failure']
|
||
)
|
||
]
|
||
)
|
||
@freeze_time("2016-01-01 11:09:00.061258")
|
||
def test_should_show_page_for_one_job(
|
||
logged_in_client,
|
||
service_one,
|
||
active_user_with_permissions,
|
||
mock_get_service_template,
|
||
mock_get_job,
|
||
mocker,
|
||
mock_get_notifications,
|
||
fake_uuid,
|
||
status_argument,
|
||
expected_api_call,
|
||
):
|
||
|
||
response = logged_in_client.get(url_for(
|
||
'main.view_job',
|
||
service_id=service_one['id'],
|
||
job_id=fake_uuid,
|
||
status=status_argument
|
||
))
|
||
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
assert page.h1.text.strip() == 'thisisatest.csv'
|
||
assert ' '.join(page.find('tbody').find('tr').text.split()) == (
|
||
'07123456789 template content Delivered 1 January at 11:10am'
|
||
)
|
||
assert page.find('div', {'data-key': 'notifications'})['data-resource'] == url_for(
|
||
'main.view_job_updates',
|
||
service_id=service_one['id'],
|
||
job_id=fake_uuid,
|
||
status=status_argument,
|
||
)
|
||
csv_link = page.find('a', {'download': 'download'})
|
||
assert csv_link['href'] == url_for(
|
||
'main.view_job_csv',
|
||
service_id=service_one['id'],
|
||
job_id=fake_uuid,
|
||
status=status_argument
|
||
)
|
||
assert csv_link.text == 'Download this report'
|
||
assert page.find('span', {'id': 'time-left'}).text == 'Data available for 7 days'
|
||
mock_get_notifications.assert_called_with(
|
||
service_one['id'],
|
||
fake_uuid,
|
||
status=expected_api_call
|
||
)
|
||
|
||
|
||
def test_get_jobs_should_tell_user_if_more_than_one_page(
|
||
logged_in_client,
|
||
fake_uuid,
|
||
service_one,
|
||
mock_get_job,
|
||
mock_get_service_template,
|
||
mock_get_notifications_with_previous_next,
|
||
):
|
||
response = logged_in_client.get(url_for(
|
||
'main.view_job',
|
||
service_id=service_one['id'],
|
||
job_id=fake_uuid,
|
||
status=''
|
||
))
|
||
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
assert page.find('p', {'class': 'table-show-more-link'}).text.strip() == 'Only showing the first 50 rows'
|
||
|
||
|
||
def test_should_show_job_in_progress(
|
||
logged_in_client,
|
||
service_one,
|
||
active_user_with_permissions,
|
||
mock_get_service_template,
|
||
mock_get_job_in_progress,
|
||
mocker,
|
||
mock_get_notifications,
|
||
fake_uuid,
|
||
):
|
||
|
||
response = logged_in_client.get(url_for(
|
||
'main.view_job',
|
||
service_id=service_one['id'],
|
||
job_id=fake_uuid
|
||
))
|
||
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
assert page.find('p', {'class': 'hint'}).text.strip() == 'Report is 50% complete…'
|
||
|
||
|
||
@freeze_time("2016-01-01 11:09:00.061258")
|
||
def test_should_show_letter_job(
|
||
client_request,
|
||
mock_get_service_letter_template,
|
||
mock_get_job,
|
||
fake_uuid,
|
||
active_user_with_permissions,
|
||
mocker,
|
||
):
|
||
|
||
get_notifications = mock_get_notifications(mocker, active_user_with_permissions, diff_template_type='letter')
|
||
|
||
page = client_request.get(
|
||
'main.view_job',
|
||
service_id=SERVICE_ONE_ID,
|
||
job_id=fake_uuid,
|
||
)
|
||
assert normalize_spaces(page.h1.text) == 'thisisatest.csv'
|
||
assert normalize_spaces(page.select('p.bottom-gutter')[0].text) == (
|
||
'Sent by Test User on 1 January at 11:09am'
|
||
)
|
||
assert page.select('.banner-default-with-tick') == []
|
||
assert normalize_spaces(page.select('tbody tr')[0].text) == (
|
||
'1 Example Street template content 1 January at 11:09am'
|
||
)
|
||
assert normalize_spaces(page.select('.keyline-block')[0].text) == (
|
||
'1 Letter'
|
||
)
|
||
assert normalize_spaces(page.select('.keyline-block')[1].text) == (
|
||
'6 January Estimated delivery date'
|
||
)
|
||
assert page.select('[download=download]') == []
|
||
assert page.select('.hint') == []
|
||
|
||
get_notifications.assert_called_with(
|
||
SERVICE_ONE_ID,
|
||
fake_uuid,
|
||
status=[
|
||
'created',
|
||
'pending',
|
||
'sending',
|
||
'delivered',
|
||
'sent',
|
||
'failed',
|
||
'temporary-failure',
|
||
'permanent-failure',
|
||
'technical-failure',
|
||
],
|
||
)
|
||
|
||
|
||
@freeze_time("2016-01-01 11:09:00.061258")
|
||
def test_should_show_letter_job_with_banner_after_sending(
|
||
client_request,
|
||
mock_get_service_letter_template,
|
||
mock_get_job,
|
||
mock_get_notifications,
|
||
fake_uuid,
|
||
):
|
||
|
||
page = client_request.get(
|
||
'main.view_job',
|
||
service_id=SERVICE_ONE_ID,
|
||
job_id=fake_uuid,
|
||
just_sent='yes',
|
||
)
|
||
|
||
assert page.select('p.bottom-gutter') == []
|
||
assert normalize_spaces(page.select('.banner-default-with-tick')[0].text) == (
|
||
'We’ve started printing your letters'
|
||
)
|
||
|
||
|
||
@freeze_time("2016-01-01T00:00:00.061258")
|
||
def test_should_show_scheduled_job(
|
||
logged_in_client,
|
||
active_user_with_permissions,
|
||
mock_get_service_template,
|
||
mock_get_scheduled_job,
|
||
mocker,
|
||
mock_get_notifications,
|
||
fake_uuid,
|
||
):
|
||
response = logged_in_client.get(url_for(
|
||
'main.view_job',
|
||
service_id=SERVICE_ONE_ID,
|
||
job_id=fake_uuid
|
||
))
|
||
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
assert normalize_spaces(page.select('main p')[1].text) == (
|
||
'Sending Two week reminder today at midnight'
|
||
)
|
||
assert page.select('main p a')[0]['href'] == url_for(
|
||
'main.view_template_version',
|
||
service_id=SERVICE_ONE_ID,
|
||
template_id='5d729fbd-239c-44ab-b498-75a985f3198f',
|
||
version=1,
|
||
)
|
||
assert page.find('input', {'type': 'submit', 'value': 'Cancel sending'})
|
||
|
||
|
||
def test_should_cancel_job(
|
||
logged_in_client,
|
||
service_one,
|
||
fake_uuid,
|
||
mocker,
|
||
):
|
||
mock_cancel = mocker.patch('app.main.jobs.job_api_client.cancel_job')
|
||
response = logged_in_client.post(url_for(
|
||
'main.cancel_job',
|
||
service_id=service_one['id'],
|
||
job_id=fake_uuid
|
||
))
|
||
|
||
mock_cancel.assert_called_once_with(service_one['id'], fake_uuid)
|
||
assert response.status_code == 302
|
||
assert response.location == url_for('main.service_dashboard', service_id=service_one['id'], _external=True)
|
||
|
||
|
||
def test_should_not_show_cancelled_job(
|
||
logged_in_client,
|
||
service_one,
|
||
active_user_with_permissions,
|
||
mock_get_cancelled_job,
|
||
mocker,
|
||
fake_uuid,
|
||
):
|
||
response = logged_in_client.get(url_for(
|
||
'main.view_job',
|
||
service_id=service_one['id'],
|
||
job_id=fake_uuid
|
||
))
|
||
|
||
assert response.status_code == 404
|
||
|
||
|
||
@freeze_time("2016-01-01 00:00:00.000001")
|
||
def test_should_show_updates_for_one_job_as_json(
|
||
logged_in_client,
|
||
service_one,
|
||
active_user_with_permissions,
|
||
mock_get_notifications,
|
||
mock_get_service_template,
|
||
mock_get_job,
|
||
mocker,
|
||
fake_uuid,
|
||
):
|
||
response = logged_in_client.get(url_for('main.view_job_updates', service_id=service_one['id'], job_id=fake_uuid))
|
||
|
||
assert response.status_code == 200
|
||
content = json.loads(response.get_data(as_text=True))
|
||
assert 'sending' in content['counts']
|
||
assert 'delivered' in content['counts']
|
||
assert 'failed' in content['counts']
|
||
assert 'Recipient' in content['notifications']
|
||
assert '07123456789' in content['notifications']
|
||
assert 'Status' in content['notifications']
|
||
assert 'Delivered' in content['notifications']
|
||
assert '12:01am' in content['notifications']
|
||
assert 'Sent by Test User on 1 January at midnight' in content['status']
|
||
|
||
|
||
@pytest.mark.parametrize(
|
||
"job_created_at, expected_message", [
|
||
("2016-01-10 11:09:00.000000+00:00", "Data available for 7 days"),
|
||
("2016-01-04 11:09:00.000000+00:00", "Data available for 1 day"),
|
||
("2016-01-03 11:09:00.000000+00:00", "Data available for 11 hours"),
|
||
("2016-01-02 23:59:59.000000+00:00", "Data no longer available")
|
||
]
|
||
)
|
||
@freeze_time("2016-01-10 12:00:00.000000")
|
||
def test_time_left(job_created_at, expected_message):
|
||
assert get_time_left(job_created_at) == expected_message
|