mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-06-05 14:00:51 -04:00
7e707db4b2
We have a `client_request` fixture which does a bunch of useful stuff
like:
- checking the status code of the response
- returning a `BeautifulSoup` object
Lots of our tests still use an older fixture called `client`. This is
not as good because it:
- returns a raw `Response` object
- doesn’t do the additional checks
- means our tests contain a lot of repetetive boilerplate like `page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')`
This commit converts all the tests which had a `client.get(…)` or
`client.post(…)` statement to use their equivalents on `client_request`
instead.
Subsequent commits will remove uses of `client` in other tests, but
doing it this way means the work can be broken up into more manageable
chunks.
87 lines
3.5 KiB
Python
87 lines
3.5 KiB
Python
import re
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"query_args, result", [
|
|
({}, True),
|
|
({'govuk_banner': 'false'}, 'false')
|
|
]
|
|
)
|
|
def test_renders(client_request, mocker, query_args, result):
|
|
|
|
mocker.patch('app.main.views.index.HTMLEmailTemplate.__str__', return_value='rendered')
|
|
|
|
response = client_request.get_response('main.email_template', **query_args)
|
|
|
|
assert response.get_data(as_text=True) == 'rendered'
|
|
|
|
|
|
def test_displays_govuk_branding_by_default(client_request):
|
|
|
|
page = client_request.get('main.email_template', _test_page_title=False)
|
|
|
|
assert page.find("a", attrs={"href": "https://www.gov.uk"})
|
|
|
|
|
|
def test_displays_govuk_branding(client_request, mock_get_email_branding_with_govuk_brand_type):
|
|
|
|
page = client_request.get('main.email_template', branding_style="1", _test_page_title=False)
|
|
|
|
assert page.find("a", attrs={"href": "https://www.gov.uk"})
|
|
|
|
|
|
def test_displays_both_branding(client_request, mock_get_email_branding_with_both_brand_type):
|
|
|
|
page = client_request.get('main.email_template', branding_style="1", _test_page_title=False)
|
|
|
|
mock_get_email_branding_with_both_brand_type.assert_called_once_with('1')
|
|
|
|
assert page.find("a", attrs={"href": "https://www.gov.uk"})
|
|
assert page.find("img", attrs={"src": re.compile("example.png$")})
|
|
assert page.select("body > table:nth-of-type(3) table > tr:nth-of-type(1) > td:nth-of-type(2)")[0]\
|
|
.get_text().strip() == 'Organisation text' # brand text is set
|
|
|
|
|
|
def test_displays_org_branding(client_request, mock_get_email_branding):
|
|
# mock_get_email_branding has 'brand_type' of 'org'
|
|
page = client_request.get('main.email_template', branding_style="1", _test_page_title=False)
|
|
|
|
mock_get_email_branding.assert_called_once_with('1')
|
|
|
|
assert not page.find("a", attrs={"href": "https://www.gov.uk"})
|
|
assert page.find("img", attrs={"src": re.compile("example.png")})
|
|
assert not page.select("body > table > tr > td[bgcolor='#f00']") # banner colour is not set
|
|
assert page.select("body > table:nth-of-type(1) > tr:nth-of-type(1) > td:nth-of-type(2)")[0]\
|
|
.get_text().strip() == 'Organisation text' # brand text is set
|
|
|
|
|
|
def test_displays_org_branding_with_banner(
|
|
client_request, mock_get_email_branding_with_org_banner_brand_type
|
|
):
|
|
page = client_request.get('main.email_template', branding_style="1", _test_page_title=False)
|
|
|
|
mock_get_email_branding_with_org_banner_brand_type.assert_called_once_with('1')
|
|
|
|
assert not page.find("a", attrs={"href": "https://www.gov.uk"})
|
|
assert page.find("img", attrs={"src": re.compile("example.png")})
|
|
assert page.select("body > table > tr > td[bgcolor='#f00']") # banner colour is set
|
|
assert page.select("body > table table > tr > td > span")[0]\
|
|
.get_text().strip() == 'Organisation text' # brand text is set
|
|
|
|
|
|
def test_displays_org_branding_with_banner_without_brand_text(
|
|
client_request, mock_get_email_branding_without_brand_text
|
|
):
|
|
|
|
# mock_get_email_branding_without_brand_text has 'brand_type' of 'org_banner'
|
|
page = client_request.get('main.email_template', branding_style="1", _test_page_title=False)
|
|
|
|
mock_get_email_branding_without_brand_text.assert_called_once_with('1')
|
|
|
|
assert not page.find("a", attrs={"href": "https://www.gov.uk"})
|
|
assert page.find("img", attrs={"src": re.compile("example.png")})
|
|
assert page.select("body > table > tr > td[bgcolor='#f00']") # banner colour is set
|
|
assert not page.select("body > table table > tr > td > span") == 0 # brand text is not set
|