mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-06-19 12:46:20 -04:00
The GDS Way™[1] recommends using Flake8 to lint Python projects.
This commit takes the Flake8 config from Digital Marketplace API[2] and
removes the bits we don’t need.
It changes the `max_complexity` setting to 14, which is the most complex
code we have in this repo currently (we shouldn’t be writing code _more_
complex than what we already have).
This commit also fixes the errors found by Flake8, which includes 6(!)
tests which were never getting run because they had the same names as
existing tests.
Here is a full list of the errors that were found and fixed:
```
./app/__init__.py:2:1: F401 're' imported but unused
./app/__init__.py:4:1: F401 'json' imported but unused
./app/__init__.py:8:1: F401 'dateutil' imported but unused
./app/__init__.py:11:1: F401 'flask.escape' imported but unused
./app/__init__.py:41:1: F401 'app.proxy_fix' imported but unused
./app/__init__.py:129:5: F821 undefined name 'proxy_fix'
./app/__init__.py:221:19: F821 undefined name 'highlight'
./app/__init__.py:221:35: F821 undefined name 'JavascriptLexer'
./app/__init__.py:221:54: F821 undefined name 'HtmlFormatter'
./app/config.py:2:1: F401 'datetime.timedelta' imported but unused
./app/event_handlers.py:2:1: F401 'flask_login.current_user' imported but unused
./app/utils.py:11:1: F401 'dateutil.parser' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.two_factor' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.notifications' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.add_service' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.forgot_password' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.inbound_number' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.styleguide' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.organisations' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.letter_jobs' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.verify' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.conversation' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.api_keys' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.send' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.dashboard' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.jobs' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.manage_users' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.sign_in' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.sign_out' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.code_not_received' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.invites' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.platform_admin' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.providers' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.service_settings' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.index' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.new_password' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.user_profile' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.feedback' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.choose_service' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.templates' imported but unused
./app/main/__init__.py:5:1: F401 'app.main.views.register' imported but unused
./app/main/forms.py:12:1: F401 'wtforms.SelectField' imported but unused
./app/main/views/api_keys.py:37:29: E241 multiple spaces after ':'
./app/main/views/feedback.py:3:1: F401 'flask.flash' imported but unused
./app/main/views/feedback.py:122:17: E123 closing bracket does not match indentation of opening bracket's line
./app/main/views/inbound_number.py:1:1: F401 'flask.url_for' imported but unused
./app/main/views/inbound_number.py:1:1: F401 'flask.session' imported but unused
./app/main/views/inbound_number.py:1:1: F401 'flask.redirect' imported but unused
./app/main/views/inbound_number.py:1:1: F401 'flask.request' imported but unused
./app/main/views/inbound_number.py:13:1: F401 'flask.jsonify' imported but unused
./app/main/views/jobs.py:31:1: F401 'app.utils.get_template' imported but unused
./app/main/views/letter_jobs.py:1:1: F401 'datetime' imported but unused
./app/main/views/letter_jobs.py:6:1: F401 'app.format_datetime_24h' imported but unused
./app/main/views/manage_users.py:111:9: E123 closing bracket does not match indentation of opening bracket's line
./app/main/views/notifications.py:121:5: F841 local variable 'status_args' is assigned to but never used
./app/main/views/organisations.py:1:1: F401 'flask.request' imported but unused
./app/main/views/service_settings.py:77:9: E123 closing bracket does not match indentation of opening bracket's line
./app/main/views/service_settings.py:82:9: E123 closing bracket does not match indentation of opening bracket's line
./app/main/views/service_settings.py:420:13: E123 closing bracket does not match indentation of opening bracket's line
./app/main/views/sign_in.py:12:1: F401 'flask_login.confirm_login' imported but unused
./app/main/views/sign_in.py:17:1: F401 'app.service_api_client' imported but unused
./app/main/views/sign_in.py:62:13: E123 closing bracket does not match indentation of opening bracket's line
./app/main/views/templates.py:4:1: F401 'flask.json' imported but unused
./app/main/views/templates.py:17:1: F401 'notifications_utils.formatters.escape_html' imported but unused
./app/main/views/templates.py:23:1: F401 'app.utils.get_help_argument' imported but unused
./app/main/views/templates.py:64:13: E123 closing bracket does not match indentation of opening bracket's line
./app/notify_client/service_api_client.py:6:1: F401 '.notification_api_client' imported but unused
./app/notify_client/user_api_client.py:1:1: F401 'uuid' imported but unused
./app/notify_client/user_api_client.py:3:1: F401 'flask.session' imported but unused
./tests/__init__.py:1:1: F401 'csv' imported but unused
./tests/app/main/test_asset_fingerprinter.py:2:1: F401 'os' imported but unused
./tests/app/main/test_asset_fingerprinter.py:4:1: F401 'unittest.mock' imported but unused
./tests/app/main/test_asset_fingerprinter.py:98:9: F841 local variable 'string_with_unicode_character' is assigned to but never used
./tests/app/main/test_errorhandlers.py:2:1: F401 'flask.url_for' imported but unused
./tests/app/main/test_permissions.py:26:13: F841 local variable 'response' is assigned to but never used
./tests/app/main/test_placeholder_form.py:3:1: F401 'wtforms.Label' imported but unused
./tests/app/main/test_placeholder_form.py:11:10: F841 local variable 'req' is assigned to but never used
./tests/app/main/test_two_factor_form.py:10:67: F841 local variable 'req' is assigned to but never used
./tests/app/main/test_two_factor_form.py:23:65: F841 local variable 'req' is assigned to but never used
./tests/app/main/test_two_factor_form.py:37:48: F841 local variable 'req' is assigned to but never used
./tests/app/main/test_two_factor_form.py:51:67: F841 local variable 'req' is assigned to but never used
./tests/app/main/test_two_factor_form.py:65:67: F841 local variable 'req' is assigned to but never used
./tests/app/main/views/test_accept_invite.py:356:5: F841 local variable 'element' is assigned to but never used
./tests/app/main/views/test_activity.py:11:1: F811 redefinition of unused 'mock_get_notifications' from line 11
./tests/app/main/views/test_activity.py:18:1: F401 'datetime.datetime' imported but unused
./tests/app/main/views/test_activity.py:102:5: F841 local variable 'content' is assigned to but never used
./tests/app/main/views/test_activity.py:104:5: F841 local variable 'notification' is assigned to but never used
./tests/app/main/views/test_activity.py:337:5: F841 local variable '_notifications_mock' is assigned to but never used
./tests/app/main/views/test_activity.py:373:13: E126 continuation line over-indented for hanging indent
./tests/app/main/views/test_activity.py:378:9: E121 continuation line under-indented for hanging indent
./tests/app/main/views/test_activity.py:404:13: E126 continuation line over-indented for hanging indent
./tests/app/main/views/test_activity.py:407:9: E121 continuation line under-indented for hanging indent
./tests/app/main/views/test_api_keys.py:354:5: F841 local variable 'response' is assigned to but never used
./tests/app/main/views/test_conversation.py:5:1: F401 'bs4.BeautifulSoup' imported but unused
./tests/app/main/views/test_conversation.py:198:5: F841 local variable 'mock_get_inbound_sms' is assigned to but never used
./tests/app/main/views/test_dashboard.py:53:5: F841 local variable 'mock_template_stats' is assigned to but never used
./tests/app/main/views/test_dashboard.py:72:5: F841 local variable 'mock_template_stats' is assigned to but never used
./tests/app/main/views/test_jobs.py:2:1: F401 'uuid' imported but unused
./tests/app/main/views/test_jobs.py:3:1: F401 'urllib.parse.urlparse' imported but unused
./tests/app/main/views/test_jobs.py:3:1: F401 'urllib.parse.quote' imported but unused
./tests/app/main/views/test_jobs.py:3:1: F401 'urllib.parse.parse_qs' imported but unused
./tests/app/main/views/test_jobs.py:9:1: F401 'app.main.views.jobs.get_status_filters' imported but unused
./tests/app/main/views/test_jobs.py:10:1: F401 'tests.notification_json' imported but unused
./tests/app/main/views/test_letters.py:6:1: F401 'tests.service_json' imported but unused
./tests/app/main/views/test_notifications.py:5:1: F401 'app.utils.REQUESTED_STATUSES' imported but unused
./tests/app/main/views/test_notifications.py:5:1: F401 'app.utils.DELIVERED_STATUSES' imported but unused
./tests/app/main/views/test_notifications.py:5:1: F401 'app.utils.SENDING_STATUSES' imported but unused
./tests/app/main/views/test_notifications.py:5:1: F401 'app.utils.FAILURE_STATUSES' imported but unused
./tests/app/main/views/test_platform_admin.py:242:13: E126 continuation line over-indented for hanging indent
./tests/app/main/views/test_platform_admin.py:247:13: E126 continuation line over-indented for hanging indent
./tests/app/main/views/test_send.py:3:1: F401 'unittest.mock.Mock' imported but unused
./tests/app/main/views/test_send.py:18:1: F811 redefinition of unused 'mock_get_service' from line 18
./tests/app/main/views/test_send.py:18:1: F401 'tests.conftest.multiple_letter_contact_blocks' imported but unused
./tests/app/main/views/test_send.py:18:1: F401 'tests.conftest.no_sms_senders' imported but unused
./tests/app/main/views/test_send.py:18:1: F401 'tests.conftest.multiple_sms_senders' imported but unused
./tests/app/main/views/test_send.py:18:1: F401 'tests.conftest.no_letter_contact_blocks' imported but unused
./tests/app/main/views/test_send.py:102:5: F841 local variable 'response' is assigned to but never used
./tests/app/main/views/test_send.py:870:5: F841 local variable 'response' is assigned to but never used
./tests/app/main/views/test_send.py:1367:5: F841 local variable 'service_id' is assigned to but never used
./tests/app/main/views/test_send.py:1451:13: E126 continuation line over-indented for hanging indent
./tests/app/main/views/test_send.py:1620:80: E226 missing whitespace around arithmetic operator
./tests/app/main/views/test_send.py:1909:13: E126 continuation line over-indented for hanging indent
./tests/app/main/views/test_send.py:1912:9: E121 continuation line under-indented for hanging indent
./tests/app/main/views/test_service_settings.py:13:1: F811 redefinition of unused 'no_reply_to_email_addresses' from line 13
./tests/app/main/views/test_service_settings.py:13:1: F401 'tests.conftest.single_reply_to_email_address' imported but unused
./tests/app/main/views/test_service_settings.py:28:5: E123 closing bracket does not match indentation of opening bracket's line
./tests/app/main/views/test_service_settings.py:104:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:166:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:186:5: F841 local variable 'mocked_get_fn' is assigned to but never used
./tests/app/main/views/test_service_settings.py:217:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:237:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:257:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:307:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:340:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:466:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:555:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:615:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:719:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:874:5: F841 local variable 'page' is assigned to but never used
./tests/app/main/views/test_service_settings.py:902:5: F841 local variable 'page' is assigned to but never used
./tests/app/main/views/test_service_settings.py:954:5: F841 local variable 'page' is assigned to but never used
./tests/app/main/views/test_service_settings.py:986:5: F841 local variable 'page' is assigned to but never used
./tests/app/main/views/test_service_settings.py:1101:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1121:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1271:1: F811 redefinition of unused 'test_set_letter_contact_block_saves' from line 1189
./tests/app/main/views/test_service_settings.py:1433:5: F841 local variable 'page' is assigned to but never used
./tests/app/main/views/test_service_settings.py:1495:5: F841 local variable 'mocked_get_fn' is assigned to but never used
./tests/app/main/views/test_service_settings.py:1540:5: F841 local variable 'mocked_get_fn' is assigned to but never used
./tests/app/main/views/test_service_settings.py:1570:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1589:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1621:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1641:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1658:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1676:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1697:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1759:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_service_settings.py:1775:1: F811 redefinition of unused 'single_reply_to_email_address' from line 13
./tests/app/main/views/test_templates.py:3:1: F401 'uuid' imported but unused
./tests/app/main/views/test_templates.py:11:1: F401 'tests.conftest.mock_get_user' imported but unused
./tests/app/main/views/test_templates.py:514:1: F811 redefinition of unused 'mock_get_user' from line 11
./tests/app/main/views/test_templates.py:672:1: F811 redefinition of unused 'mock_get_user' from line 11
./tests/app/main/views/test_templates.py:795:1: F811 redefinition of unused 'mock_get_user' from line 11
./tests/app/main/views/test_templates.py:835:1: F811 redefinition of unused 'mock_get_user' from line 11
./tests/app/main/views/test_two_factor.py:67:13: E126 continuation line over-indented for hanging indent
./tests/app/notify_client/test_notification_client.py:79:5: F841 local variable 'mock_post' is assigned to but never used
```
1. https://gds-way.cloudapps.digital/manuals/programming-languages/python/linting.html#how-to-use-flake8
2. d5ab8afef4/.flake8
2281 lines
66 KiB
Python
2281 lines
66 KiB
Python
# -*- coding: utf-8 -*-
|
||
import uuid
|
||
from io import BytesIO
|
||
from os import path
|
||
from glob import glob
|
||
from itertools import repeat
|
||
from functools import partial
|
||
|
||
import pytest
|
||
from bs4 import BeautifulSoup
|
||
from flask import url_for
|
||
from notifications_python_client.errors import HTTPError
|
||
from notifications_utils.template import LetterPreviewTemplate, LetterImageTemplate
|
||
from notifications_utils.recipients import RecipientCSV
|
||
|
||
from tests import validate_route_permission, validate_route_permission_with_client
|
||
from tests.conftest import (
|
||
fake_uuid,
|
||
mock_get_service_template,
|
||
mock_get_service_template_with_placeholders,
|
||
mock_get_service_letter_template,
|
||
mock_get_service,
|
||
mock_get_international_service,
|
||
mock_get_service_email_template,
|
||
normalize_spaces,
|
||
SERVICE_ONE_ID,
|
||
mock_get_live_service,
|
||
multiple_reply_to_email_addresses,
|
||
no_reply_to_email_addresses,
|
||
)
|
||
|
||
template_types = ['email', 'sms']
|
||
|
||
# The * ignores hidden files, eg .DS_Store
|
||
test_spreadsheet_files = glob(path.join('tests', 'spreadsheet_files', '*'))
|
||
test_non_spreadsheet_files = glob(path.join('tests', 'non_spreadsheet_files', '*'))
|
||
|
||
|
||
@pytest.mark.parametrize('template_mock, sender_data, expected_title, expected_description', [
|
||
(
|
||
mock_get_service_email_template,
|
||
multiple_reply_to_email_addresses,
|
||
'Choose where to send replies',
|
||
'Select an email address that recipients can reply to'
|
||
),
|
||
])
|
||
def test_show_correct_title_and_description_for_sender_type(
|
||
client_request,
|
||
service_one,
|
||
fake_uuid,
|
||
template_mock,
|
||
sender_data,
|
||
expected_title,
|
||
expected_description,
|
||
mocker
|
||
):
|
||
template_mock(mocker)
|
||
sender_data(mocker)
|
||
|
||
page = client_request.get(
|
||
'.set_sender',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid
|
||
)
|
||
|
||
assert page.select_one('h1').text == expected_title
|
||
assert normalize_spaces(page.select_one('legend').text) == expected_description
|
||
|
||
|
||
def test_default_sender_is_checked_and_has_hint(
|
||
client_request,
|
||
service_one,
|
||
fake_uuid,
|
||
mock_get_service_email_template,
|
||
multiple_reply_to_email_addresses
|
||
):
|
||
page = client_request.get(
|
||
'.set_sender',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid
|
||
)
|
||
|
||
assert page.select('.multiple-choice input')[0].has_attr('checked')
|
||
assert normalize_spaces(page.select_one('.multiple-choice label .block-label-hint').text) == "Default"
|
||
assert not page.select('.multiple-choice input')[1].has_attr('checked')
|
||
assert not page.select('.multiple-choice input')[2].has_attr('checked')
|
||
|
||
|
||
def test_sender_session_is_present_after_selected(
|
||
logged_in_client,
|
||
service_one,
|
||
fake_uuid,
|
||
mock_get_service_email_template,
|
||
multiple_reply_to_email_addresses
|
||
):
|
||
logged_in_client.post(
|
||
url_for('.set_sender', service_id=service_one['id'], template_id=fake_uuid),
|
||
data={'sender': '1234'}
|
||
)
|
||
|
||
with logged_in_client.session_transaction() as session:
|
||
assert session['sender_id'] == '1234'
|
||
|
||
|
||
@pytest.mark.parametrize('template_mock, sender_data', [
|
||
(
|
||
mock_get_service_email_template,
|
||
no_reply_to_email_addresses,
|
||
),
|
||
])
|
||
def test_set_sender_redirects_if_no_sender_data(
|
||
logged_in_client,
|
||
service_one,
|
||
fake_uuid,
|
||
template_mock,
|
||
sender_data,
|
||
mocker
|
||
):
|
||
template_mock(mocker)
|
||
sender_data(mocker)
|
||
response = logged_in_client.get(
|
||
url_for('.set_sender', service_id=service_one['id'], template_id=fake_uuid)
|
||
)
|
||
assert response.status_code == 302
|
||
expected_url = url_for(
|
||
'.send_one_off',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
_external=True,
|
||
)
|
||
assert response.location == expected_url
|
||
|
||
|
||
def test_that_test_files_exist():
|
||
assert len(test_spreadsheet_files) == 8
|
||
assert len(test_non_spreadsheet_files) == 6
|
||
|
||
|
||
def test_should_not_allow_files_to_be_uploaded_without_the_correct_permission(
|
||
logged_in_client,
|
||
mock_get_service_template,
|
||
service_one,
|
||
fake_uuid,
|
||
):
|
||
template_id = fake_uuid
|
||
service_one['permissions'] = []
|
||
|
||
response = logged_in_client.get(url_for(
|
||
'.send_messages',
|
||
service_id=service_one['id'],
|
||
template_id=template_id),
|
||
follow_redirects=True)
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
|
||
assert response.status_code == 200
|
||
assert page.select('main p')[0].text.strip() == "Sending text messages has been disabled for your service."
|
||
assert page.select(".page-footer-back-link")[0].text == "Back to the template"
|
||
assert page.select(".page-footer-back-link")[0]['href'] == url_for(
|
||
'.view_template',
|
||
service_id=service_one['id'],
|
||
template_id=template_id,
|
||
)
|
||
|
||
|
||
@pytest.mark.parametrize(
|
||
"filename, acceptable_file",
|
||
list(zip(
|
||
test_spreadsheet_files, repeat(True)
|
||
)) +
|
||
list(zip(
|
||
test_non_spreadsheet_files, repeat(False)
|
||
))
|
||
)
|
||
def test_upload_files_in_different_formats(
|
||
filename,
|
||
acceptable_file,
|
||
logged_in_client,
|
||
service_one,
|
||
mocker,
|
||
mock_get_service_template,
|
||
mock_s3_upload,
|
||
fake_uuid,
|
||
):
|
||
|
||
with open(filename, 'rb') as uploaded:
|
||
response = logged_in_client.post(
|
||
url_for('main.send_messages', service_id=service_one['id'], template_id=fake_uuid),
|
||
data={'file': (BytesIO(uploaded.read()), filename)},
|
||
content_type='multipart/form-data'
|
||
)
|
||
|
||
if acceptable_file:
|
||
assert mock_s3_upload.call_args[0][1]['data'].strip() == (
|
||
"phone number,name,favourite colour,fruit\r\n"
|
||
"07739 468 050,Pete,Coral,tomato\r\n"
|
||
"07527 125 974,Not Pete,Magenta,Avacado\r\n"
|
||
"07512 058 823,Still Not Pete,Crimson,Pear"
|
||
)
|
||
else:
|
||
assert not mock_s3_upload.called
|
||
assert (
|
||
'Couldn’t read {}. Try using a different file format.'.format(filename)
|
||
) in response.get_data(as_text=True)
|
||
|
||
|
||
def test_upload_csvfile_with_errors_shows_check_page_with_errors(
|
||
logged_in_client,
|
||
service_one,
|
||
mocker,
|
||
mock_get_service_template_with_placeholders,
|
||
mock_s3_upload,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
fake_uuid,
|
||
):
|
||
|
||
mocker.patch(
|
||
'app.main.views.send.s3download',
|
||
return_value="""
|
||
phone number,name
|
||
+447700900986
|
||
+447700900986
|
||
"""
|
||
)
|
||
|
||
initial_upload = logged_in_client.post(
|
||
url_for('main.send_messages', service_id=service_one['id'], template_id=fake_uuid),
|
||
data={'file': (BytesIO(''.encode('utf-8')), 'invalid.csv')},
|
||
content_type='multipart/form-data',
|
||
follow_redirects=True
|
||
)
|
||
reupload = logged_in_client.post(
|
||
url_for('main.check_messages', service_id=service_one['id'], template_type='sms', upload_id='abc123'),
|
||
data={'file': (BytesIO(''.encode('utf-8')), 'invalid.csv')},
|
||
content_type='multipart/form-data',
|
||
follow_redirects=True
|
||
)
|
||
for response in [initial_upload, reupload]:
|
||
assert response.status_code == 200
|
||
content = response.get_data(as_text=True)
|
||
assert 'There is a problem with invalid.csv' in content
|
||
assert '+447700900986' in content
|
||
assert 'Missing' in content
|
||
assert 'Re-upload your file' in content
|
||
|
||
|
||
@pytest.mark.parametrize('file_contents, expected_error,', [
|
||
(
|
||
"""
|
||
telephone,name
|
||
+447700900986
|
||
""",
|
||
(
|
||
'Your file needs a column called ‘phone number’ '
|
||
'Right now it has columns called ‘telephone’ and ‘name’. '
|
||
'Skip to file contents'
|
||
)
|
||
),
|
||
(
|
||
"""
|
||
phone number
|
||
+447700900986
|
||
""",
|
||
(
|
||
'The columns in your file need to match the double brackets in your template '
|
||
'Your file is missing a column called ‘name’. '
|
||
'Skip to file contents'
|
||
)
|
||
),
|
||
(
|
||
"+447700900986",
|
||
(
|
||
'Your file is missing some rows '
|
||
'It needs at least one row of data, and columns called ‘name’ and ‘phone number’. '
|
||
'Skip to file contents'
|
||
)
|
||
),
|
||
(
|
||
"",
|
||
(
|
||
'Your file is missing some rows '
|
||
'It needs at least one row of data, and columns called ‘name’ and ‘phone number’. '
|
||
'Skip to file contents'
|
||
)
|
||
),
|
||
(
|
||
"""
|
||
phone number, name
|
||
+447700900986, example
|
||
, example
|
||
+447700900986, example
|
||
""",
|
||
(
|
||
'There is a problem with invalid.csv '
|
||
'You need to enter missing data in 1 row '
|
||
'Skip to file contents'
|
||
)
|
||
),
|
||
(
|
||
"""
|
||
phone number, name
|
||
+447700900986, example
|
||
+447700900986,
|
||
+447700900986, example
|
||
""",
|
||
(
|
||
'There is a problem with invalid.csv '
|
||
'You need to enter missing data in 1 row '
|
||
'Skip to file contents'
|
||
)
|
||
),
|
||
])
|
||
def test_upload_csvfile_with_missing_columns_shows_error(
|
||
logged_in_client,
|
||
mocker,
|
||
mock_get_service_template_with_placeholders,
|
||
mock_s3_upload,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
service_one,
|
||
fake_uuid,
|
||
file_contents,
|
||
expected_error,
|
||
):
|
||
|
||
mocker.patch('app.main.views.send.s3download', return_value=file_contents)
|
||
|
||
response = logged_in_client.post(
|
||
url_for('main.send_messages', service_id=service_one['id'], template_id=fake_uuid),
|
||
data={'file': (BytesIO(''.encode('utf-8')), 'invalid.csv')},
|
||
follow_redirects=True,
|
||
)
|
||
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
assert ' '.join(page.select('.banner-dangerous')[0].text.split()) == expected_error
|
||
|
||
|
||
def test_upload_csv_invalid_extension(
|
||
logged_in_client,
|
||
mock_login,
|
||
service_one,
|
||
mock_get_service_template,
|
||
fake_uuid,
|
||
):
|
||
|
||
resp = logged_in_client.post(
|
||
url_for('main.send_messages', service_id=service_one['id'], template_id=fake_uuid),
|
||
data={'file': (BytesIO('contents'.encode('utf-8')), 'invalid.txt')},
|
||
content_type='multipart/form-data',
|
||
follow_redirects=True
|
||
)
|
||
|
||
assert resp.status_code == 200
|
||
assert "invalid.txt isn’t a spreadsheet that Notify can read" in resp.get_data(as_text=True)
|
||
|
||
|
||
def test_upload_valid_csv_shows_file_contents(
|
||
logged_in_client,
|
||
mocker,
|
||
mock_get_service_template_with_placeholders,
|
||
mock_s3_upload,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
fake_uuid,
|
||
):
|
||
|
||
mocker.patch('app.main.views.send.s3download', return_value="""
|
||
phone number,name,thing,thing,thing
|
||
07700900986, Jo, foo, foo, foo
|
||
""")
|
||
|
||
response = logged_in_client.post(
|
||
url_for('main.send_messages', service_id=SERVICE_ONE_ID, template_id=fake_uuid),
|
||
data={'file': (BytesIO(''.encode('utf-8')), 'valid.csv')},
|
||
follow_redirects=True,
|
||
)
|
||
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
assert page.h1.text.strip() == 'Preview of Two week reminder'
|
||
for index, cell in enumerate([
|
||
'<td class="table-field-index"> <span class=""> 2 </span> </td>',
|
||
'<td class="table-field-center-aligned "> <div class=""> 07700900986 </div> </td>',
|
||
'<td class="table-field-center-aligned "> <div class=""> Jo </div> </td>',
|
||
(
|
||
'<td class="table-field-center-aligned "> '
|
||
'<div class="table-field-status-default"> '
|
||
'<ul class="list list-bullet"> '
|
||
'<li>foo</li> <li>foo</li> <li>foo</li> '
|
||
'</ul> '
|
||
'</div> '
|
||
'</td>'
|
||
),
|
||
]):
|
||
assert normalize_spaces(str(page.select('table tbody td')[index])) == cell
|
||
|
||
|
||
def test_send_test_doesnt_show_file_contents(
|
||
logged_in_client,
|
||
mocker,
|
||
mock_get_service_template,
|
||
mock_s3_upload,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
service_one,
|
||
fake_uuid,
|
||
):
|
||
|
||
mocker.patch('app.main.views.send.s3download', return_value="""
|
||
phone number
|
||
07700 900 986
|
||
""")
|
||
|
||
response = logged_in_client.get(
|
||
url_for('main.send_test', service_id=service_one['id'], template_id=fake_uuid),
|
||
follow_redirects=True,
|
||
)
|
||
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
assert page.select('h1')[0].text.strip() == 'Preview of Two week reminder'
|
||
assert len(page.select('table')) == 0
|
||
assert len(page.select('.banner-dangerous')) == 0
|
||
assert page.select('input[type=submit]')[0]['value'].strip() == 'Send 1 text message'
|
||
|
||
|
||
@pytest.mark.parametrize('endpoint, template_mock, expected_recipient', [
|
||
('main.send_test_step', mock_get_service_template_with_placeholders, '07700 900762'),
|
||
('main.send_test_step', mock_get_service_email_template, 'test@user.gov.uk'),
|
||
('main.send_test_step', mock_get_service_letter_template, None),
|
||
('main.send_one_off_step', mock_get_service_template, None),
|
||
('main.send_one_off_step', mock_get_service_email_template, None),
|
||
('main.send_one_off_step', mock_get_service_letter_template, None),
|
||
])
|
||
def test_send_test_step_redirects_if_session_not_setup(
|
||
mocker,
|
||
logged_in_client,
|
||
mock_get_detailed_service_for_today,
|
||
mock_get_users_by_service,
|
||
fake_uuid,
|
||
endpoint,
|
||
template_mock,
|
||
expected_recipient,
|
||
):
|
||
template_mock(mocker)
|
||
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=99)
|
||
|
||
with logged_in_client.session_transaction() as session:
|
||
assert 'recipient' not in session
|
||
assert 'placeholders' not in session
|
||
|
||
response = logged_in_client.get(
|
||
url_for(endpoint, service_id=SERVICE_ONE_ID, template_id=fake_uuid, step_index=0),
|
||
follow_redirects=True
|
||
)
|
||
assert response.status_code == 200
|
||
|
||
with logged_in_client.session_transaction() as session:
|
||
assert session['recipient'] == expected_recipient
|
||
|
||
|
||
def test_send_one_off_does_not_send_without_the_correct_permissions(
|
||
logged_in_client,
|
||
mock_get_service_template,
|
||
service_one,
|
||
fake_uuid,
|
||
):
|
||
template_id = fake_uuid
|
||
service_one['permissions'] = []
|
||
|
||
response = logged_in_client.get(url_for(
|
||
'.send_one_off',
|
||
service_id=service_one['id'],
|
||
template_id=template_id),
|
||
follow_redirects=True)
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
|
||
assert response.status_code == 200
|
||
assert page.select('main p')[0].text.strip() == "Sending text messages has been disabled for your service."
|
||
assert page.select(".page-footer-back-link")[0].text == "Back to the template"
|
||
assert page.select(".page-footer-back-link")[0]['href'] == url_for(
|
||
'.view_template',
|
||
service_id=service_one['id'],
|
||
template_id=template_id,
|
||
)
|
||
|
||
|
||
@pytest.mark.parametrize('template_mock, partial_url, expected_h1, tour_shown', [
|
||
(
|
||
mock_get_service_template_with_placeholders,
|
||
partial(url_for, 'main.send_test'),
|
||
'Send to one recipient',
|
||
False,
|
||
),
|
||
(
|
||
mock_get_service_template_with_placeholders,
|
||
partial(url_for, 'main.send_one_off'),
|
||
'Send to one recipient',
|
||
False,
|
||
),
|
||
(
|
||
mock_get_service_template_with_placeholders,
|
||
partial(url_for, 'main.send_test', help=1),
|
||
'Example text message',
|
||
True,
|
||
),
|
||
(
|
||
mock_get_service_email_template,
|
||
partial(url_for, 'main.send_test', help=1),
|
||
'Example text message',
|
||
True,
|
||
),
|
||
(
|
||
mock_get_service_email_template,
|
||
partial(url_for, 'main.send_test'),
|
||
'Send to one recipient',
|
||
False,
|
||
),
|
||
(
|
||
mock_get_service_email_template,
|
||
partial(url_for, 'main.send_one_off'),
|
||
'Send to one recipient',
|
||
False,
|
||
),
|
||
(
|
||
mock_get_service_letter_template,
|
||
partial(url_for, 'main.send_test'),
|
||
'Print a test letter',
|
||
False,
|
||
),
|
||
(
|
||
mock_get_service_letter_template,
|
||
partial(url_for, 'main.send_one_off'),
|
||
'Print a test letter',
|
||
False,
|
||
),
|
||
])
|
||
def test_send_one_off_or_test_has_correct_page_titles(
|
||
logged_in_client,
|
||
service_one,
|
||
fake_uuid,
|
||
mocker,
|
||
template_mock,
|
||
partial_url,
|
||
expected_h1,
|
||
tour_shown,
|
||
):
|
||
|
||
template_mock(mocker)
|
||
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=99)
|
||
|
||
response = logged_in_client.get(
|
||
partial_url(service_id=service_one['id'], template_id=fake_uuid, step_index=0),
|
||
follow_redirects=True,
|
||
)
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
|
||
assert response.status_code == 200
|
||
assert page.h1.text.strip() == expected_h1
|
||
|
||
assert (len(page.select('.banner-tour')) == 1) == tour_shown
|
||
|
||
|
||
@pytest.mark.parametrize('template_mock, expected_link_text, expected_link_url', [
|
||
(mock_get_service_template, 'Use my phone number', partial(url_for, 'main.send_test')),
|
||
(mock_get_service_email_template, 'Use my email address', partial(url_for, 'main.send_test')),
|
||
(mock_get_service_letter_template, None, None),
|
||
])
|
||
def test_send_one_off_has_skip_link(
|
||
logged_in_client,
|
||
service_one,
|
||
fake_uuid,
|
||
mock_get_service_email_template,
|
||
mocker,
|
||
template_mock,
|
||
expected_link_text,
|
||
expected_link_url,
|
||
):
|
||
|
||
template_mock(mocker)
|
||
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=99)
|
||
|
||
response = logged_in_client.get(
|
||
url_for('main.send_one_off_step', service_id=service_one['id'], template_id=fake_uuid, step_index=0),
|
||
follow_redirects=True
|
||
)
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
skip_links = page.select('a.top-gutter-4-3')
|
||
|
||
assert response.status_code == 200
|
||
|
||
if expected_link_text and expected_link_url:
|
||
assert skip_links[0].text.strip() == expected_link_text
|
||
assert skip_links[0]['href'] == expected_link_url(
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
)
|
||
else:
|
||
assert not skip_links
|
||
|
||
|
||
@pytest.mark.parametrize('endpoint, expected_redirect, placeholders', [
|
||
(
|
||
'main.send_test_step',
|
||
'main.send_test',
|
||
{'name': 'foo'},
|
||
),
|
||
(
|
||
'main.send_one_off_step',
|
||
'main.send_one_off',
|
||
{'name': 'foo', 'phone number': '07900900123'},
|
||
),
|
||
])
|
||
def test_send_test_redirects_to_end_if_step_out_of_bounds(
|
||
logged_in_client,
|
||
service_one,
|
||
fake_uuid,
|
||
endpoint,
|
||
placeholders,
|
||
expected_redirect,
|
||
):
|
||
|
||
with logged_in_client.session_transaction() as session:
|
||
session['placeholders'] = placeholders
|
||
|
||
response = logged_in_client.get(url_for(
|
||
endpoint,
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
step_index=999,
|
||
))
|
||
|
||
assert response.status_code == 302
|
||
expected_url = url_for(
|
||
expected_redirect,
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
_external=True,
|
||
)
|
||
assert response.location == expected_url
|
||
|
||
|
||
@pytest.mark.parametrize('endpoint, expected_redirect', [
|
||
('main.send_test_step', 'main.send_test'),
|
||
('main.send_one_off_step', 'main.send_one_off'),
|
||
])
|
||
def test_send_test_redirects_to_start_if_you_skip_steps(
|
||
logged_in_platform_admin_client,
|
||
service_one,
|
||
fake_uuid,
|
||
mock_get_service_letter_template,
|
||
mock_s3_upload,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
mocker,
|
||
endpoint,
|
||
expected_redirect,
|
||
):
|
||
|
||
with logged_in_platform_admin_client.session_transaction() as session:
|
||
session['send_test_letter_page_count'] = 1
|
||
session['placeholders'] = {'address_line_1': 'foo'}
|
||
|
||
response = logged_in_platform_admin_client.get(url_for(
|
||
endpoint,
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
step_index=7, # letter template has 7 placeholders – we’re at the end
|
||
))
|
||
assert response.status_code == 302
|
||
assert response.location == url_for(
|
||
expected_redirect,
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
_external=True,
|
||
)
|
||
|
||
|
||
@pytest.mark.parametrize('endpoint, expected_redirect', [
|
||
('main.send_test_step', 'main.send_test'),
|
||
('main.send_one_off_step', 'main.send_one_off'),
|
||
])
|
||
def test_send_test_redirects_to_start_if_index_out_of_bounds_and_some_placeholders_empty(
|
||
logged_in_client,
|
||
service_one,
|
||
fake_uuid,
|
||
mock_get_service_email_template,
|
||
mock_s3_download,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
endpoint,
|
||
expected_redirect,
|
||
):
|
||
|
||
with logged_in_client.session_transaction() as session:
|
||
session['placeholders'] = {'name': 'foo'}
|
||
|
||
response = logged_in_client.get(url_for(
|
||
endpoint,
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
step_index=999,
|
||
))
|
||
|
||
assert response.status_code == 302
|
||
assert response.location == url_for(
|
||
expected_redirect,
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
_external=True,
|
||
)
|
||
|
||
|
||
@pytest.mark.parametrize('endpoint, expected_redirect', [
|
||
('main.send_test', 'main.send_test_step'),
|
||
('main.send_one_off', 'main.send_one_off_step'),
|
||
])
|
||
def _redirects_with_help_argument(
|
||
logged_in_client,
|
||
mocker,
|
||
service_one,
|
||
fake_uuid,
|
||
endpoint,
|
||
expected_redirect,
|
||
):
|
||
template = {'data': {'template_type': 'sms'}}
|
||
mocker.patch('app.service_api_client.get_service_template', return_value=template)
|
||
|
||
response = logged_in_client.get(
|
||
url_for(endpoint, service_id=service_one['id'], template_id=fake_uuid, help=1)
|
||
)
|
||
assert response.status_code == 302
|
||
assert response.location == url_for(
|
||
expected_redirect,
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
step_index=0,
|
||
help=1,
|
||
_external=True,
|
||
)
|
||
|
||
|
||
def test_send_test_email_message_without_placeholders_redirects_to_check_page(
|
||
logged_in_client,
|
||
mocker,
|
||
service_one,
|
||
mock_get_service_email_template_without_placeholders,
|
||
mock_s3_upload,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
fake_uuid,
|
||
):
|
||
with logged_in_client.session_transaction() as session:
|
||
session['recipient'] = 'foo@bar.com'
|
||
|
||
response = logged_in_client.get(
|
||
url_for('main.send_test', step_index=0, service_id=service_one['id'], template_id=fake_uuid),
|
||
follow_redirects=True
|
||
)
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
assert page.select('h1')[0].text.strip() == 'Preview of Two week reminder'
|
||
|
||
|
||
def test_send_test_sms_message_with_placeholders_shows_first_field(
|
||
logged_in_client,
|
||
mocker,
|
||
service_one,
|
||
mock_login,
|
||
mock_get_service,
|
||
mock_get_service_template_with_placeholders,
|
||
fake_uuid,
|
||
):
|
||
|
||
with logged_in_client.session_transaction() as session:
|
||
assert 'placeholders' not in session
|
||
|
||
response = logged_in_client.get(
|
||
url_for(
|
||
'main.send_test',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
),
|
||
follow_redirects=True,
|
||
)
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
|
||
assert page.select('label')[0].text.strip() == 'name'
|
||
assert page.select('input')[0]['name'] == 'placeholder_value'
|
||
assert page.select('.page-footer-back-link')[0]['href'] == url_for(
|
||
'main.view_template',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
)
|
||
with logged_in_client.session_transaction() as session:
|
||
assert session['recipient'] == '07700 900762'
|
||
|
||
|
||
def test_send_test_letter_clears_previous_page_cache(
|
||
logged_in_platform_admin_client,
|
||
mocker,
|
||
service_one,
|
||
mock_login,
|
||
mock_get_service,
|
||
mock_get_service_letter_template,
|
||
fake_uuid,
|
||
):
|
||
|
||
with logged_in_platform_admin_client.session_transaction() as session:
|
||
session['send_test_letter_page_count'] = 'WRONG'
|
||
|
||
response = logged_in_platform_admin_client.get(url_for(
|
||
'main.send_test',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
))
|
||
assert response.status_code == 302
|
||
|
||
with logged_in_platform_admin_client.session_transaction() as session:
|
||
assert session['send_test_letter_page_count'] is None
|
||
|
||
|
||
def test_send_test_populates_field_from_session(
|
||
logged_in_client,
|
||
mocker,
|
||
service_one,
|
||
mock_login,
|
||
mock_get_service,
|
||
mock_get_service_template_with_placeholders,
|
||
fake_uuid,
|
||
):
|
||
|
||
with logged_in_client.session_transaction() as session:
|
||
session['recipient'] = None
|
||
session['placeholders'] = {}
|
||
session['placeholders']['name'] = 'Jo'
|
||
|
||
response = logged_in_client.get(url_for(
|
||
'main.send_test_step',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
step_index=0,
|
||
))
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
|
||
assert page.select('input')[0]['value'] == 'Jo'
|
||
|
||
|
||
def test_send_test_caches_page_count(
|
||
logged_in_client,
|
||
mocker,
|
||
service_one,
|
||
mock_login,
|
||
mock_get_service,
|
||
mock_get_service_letter_template,
|
||
fake_uuid,
|
||
):
|
||
|
||
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=99)
|
||
|
||
logged_in_client.get(
|
||
url_for(
|
||
'main.send_test',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
),
|
||
follow_redirects=True,
|
||
)
|
||
with logged_in_client.session_transaction() as session:
|
||
assert session['send_test_letter_page_count'] == 99
|
||
|
||
|
||
def test_send_test_indicates_optional_address_columns(
|
||
logged_in_client,
|
||
mocker,
|
||
service_one,
|
||
mock_login,
|
||
mock_get_service,
|
||
mock_get_service_letter_template,
|
||
fake_uuid,
|
||
):
|
||
|
||
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=1)
|
||
|
||
with logged_in_client.session_transaction() as session:
|
||
session['recipient'] = None
|
||
session['placeholders'] = {}
|
||
|
||
response = logged_in_client.get(url_for(
|
||
'main.send_test_step',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
step_index=3,
|
||
))
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
|
||
assert normalize_spaces(page.select('label')[0].text) == (
|
||
'address line 4 '
|
||
'Optional'
|
||
)
|
||
assert page.select('.page-footer-back-link')[0]['href'] == url_for(
|
||
'main.send_test_step',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
step_index=2,
|
||
)
|
||
|
||
|
||
def test_send_test_allows_empty_optional_address_columns(
|
||
logged_in_client,
|
||
mocker,
|
||
service_one,
|
||
mock_login,
|
||
mock_get_service,
|
||
mock_get_service_letter_template,
|
||
fake_uuid,
|
||
):
|
||
|
||
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=1)
|
||
|
||
with logged_in_client.session_transaction() as session:
|
||
session['recipient'] = None
|
||
session['placeholders'] = {}
|
||
|
||
response = logged_in_client.post(
|
||
url_for(
|
||
'main.send_test_step',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
step_index=3,
|
||
),
|
||
# no data here
|
||
)
|
||
|
||
assert response.status_code == 302
|
||
assert response.location == url_for(
|
||
'main.send_test_step',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
step_index=4,
|
||
_external=True,
|
||
)
|
||
|
||
|
||
def test_send_test_sms_message_puts_submitted_data_in_session(
|
||
logged_in_client,
|
||
service_one,
|
||
mock_get_service_template_with_placeholders,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
fake_uuid,
|
||
):
|
||
with logged_in_client.session_transaction() as session:
|
||
session['recipient'] = '07700 900762'
|
||
session['placeholders'] = {}
|
||
|
||
response = logged_in_client.post(
|
||
url_for(
|
||
'main.send_test_step',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
step_index=0,
|
||
),
|
||
data={'placeholder_value': 'Jo'}
|
||
)
|
||
assert response.status_code == 302
|
||
assert response.location == url_for(
|
||
'main.check_notification',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
_external=True
|
||
)
|
||
|
||
with logged_in_client.session_transaction() as session:
|
||
assert session['recipient'] == '07700 900762'
|
||
assert session['placeholders']['name'] == 'Jo'
|
||
|
||
|
||
@pytest.mark.parametrize('filetype', ['pdf', 'png'])
|
||
def test_send_test_works_as_letter_preview(
|
||
filetype,
|
||
logged_in_platform_admin_client,
|
||
mock_get_service_letter_template,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
service_one,
|
||
fake_uuid,
|
||
mocker,
|
||
):
|
||
service_one['permissions'] = ['letter']
|
||
mocker.patch('app.service_api_client.get_service', return_value={"data": service_one})
|
||
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=1)
|
||
mocked_preview = mocker.patch(
|
||
'app.main.views.send.TemplatePreview.from_utils_template',
|
||
return_value='foo'
|
||
)
|
||
|
||
service_id = service_one['id']
|
||
template_id = fake_uuid
|
||
with logged_in_platform_admin_client.session_transaction() as session:
|
||
session['placeholders'] = {'address_line_1': 'Jo Lastname'}
|
||
response = logged_in_platform_admin_client.get(
|
||
url_for(
|
||
'main.send_test_preview',
|
||
service_id=service_id,
|
||
template_id=template_id,
|
||
filetype=filetype
|
||
)
|
||
)
|
||
|
||
mock_get_service_letter_template.assert_called_with(service_id, template_id)
|
||
|
||
assert response.status_code == 200
|
||
assert response.get_data(as_text=True) == 'foo'
|
||
assert mocked_preview.call_args[0][0].id == template_id
|
||
assert type(mocked_preview.call_args[0][0]) == LetterImageTemplate
|
||
assert mocked_preview.call_args[0][0].values == {'address_line_1': 'Jo Lastname'}
|
||
assert mocked_preview.call_args[0][1] == filetype
|
||
|
||
|
||
def test_send_test_clears_session(
|
||
logged_in_client,
|
||
mocker,
|
||
service_one,
|
||
fake_uuid,
|
||
):
|
||
template = {'data': {'template_type': 'sms'}}
|
||
mocker.patch('app.service_api_client.get_service_template', return_value=template)
|
||
|
||
with logged_in_client.session_transaction() as session:
|
||
session['recipient'] = '07700900001'
|
||
session['placeholders'] = {'foo': 'bar'}
|
||
|
||
response = logged_in_client.get(
|
||
url_for(
|
||
'main.send_test',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
),
|
||
)
|
||
assert response.status_code == 302
|
||
|
||
with logged_in_client.session_transaction() as session:
|
||
assert session['recipient'] is None
|
||
assert session['placeholders'] == {}
|
||
|
||
|
||
def test_download_example_csv(
|
||
logged_in_client,
|
||
mocker,
|
||
api_user_active,
|
||
mock_login,
|
||
mock_get_service,
|
||
mock_get_service_template,
|
||
mock_has_permissions,
|
||
fake_uuid
|
||
):
|
||
|
||
response = logged_in_client.get(
|
||
url_for('main.get_example_csv', service_id=fake_uuid, template_id=fake_uuid),
|
||
follow_redirects=True
|
||
)
|
||
assert response.status_code == 200
|
||
assert response.get_data(as_text=True) == 'phone number\r\n07700 900321\r\n'
|
||
assert 'text/csv' in response.headers['Content-Type']
|
||
|
||
|
||
def test_upload_csvfile_with_valid_phone_shows_all_numbers(
|
||
logged_in_client,
|
||
mock_get_service_template,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
service_one,
|
||
fake_uuid,
|
||
mock_s3_upload,
|
||
mocker,
|
||
):
|
||
|
||
mocker.patch(
|
||
'app.main.views.send.s3download',
|
||
return_value='\n'.join(['phone number'] + [
|
||
'07700 9007{0:02d}'.format(final_two) for final_two in range(0, 53)
|
||
])
|
||
)
|
||
|
||
response = logged_in_client.post(
|
||
url_for('main.send_messages', service_id=service_one['id'], template_id=fake_uuid),
|
||
data={'file': (BytesIO(''.encode('utf-8')), 'valid.csv')},
|
||
content_type='multipart/form-data',
|
||
follow_redirects=True
|
||
)
|
||
with logged_in_client.session_transaction() as sess:
|
||
assert sess['upload_data']['template_id'] == fake_uuid
|
||
assert sess['upload_data']['original_file_name'] == 'valid.csv'
|
||
assert sess['upload_data']['notification_count'] == 53
|
||
|
||
content = response.get_data(as_text=True)
|
||
assert response.status_code == 200
|
||
assert '07700 900701' in content
|
||
assert '07700 900749' in content
|
||
assert '07700 900750' not in content
|
||
assert 'Only showing the first 50 rows' in content
|
||
|
||
mock_get_detailed_service_for_today.assert_called_once_with(service_one['id'])
|
||
|
||
|
||
@pytest.mark.parametrize('service_mock, should_allow_international', [
|
||
(mock_get_service, False),
|
||
(mock_get_international_service, True),
|
||
])
|
||
def test_upload_csvfile_with_international_validates(
|
||
mocker,
|
||
api_user_active,
|
||
logged_in_client,
|
||
mock_get_service_template,
|
||
mock_s3_upload,
|
||
mock_has_permissions,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
fake_uuid,
|
||
service_mock,
|
||
should_allow_international,
|
||
):
|
||
|
||
service_mock(mocker, api_user_active)
|
||
mocker.patch('app.main.views.send.s3download', return_value='')
|
||
mock_recipients = mocker.patch(
|
||
'app.main.views.send.RecipientCSV',
|
||
return_value=RecipientCSV("", template_type="sms"),
|
||
)
|
||
|
||
response = logged_in_client.post(
|
||
url_for('main.send_messages', service_id=fake_uuid, template_id=fake_uuid),
|
||
data={'file': (BytesIO(''.encode('utf-8')), 'valid.csv')},
|
||
content_type='multipart/form-data',
|
||
follow_redirects=True,
|
||
)
|
||
|
||
assert response.status_code == 200
|
||
assert mock_recipients.call_args[1]['international_sms'] == should_allow_international
|
||
|
||
|
||
def test_test_message_can_only_be_sent_now(
|
||
logged_in_client,
|
||
mocker,
|
||
service_one,
|
||
mock_get_service_template,
|
||
mock_s3_download,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
fake_uuid
|
||
):
|
||
|
||
with logged_in_client.session_transaction() as session:
|
||
session['upload_data'] = {
|
||
'original_file_name': 'Test message',
|
||
'template_id': fake_uuid,
|
||
'notification_count': 1,
|
||
'valid': True
|
||
}
|
||
response = logged_in_client.get(url_for(
|
||
'main.check_messages',
|
||
service_id=service_one['id'],
|
||
upload_id=fake_uuid,
|
||
template_type='sms',
|
||
from_test=True
|
||
))
|
||
|
||
content = response.get_data(as_text=True)
|
||
assert 'name="scheduled_for"' not in content
|
||
|
||
|
||
def test_letter_can_only_be_sent_now(
|
||
logged_in_client,
|
||
mocker,
|
||
service_one,
|
||
mock_get_service_letter_template,
|
||
mock_s3_download,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
fake_uuid,
|
||
):
|
||
|
||
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=1)
|
||
|
||
with logged_in_client.session_transaction() as session:
|
||
session['upload_data'] = {
|
||
'original_file_name': 'Test message',
|
||
'template_id': fake_uuid,
|
||
'notification_count': 1,
|
||
'valid': True
|
||
}
|
||
|
||
response = logged_in_client.get(url_for(
|
||
'main.check_messages',
|
||
service_id=service_one['id'],
|
||
upload_id=fake_uuid,
|
||
template_type='letter',
|
||
from_test=True
|
||
))
|
||
|
||
content = response.get_data(as_text=True)
|
||
assert 'name="scheduled_for"' not in content
|
||
|
||
|
||
@pytest.mark.parametrize('when', [
|
||
'', '2016-08-25T13:04:21.767198'
|
||
])
|
||
def test_create_job_should_call_api(
|
||
logged_in_client,
|
||
service_one,
|
||
mock_create_job,
|
||
mock_get_job,
|
||
mock_get_notifications,
|
||
mock_get_service_template,
|
||
mocker,
|
||
fake_uuid,
|
||
when
|
||
):
|
||
service_id = service_one['id']
|
||
data = mock_get_job(service_one['id'], fake_uuid)['data']
|
||
job_id = data['id']
|
||
original_file_name = data['original_file_name']
|
||
template_id = data['template']
|
||
notification_count = data['notification_count']
|
||
with logged_in_client.session_transaction() as session:
|
||
session['upload_data'] = {
|
||
'original_file_name': original_file_name,
|
||
'template_id': template_id,
|
||
'notification_count': notification_count,
|
||
'valid': True
|
||
}
|
||
url = url_for('main.start_job', service_id=service_one['id'], upload_id=job_id)
|
||
response = logged_in_client.post(url, data={'scheduled_for': when}, follow_redirects=True)
|
||
|
||
assert response.status_code == 200
|
||
assert original_file_name in response.get_data(as_text=True)
|
||
mock_create_job.assert_called_with(
|
||
job_id,
|
||
service_id,
|
||
template_id,
|
||
original_file_name,
|
||
notification_count,
|
||
scheduled_for=when
|
||
)
|
||
|
||
|
||
def test_can_start_letters_job(
|
||
logged_in_platform_admin_client,
|
||
mock_create_job,
|
||
service_one,
|
||
fake_uuid
|
||
):
|
||
|
||
with logged_in_platform_admin_client.session_transaction() as session:
|
||
session['upload_data'] = {
|
||
'original_file_name': 'example.csv',
|
||
'template_id': fake_uuid,
|
||
'notification_count': 123,
|
||
'valid': True
|
||
}
|
||
response = logged_in_platform_admin_client.post(
|
||
url_for('main.start_job', service_id=service_one['id'], upload_id=fake_uuid),
|
||
data={}
|
||
)
|
||
assert response.status_code == 302
|
||
assert 'just_sent=yes' in response.location
|
||
|
||
|
||
@pytest.mark.parametrize('filetype', ['pdf', 'png'])
|
||
def test_should_show_preview_letter_message(
|
||
filetype,
|
||
logged_in_platform_admin_client,
|
||
mock_get_service_letter_template,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
service_one,
|
||
fake_uuid,
|
||
mocker,
|
||
):
|
||
service_one['permissions'] = ['letter']
|
||
mocker.patch('app.service_api_client.get_service', return_value={"data": service_one})
|
||
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=1)
|
||
|
||
mocker.patch(
|
||
'app.main.views.send.s3download',
|
||
return_value='\n'.join(
|
||
['address line 1, postcode'] +
|
||
['123 street, abc123']
|
||
)
|
||
)
|
||
mocked_preview = mocker.patch(
|
||
'app.main.views.send.TemplatePreview.from_utils_template',
|
||
return_value='foo'
|
||
)
|
||
|
||
service_id = service_one['id']
|
||
template_id = fake_uuid
|
||
with logged_in_platform_admin_client.session_transaction() as session:
|
||
session['upload_data'] = {
|
||
'original_file_name': 'example.csv',
|
||
'template_id': fake_uuid,
|
||
'notification_count': 1,
|
||
'valid': True
|
||
}
|
||
response = logged_in_platform_admin_client.get(
|
||
url_for(
|
||
'main.check_messages_preview',
|
||
service_id=service_id,
|
||
template_type='letter',
|
||
upload_id=fake_uuid,
|
||
filetype=filetype
|
||
)
|
||
)
|
||
|
||
mock_get_service_letter_template.assert_called_with(service_id, template_id)
|
||
|
||
assert response.status_code == 200
|
||
assert response.get_data(as_text=True) == 'foo'
|
||
assert mocked_preview.call_args[0][0].id == template_id
|
||
assert type(mocked_preview.call_args[0][0]) == LetterPreviewTemplate
|
||
assert mocked_preview.call_args[0][1] == filetype
|
||
|
||
|
||
def test_dont_show_preview_letter_templates_for_bad_filetype(
|
||
logged_in_client,
|
||
mock_get_service_template,
|
||
service_one,
|
||
fake_uuid
|
||
):
|
||
resp = logged_in_client.get(
|
||
url_for(
|
||
'main.check_messages_preview',
|
||
service_id=service_one['id'],
|
||
template_type='letter',
|
||
upload_id=fake_uuid,
|
||
filetype='blah'
|
||
)
|
||
)
|
||
assert resp.status_code == 404
|
||
assert mock_get_service_template.called is False
|
||
|
||
|
||
def test_check_messages_should_revalidate_file_when_uploading_file(
|
||
logged_in_client,
|
||
service_one,
|
||
mock_create_job,
|
||
mock_get_job,
|
||
mock_get_service_template_with_placeholders,
|
||
mock_s3_upload,
|
||
mocker,
|
||
mock_get_detailed_service_for_today,
|
||
mock_get_users_by_service,
|
||
fake_uuid
|
||
):
|
||
|
||
mocker.patch(
|
||
'app.main.views.send.s3download',
|
||
return_value="""
|
||
phone number,name,,,
|
||
+447700900986,,,,
|
||
+447700900986,,,,
|
||
"""
|
||
)
|
||
data = mock_get_job(SERVICE_ONE_ID, fake_uuid)['data']
|
||
with logged_in_client.session_transaction() as session:
|
||
session['upload_data'] = {'original_file_name': 'invalid.csv',
|
||
'template_id': data['template'],
|
||
'notification_count': data['notification_count'],
|
||
'valid': True}
|
||
response = logged_in_client.post(
|
||
url_for('main.start_job', service_id=SERVICE_ONE_ID, upload_id=data['id']),
|
||
data={'file': (BytesIO(''.encode('utf-8')), 'invalid.csv')},
|
||
content_type='multipart/form-data',
|
||
follow_redirects=True
|
||
)
|
||
assert response.status_code == 200
|
||
assert 'There is a problem with invalid.csv' in response.get_data(as_text=True)
|
||
|
||
|
||
@pytest.mark.parametrize('route, response_code', [
|
||
('main.choose_template', 200),
|
||
('main.send_messages', 200),
|
||
('main.get_example_csv', 200),
|
||
('main.send_test', 302)
|
||
])
|
||
def test_route_permissions(
|
||
mocker,
|
||
app_,
|
||
client,
|
||
api_user_active,
|
||
service_one,
|
||
mock_get_service_template,
|
||
mock_get_service_templates,
|
||
mock_get_jobs,
|
||
mock_get_notifications,
|
||
mock_create_job,
|
||
mock_s3_upload,
|
||
fake_uuid,
|
||
route,
|
||
response_code,
|
||
):
|
||
validate_route_permission(
|
||
mocker,
|
||
app_,
|
||
"GET",
|
||
response_code,
|
||
url_for(
|
||
route,
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid
|
||
),
|
||
['send_texts', 'send_emails', 'send_letters'],
|
||
api_user_active,
|
||
service_one)
|
||
|
||
|
||
@pytest.mark.parametrize('route, response_code, method', [
|
||
('main.check_notification', 200, 'GET'),
|
||
('main.send_notification', 302, 'POST')
|
||
])
|
||
def test_route_permissions_send_check_notifications(
|
||
mocker,
|
||
app_,
|
||
client,
|
||
api_user_active,
|
||
service_one,
|
||
mock_send_notification,
|
||
mock_get_service_template,
|
||
fake_uuid,
|
||
route,
|
||
response_code,
|
||
method
|
||
):
|
||
with client.session_transaction() as session:
|
||
session['recipient'] = '07700900001'
|
||
session['placeholders'] = {'name': 'a'}
|
||
validate_route_permission_with_client(
|
||
mocker,
|
||
client,
|
||
method,
|
||
response_code,
|
||
url_for(
|
||
route,
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid
|
||
),
|
||
['send_texts', 'send_emails', 'send_letters'],
|
||
api_user_active,
|
||
service_one
|
||
)
|
||
|
||
|
||
@pytest.mark.parametrize('route', [
|
||
'main.choose_template',
|
||
'main.send_messages',
|
||
'main.get_example_csv',
|
||
'main.send_test'
|
||
])
|
||
def test_route_invalid_permissions(
|
||
mocker,
|
||
app_,
|
||
client,
|
||
api_user_active,
|
||
service_one,
|
||
mock_get_service_template,
|
||
mock_get_service_templates,
|
||
mock_get_jobs,
|
||
mock_get_notifications,
|
||
mock_create_job,
|
||
fake_uuid,
|
||
route,
|
||
):
|
||
validate_route_permission(
|
||
mocker,
|
||
app_,
|
||
"GET",
|
||
403,
|
||
url_for(
|
||
route,
|
||
service_id=service_one['id'],
|
||
template_type='sms',
|
||
template_id=fake_uuid),
|
||
['blah'],
|
||
api_user_active,
|
||
service_one)
|
||
|
||
|
||
@pytest.mark.parametrize(
|
||
'template_mock, extra_args, expected_url',
|
||
[
|
||
(
|
||
mock_get_service_template,
|
||
dict(),
|
||
partial(url_for, '.send_messages')
|
||
),
|
||
(
|
||
mock_get_service_template_with_placeholders,
|
||
dict(),
|
||
partial(url_for, '.send_messages')
|
||
),
|
||
(
|
||
mock_get_service_letter_template, # No placeholders
|
||
dict(from_test=True),
|
||
partial(url_for, '.send_test')
|
||
),
|
||
(
|
||
mock_get_service_template_with_placeholders,
|
||
dict(from_test=True),
|
||
partial(url_for, '.send_test')
|
||
)
|
||
]
|
||
)
|
||
def test_check_messages_back_link(
|
||
logged_in_client,
|
||
api_user_active,
|
||
mock_login,
|
||
mock_get_user_by_email,
|
||
mock_get_users_by_service,
|
||
mock_get_service,
|
||
mock_has_permissions,
|
||
mock_get_detailed_service_for_today,
|
||
mock_s3_download,
|
||
fake_uuid,
|
||
mocker,
|
||
template_mock,
|
||
extra_args,
|
||
expected_url
|
||
):
|
||
template_mock(mocker)
|
||
with logged_in_client.session_transaction() as session:
|
||
session['upload_data'] = {'original_file_name': 'valid.csv',
|
||
'template_id': fake_uuid,
|
||
'notification_count': 1,
|
||
'valid': True}
|
||
response = logged_in_client.get(url_for(
|
||
'main.check_messages',
|
||
service_id=fake_uuid,
|
||
upload_id=fake_uuid,
|
||
template_type='sms',
|
||
**extra_args
|
||
))
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
assert (
|
||
page.findAll('a', {'class': 'page-footer-back-link'})[0]['href']
|
||
) == expected_url(service_id=fake_uuid, template_id=fake_uuid)
|
||
|
||
|
||
def test_shows_link_to_end_tour(
|
||
client_request,
|
||
mock_get_notification,
|
||
fake_uuid,
|
||
):
|
||
|
||
page = client_request.get(
|
||
'main.view_notification',
|
||
service_id=SERVICE_ONE_ID,
|
||
notification_id=fake_uuid,
|
||
help=3,
|
||
)
|
||
|
||
assert page.select(".banner-tour a")[0]['href'] == url_for(
|
||
'main.go_to_dashboard_after_tour',
|
||
service_id=SERVICE_ONE_ID,
|
||
example_template_id='5407f4db-51c7-4150-8758-35412d42186a',
|
||
)
|
||
|
||
|
||
def test_go_to_dashboard_after_tour_link(
|
||
logged_in_client,
|
||
mocker,
|
||
api_user_active,
|
||
mock_login,
|
||
mock_get_service,
|
||
mock_has_permissions,
|
||
mock_delete_service_template,
|
||
fake_uuid
|
||
):
|
||
|
||
resp = logged_in_client.get(
|
||
url_for('main.go_to_dashboard_after_tour', service_id=fake_uuid, example_template_id=fake_uuid)
|
||
)
|
||
|
||
assert resp.status_code == 302
|
||
assert resp.location == url_for("main.service_dashboard", service_id=fake_uuid, _external=True)
|
||
mock_delete_service_template.assert_called_once_with(fake_uuid, fake_uuid)
|
||
|
||
|
||
@pytest.mark.parametrize('num_requested,expected_msg', [
|
||
(0, '‘valid.csv’ contains 100 phone numbers.'),
|
||
(1, 'You can still send 49 messages today, but ‘valid.csv’ contains 100 phone numbers.')
|
||
], ids=['none_sent', 'some_sent'])
|
||
def test_check_messages_shows_too_many_messages_errors(
|
||
mocker,
|
||
logged_in_client,
|
||
api_user_active,
|
||
mock_login,
|
||
mock_get_users_by_service,
|
||
mock_get_service,
|
||
mock_get_service_template,
|
||
mock_has_permissions,
|
||
fake_uuid,
|
||
num_requested,
|
||
expected_msg
|
||
):
|
||
# csv with 100 phone numbers
|
||
mocker.patch('app.main.views.send.s3download', return_value=',\n'.join(
|
||
['phone number'] + ([mock_get_users_by_service(None)[0]._mobile_number] * 100)
|
||
))
|
||
mocker.patch('app.service_api_client.get_detailed_service_for_today', return_value={
|
||
'data': {
|
||
'statistics': {
|
||
'sms': {'requested': num_requested, 'delivered': 0, 'failed': 0},
|
||
'email': {'requested': 0, 'delivered': 0, 'failed': 0}
|
||
}
|
||
}
|
||
})
|
||
|
||
with logged_in_client.session_transaction() as session:
|
||
session['upload_data'] = {'original_file_name': 'valid.csv',
|
||
'template_id': fake_uuid,
|
||
'notification_count': 1,
|
||
'valid': True}
|
||
response = logged_in_client.get(url_for(
|
||
'main.check_messages',
|
||
service_id=fake_uuid,
|
||
template_type='sms',
|
||
upload_id=fake_uuid
|
||
))
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
assert page.find('h1').text.strip() == 'Too many recipients'
|
||
assert page.find('div', class_='banner-dangerous').find('a').text.strip() == 'trial mode'
|
||
|
||
# remove excess whitespace from element
|
||
details = page.find('div', class_='banner-dangerous').findAll('p')[1]
|
||
details = ' '.join([line.strip() for line in details.text.split('\n') if line.strip() != ''])
|
||
assert details == expected_msg
|
||
|
||
|
||
def test_check_messages_shows_trial_mode_error(
|
||
logged_in_client,
|
||
mock_get_users_by_service,
|
||
mock_get_service,
|
||
mock_get_service_template,
|
||
mock_has_permissions,
|
||
mock_get_detailed_service_for_today,
|
||
mocker
|
||
):
|
||
mocker.patch('app.main.views.send.s3download', return_value=(
|
||
'phone number,\n07900900321' # Not in team
|
||
))
|
||
with logged_in_client.session_transaction() as session:
|
||
session['upload_data'] = {'template_id': ''}
|
||
response = logged_in_client.get(url_for(
|
||
'main.check_messages',
|
||
service_id=uuid.uuid4(),
|
||
template_type='sms',
|
||
upload_id=uuid.uuid4()
|
||
))
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
assert ' '.join(
|
||
page.find('div', class_='banner-dangerous').text.split()
|
||
) == (
|
||
'You can’t send to this phone number '
|
||
'In trial mode you can only send to yourself and members of your team '
|
||
'Skip to file contents'
|
||
)
|
||
|
||
|
||
@pytest.mark.parametrize('service_mock, error_should_be_shown', [
|
||
(mock_get_service, True),
|
||
(mock_get_live_service, False),
|
||
])
|
||
@pytest.mark.parametrize('number_of_rows, expected_error_message', [
|
||
(1, 'You can’t send this letter'),
|
||
(111, 'You can’t send these letters'),
|
||
])
|
||
def test_check_messages_shows_trial_mode_error_for_letters(
|
||
client_request,
|
||
api_user_active,
|
||
mock_get_service_letter_template,
|
||
mock_has_permissions,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
mocker,
|
||
service_mock,
|
||
error_should_be_shown,
|
||
number_of_rows,
|
||
expected_error_message,
|
||
):
|
||
|
||
service_mock(mocker, api_user_active)
|
||
|
||
mocker.patch('app.main.views.send.s3download', return_value='\n'.join(
|
||
['address_line_1,address_line_2,postcode,'] +
|
||
['First Last, 123 Street, SW1 1AA'] * number_of_rows
|
||
))
|
||
|
||
with client_request.session_transaction() as session:
|
||
session['upload_data'] = {'template_id': ''}
|
||
|
||
page = client_request.get(
|
||
'main.check_messages',
|
||
service_id=SERVICE_ONE_ID,
|
||
template_type='letter',
|
||
upload_id=uuid.uuid4(),
|
||
_test_page_title=False,
|
||
)
|
||
|
||
error = page.select('.banner-dangerous')
|
||
|
||
if error_should_be_shown:
|
||
assert normalize_spaces(error[0].text) == (
|
||
'{} '
|
||
'In trial mode you can only preview how your letters will look '
|
||
'Skip to file contents'
|
||
).format(expected_error_message)
|
||
else:
|
||
assert not error
|
||
|
||
|
||
def test_check_messages_shows_data_errors_before_trial_mode_errors_for_letters(
|
||
mocker,
|
||
client_request,
|
||
mock_get_service_letter_template,
|
||
mock_has_permissions,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
):
|
||
|
||
mocker.patch('app.main.views.send.s3download', return_value='\n'.join(
|
||
['address_line_1,address_line_2,postcode,'] +
|
||
[' , ,11SW1 1AA']
|
||
))
|
||
|
||
with client_request.session_transaction() as session:
|
||
session['upload_data'] = {'template_id': '', 'original_file_name': 'example.xlsx'}
|
||
|
||
page = client_request.get(
|
||
'main.check_messages',
|
||
service_id=SERVICE_ONE_ID,
|
||
template_type='letter',
|
||
upload_id=uuid.uuid4(),
|
||
_test_page_title=False,
|
||
)
|
||
|
||
assert normalize_spaces(page.select_one('.banner-dangerous').text) == (
|
||
'There is a problem with example.xlsx '
|
||
'You need to enter missing data in 1 row '
|
||
'Skip to file contents'
|
||
)
|
||
|
||
|
||
def test_check_messages_column_error_doesnt_show_optional_columns(
|
||
mocker,
|
||
client_request,
|
||
mock_get_service_letter_template,
|
||
mock_has_permissions,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
):
|
||
|
||
mocker.patch('app.main.views.send.s3download', return_value='\n'.join(
|
||
['address_line_1,address_line_2,foo'] +
|
||
['First Lastname,1 Example Road,SW1 1AA']
|
||
))
|
||
|
||
with client_request.session_transaction() as session:
|
||
session['upload_data'] = {'template_id': '', 'original_file_name': ''}
|
||
|
||
page = client_request.get(
|
||
'main.check_messages',
|
||
service_id=SERVICE_ONE_ID,
|
||
template_type='letter',
|
||
upload_id=uuid.uuid4(),
|
||
_test_page_title=False,
|
||
)
|
||
|
||
assert normalize_spaces(page.select_one('.banner-dangerous').text) == (
|
||
'Your file needs columns called ‘address line 1’, ‘address line 2’ and ‘postcode’ '
|
||
'Right now it has columns called ‘address_line_1’, ‘address_line_2’ and ‘foo’. '
|
||
'Skip to file contents'
|
||
)
|
||
|
||
|
||
def test_generate_test_letter_doesnt_block_in_trial_mode(
|
||
client_request,
|
||
mocker,
|
||
mock_get_service,
|
||
mock_get_service_letter_template,
|
||
mock_has_permissions,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
):
|
||
|
||
mocker.patch('app.main.views.send.s3download', return_value="""
|
||
address_line_1,address_line_2,postcode,
|
||
First Last, 123 Street, SW1 1AA
|
||
""")
|
||
|
||
with client_request.session_transaction() as session:
|
||
session['upload_data'] = {'template_id': ''}
|
||
|
||
page = client_request.get(
|
||
'main.check_messages',
|
||
service_id=SERVICE_ONE_ID,
|
||
template_type='letter',
|
||
upload_id=uuid.uuid4(),
|
||
from_test=True,
|
||
_test_page_title=False,
|
||
)
|
||
|
||
assert not page.select('.banner-dangerous')
|
||
|
||
assert page.select_one('a.button').text == 'Download as a printable PDF'
|
||
|
||
|
||
def test_check_messages_shows_over_max_row_error(
|
||
logged_in_client,
|
||
api_user_active,
|
||
mock_login,
|
||
mock_get_users_by_service,
|
||
mock_get_service,
|
||
mock_get_service_template_with_placeholders,
|
||
mock_has_permissions,
|
||
mock_get_detailed_service_for_today,
|
||
mock_s3_download,
|
||
fake_uuid,
|
||
mocker
|
||
):
|
||
mock_recipients = mocker.patch('app.main.views.send.RecipientCSV').return_value
|
||
mock_recipients.max_rows = 11111
|
||
mock_recipients.__len__.return_value = 99999
|
||
mock_recipients.too_many_rows.return_value = True
|
||
|
||
with logged_in_client.session_transaction() as session:
|
||
session['upload_data'] = {'template_id': fake_uuid}
|
||
response = logged_in_client.get(url_for(
|
||
'main.check_messages',
|
||
service_id=fake_uuid,
|
||
template_type='sms',
|
||
upload_id=fake_uuid
|
||
))
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
assert ' '.join(
|
||
page.find('div', class_='banner-dangerous').text.split()
|
||
) == (
|
||
'Your file has too many rows '
|
||
'Notify can process up to 11,111 rows at once. '
|
||
'Your file has 99,999 rows. '
|
||
'Skip to file contents'
|
||
)
|
||
|
||
|
||
def test_non_ascii_characters_in_letter_recipients_file_shows_error(
|
||
logged_in_client,
|
||
api_user_active,
|
||
mock_login,
|
||
mock_get_users_by_service,
|
||
mock_get_live_service,
|
||
mock_has_permissions,
|
||
mock_get_service_letter_template,
|
||
mock_get_detailed_service_for_today,
|
||
fake_uuid,
|
||
mocker
|
||
):
|
||
from tests.conftest import mock_s3_download
|
||
mock_s3_download(
|
||
mocker,
|
||
content=u"""
|
||
address line 1,address line 2,address line 3,address line 4,address line 5,address line 6,postcode
|
||
Петя,345 Example Street,,,,,AA1 6BB
|
||
"""
|
||
)
|
||
|
||
with logged_in_client.session_transaction() as session:
|
||
session['upload_data'] = {
|
||
'template_id': fake_uuid,
|
||
'original_file_name': 'unicode.csv',
|
||
}
|
||
|
||
response = logged_in_client.get(url_for(
|
||
'main.check_messages',
|
||
service_id=fake_uuid,
|
||
template_type='letter',
|
||
upload_id=fake_uuid
|
||
))
|
||
|
||
assert response.status_code == 200
|
||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||
assert ' '.join(
|
||
page.find('div', class_='banner-dangerous').text.split()
|
||
) == (
|
||
'There is a problem with unicode.csv '
|
||
'You need to fix 1 address '
|
||
'Skip to file contents'
|
||
)
|
||
assert page.find('span', class_='table-field-error-label').text == u'Can’t include П, е, т or я'
|
||
|
||
|
||
def test_check_messages_redirects_if_no_upload_data(logged_in_client, service_one):
|
||
response = logged_in_client.get(url_for(
|
||
'main.check_messages',
|
||
service_id=service_one['id'],
|
||
template_type='bar',
|
||
upload_id='baz'
|
||
))
|
||
|
||
assert response.status_code == 301
|
||
assert response.location == url_for('main.choose_template', service_id=service_one['id'], _external=True)
|
||
|
||
|
||
@pytest.mark.parametrize('existing_session_items', [
|
||
{},
|
||
{'recipient': '07700900001'},
|
||
{'name': 'Jo'}
|
||
])
|
||
def test_check_notification_redirects_if_session_not_populated(
|
||
logged_in_client,
|
||
service_one,
|
||
fake_uuid,
|
||
existing_session_items,
|
||
mock_get_service_template_with_placeholders
|
||
):
|
||
with logged_in_client.session_transaction() as session:
|
||
session.update(existing_session_items)
|
||
|
||
resp = logged_in_client.get(url_for(
|
||
'main.check_notification',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid
|
||
))
|
||
|
||
assert resp.location == url_for(
|
||
'main.view_template',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
_external=True
|
||
)
|
||
|
||
|
||
@pytest.mark.parametrize('existing_session_items', [
|
||
{},
|
||
{'recipient': '07700900001'},
|
||
{'name': 'Jo'}
|
||
])
|
||
def test_check_notification_redirects_with_help_if_session_not_populated(
|
||
logged_in_client,
|
||
service_one,
|
||
fake_uuid,
|
||
existing_session_items,
|
||
mock_get_service_template_with_placeholders
|
||
):
|
||
with logged_in_client.session_transaction() as session:
|
||
session.update(existing_session_items)
|
||
|
||
resp = logged_in_client.get(url_for(
|
||
'main.check_notification',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
help='2'
|
||
))
|
||
|
||
assert resp.location == url_for(
|
||
'main.send_test',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
help='2',
|
||
_external=True
|
||
)
|
||
|
||
|
||
def test_check_notification_shows_preview(
|
||
client_request,
|
||
service_one,
|
||
fake_uuid,
|
||
mock_get_service_template
|
||
):
|
||
with client_request.session_transaction() as session:
|
||
session['recipient'] = '07700900001'
|
||
session['placeholders'] = {}
|
||
|
||
page = client_request.get(
|
||
'main.check_notification',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid
|
||
)
|
||
|
||
assert page.h1.text.strip() == 'Preview of Two week reminder'
|
||
assert (
|
||
page.findAll('a', {'class': 'page-footer-back-link'})[0]['href']
|
||
) == url_for('main.view_template', service_id=service_one['id'], template_id=fake_uuid)
|
||
|
||
# assert tour not visible
|
||
assert not page.select('.banner-tour')
|
||
assert page.form.attrs['action'] == url_for(
|
||
'main.send_notification',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
help='0'
|
||
)
|
||
|
||
|
||
def test_check_notification_shows_help(
|
||
client_request,
|
||
service_one,
|
||
fake_uuid,
|
||
mock_get_service_template
|
||
):
|
||
with client_request.session_transaction() as session:
|
||
session['recipient'] = '07700900001'
|
||
session['placeholders'] = {}
|
||
|
||
page = client_request.get(
|
||
'main.check_notification',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
help='2'
|
||
)
|
||
assert page.select_one('.banner-tour')
|
||
assert page.form.attrs['action'] == url_for(
|
||
'main.send_notification',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
help='3'
|
||
)
|
||
assert page.select_one('.page-footer-back-link')['href'] == url_for(
|
||
'main.send_test',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
help='2'
|
||
)
|
||
|
||
|
||
def test_send_notification_submits_data(
|
||
client_request,
|
||
service_one,
|
||
fake_uuid,
|
||
mock_send_notification,
|
||
):
|
||
with client_request.session_transaction() as session:
|
||
session['recipient'] = '07700900001'
|
||
session['placeholders'] = {'a': 'b'}
|
||
|
||
client_request.post(
|
||
'main.send_notification',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid
|
||
)
|
||
|
||
mock_send_notification.assert_called_once_with(
|
||
service_one['id'],
|
||
template_id=fake_uuid,
|
||
recipient='07700900001',
|
||
personalisation={'a': 'b'},
|
||
sender_id=None
|
||
)
|
||
|
||
|
||
def test_send_notification_clears_session(
|
||
client_request,
|
||
service_one,
|
||
fake_uuid,
|
||
mock_send_notification,
|
||
):
|
||
with client_request.session_transaction() as session:
|
||
session['recipient'] = '07700900001'
|
||
session['placeholders'] = {'a': 'b'}
|
||
|
||
client_request.post(
|
||
'main.send_notification',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid
|
||
)
|
||
|
||
with client_request.session_transaction() as session:
|
||
assert 'recipient' not in session
|
||
assert 'placeholders' not in session
|
||
|
||
|
||
def test_send_notification_redirects_if_missing_data(
|
||
logged_in_client,
|
||
service_one,
|
||
fake_uuid,
|
||
):
|
||
with logged_in_client.session_transaction() as session:
|
||
session['placeholders'] = {'a': 'b'}
|
||
|
||
resp = logged_in_client.post(
|
||
url_for('main.send_notification', service_id=service_one['id'], template_id=fake_uuid)
|
||
)
|
||
|
||
assert resp.status_code == 302
|
||
assert resp.location == url_for(
|
||
'.send_one_off',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
_external=True
|
||
)
|
||
|
||
|
||
@pytest.mark.parametrize('extra_args, extra_redirect_args', [
|
||
({}, {}),
|
||
({'help': '3'}, {'help': '3'})
|
||
])
|
||
def test_send_notification_redirects_to_view_page(
|
||
logged_in_client,
|
||
service_one,
|
||
fake_uuid,
|
||
mock_send_notification,
|
||
extra_args,
|
||
extra_redirect_args
|
||
):
|
||
with logged_in_client.session_transaction() as session:
|
||
session['recipient'] = '07700900001'
|
||
session['placeholders'] = {'a': 'b'}
|
||
|
||
resp = logged_in_client.post(
|
||
url_for('main.send_notification', service_id=service_one['id'], template_id=fake_uuid, **extra_args)
|
||
)
|
||
|
||
assert resp.status_code == 302
|
||
assert resp.location == url_for(
|
||
'.view_notification',
|
||
service_id=service_one['id'],
|
||
notification_id=fake_uuid,
|
||
_external=True,
|
||
**extra_redirect_args
|
||
)
|
||
|
||
|
||
TRIAL_MODE_MSG = (
|
||
'Can’t send to this recipient when service is in trial mode – '
|
||
'see https://www.notifications.service.gov.uk/trial-mode'
|
||
)
|
||
TOO_LONG_MSG = 'Content for template has a character count greater than the limit of 495'
|
||
SERVICE_DAILY_LIMIT_MSG = 'Exceeded send limits (1000) for today'
|
||
|
||
|
||
@pytest.mark.parametrize('exception_msg, expected_h1, expected_err_details', [
|
||
(
|
||
TRIAL_MODE_MSG,
|
||
'You can’t send to this phone number',
|
||
'In trial mode you can only send to yourself and members of your team'
|
||
),
|
||
(
|
||
TOO_LONG_MSG,
|
||
'Message too long',
|
||
'Text messages can’t be longer than 459 characters. Your message is 554 characters.'
|
||
),
|
||
(
|
||
SERVICE_DAILY_LIMIT_MSG,
|
||
'Daily limit reached',
|
||
'You can only send 1000 messages per day in trial mode.'
|
||
),
|
||
])
|
||
def test_send_notification_shows_error_if_400(
|
||
client_request,
|
||
service_one,
|
||
fake_uuid,
|
||
mocker,
|
||
mock_get_service_template_with_placeholders,
|
||
exception_msg,
|
||
expected_h1,
|
||
expected_err_details
|
||
):
|
||
|
||
class MockHTTPError(HTTPError):
|
||
message = exception_msg
|
||
|
||
mocker.patch(
|
||
'app.notification_api_client.send_notification',
|
||
side_effect=MockHTTPError(),
|
||
)
|
||
with client_request.session_transaction() as session:
|
||
session['recipient'] = '07700900001'
|
||
session['placeholders'] = {'name': 'a' * 500}
|
||
|
||
page = client_request.post(
|
||
'main.send_notification',
|
||
service_id=service_one['id'],
|
||
template_id=fake_uuid,
|
||
_expected_status=200
|
||
)
|
||
|
||
assert normalize_spaces(page.select('.banner-dangerous h1')[0].text) == expected_h1
|
||
assert normalize_spaces(page.select('.banner-dangerous p')[0].text) == expected_err_details
|
||
assert not page.find('input[type=submit]')
|
||
|
||
|
||
def test_send_notification_shows_email_error_in_trial_mode(
|
||
client_request,
|
||
fake_uuid,
|
||
mocker,
|
||
mock_get_service_email_template,
|
||
):
|
||
class MockHTTPError(HTTPError):
|
||
message = TRIAL_MODE_MSG
|
||
status_code = 400
|
||
|
||
mocker.patch(
|
||
'app.notification_api_client.send_notification',
|
||
side_effect=MockHTTPError(),
|
||
)
|
||
with client_request.session_transaction() as session:
|
||
session['recipient'] = 'test@example.com'
|
||
session['placeholders'] = {'date': 'foo', 'thing': 'bar'}
|
||
|
||
page = client_request.post(
|
||
'main.send_notification',
|
||
service_id=SERVICE_ONE_ID,
|
||
template_id=fake_uuid,
|
||
_expected_status=200,
|
||
)
|
||
|
||
assert normalize_spaces(page.select('.banner-dangerous h1')[0].text) == (
|
||
'You can’t send to this email address'
|
||
)
|
||
assert normalize_spaces(page.select('.banner-dangerous p')[0].text) == (
|
||
'In trial mode you can only send to yourself and members of your team'
|
||
)
|
||
|
||
|
||
@pytest.mark.parametrize('endpoint, extra_args', [
|
||
('main.check_messages', {'template_type': 'email', 'upload_id': fake_uuid()}),
|
||
('main.send_one_off_step', {'template_id': fake_uuid(), 'step_index': 0}),
|
||
])
|
||
@pytest.mark.parametrize('reply_to_address', [
|
||
None,
|
||
fake_uuid(),
|
||
])
|
||
def test_reply_to_is_previewed_if_chosen(
|
||
client_request,
|
||
mocker,
|
||
mock_get_service_email_template,
|
||
mock_s3_download,
|
||
mock_get_users_by_service,
|
||
mock_get_detailed_service_for_today,
|
||
get_default_reply_to_email_address,
|
||
endpoint,
|
||
extra_args,
|
||
reply_to_address,
|
||
):
|
||
|
||
mocker.patch('app.main.views.send.s3download', return_value="""
|
||
email_address,date,thing
|
||
notify@digital.cabinet-office.gov.uk,foo,bar
|
||
""")
|
||
|
||
with client_request.session_transaction() as session:
|
||
session['recipient'] = 'notify@digital.cabinet-office.gov.uk'
|
||
session['placeholders'] = {}
|
||
session['upload_data'] = {
|
||
'original_file_name': 'example.csv',
|
||
'template_id': fake_uuid(),
|
||
'notification_count': 1,
|
||
'valid': True
|
||
}
|
||
session['sender_id'] = reply_to_address
|
||
|
||
page = client_request.get(
|
||
endpoint,
|
||
service_id=SERVICE_ONE_ID,
|
||
**extra_args
|
||
)
|
||
|
||
email_meta = page.select_one('.email-message-meta').text
|
||
|
||
if reply_to_address:
|
||
assert 'test@example.com' in email_meta
|
||
else:
|
||
assert 'test@example.com' not in email_meta
|