mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-07-23 17:39:13 -04:00
1e46922876
This commit parameterises all methods in the send view so that they can send either emails or SMS messages. It works out what kind of message it is sending from the `template_type` property of the template object. This means that the `Template` util class needs to know about these properties, which means that this commit depends on: https://github.com/alphagov/notifications-utils/pull/2 This commit does _not_ add tests for sending emails. The existing tests for sending SMS still pass, but actually sending emails is outside the scope of this story.
209 lines
6.7 KiB
Python
209 lines
6.7 KiB
Python
from io import BytesIO
|
||
from flask import url_for
|
||
|
||
import pytest
|
||
import moto
|
||
|
||
template_types = ['email', 'sms']
|
||
|
||
|
||
@pytest.mark.parametrize("template_type", template_types)
|
||
def test_choose_template(
|
||
template_type,
|
||
app_,
|
||
api_user_active,
|
||
mock_login,
|
||
mock_get_user,
|
||
mock_get_service,
|
||
mock_check_verify_code,
|
||
mock_get_service_templates,
|
||
mock_get_jobs
|
||
):
|
||
with app_.test_request_context():
|
||
with app_.test_client() as client:
|
||
client.login(api_user_active)
|
||
response = client.get(url_for('main.choose_template', template_type=template_type, service_id=12345))
|
||
|
||
assert response.status_code == 200
|
||
content = response.get_data(as_text=True)
|
||
assert '{}_template_one'.format(template_type) in content
|
||
assert '{} template one content'.format(template_type) in content
|
||
assert '{}_template_two'.format(template_type) in content
|
||
assert '{} template two content'.format(template_type) in content
|
||
|
||
|
||
def test_upload_empty_csvfile_returns_to_upload_page(
|
||
app_,
|
||
api_user_active,
|
||
mock_login,
|
||
mock_get_user,
|
||
mock_get_service,
|
||
mock_get_service_templates,
|
||
mock_check_verify_code,
|
||
mock_get_service_template
|
||
):
|
||
with app_.test_request_context():
|
||
with app_.test_client() as client:
|
||
client.login(api_user_active)
|
||
upload_data = {'file': (BytesIO(''.encode('utf-8')), 'emtpy.csv')}
|
||
response = client.post(
|
||
url_for('main.send_messages', service_id=12345, template_id=54321),
|
||
data=upload_data,
|
||
follow_redirects=True
|
||
)
|
||
|
||
assert response.status_code == 200
|
||
content = response.get_data(as_text=True)
|
||
assert 'The file emtpy.csv contained no data' in content
|
||
|
||
|
||
@moto.mock_s3
|
||
def test_upload_csvfile_with_invalid_phone_shows_check_page_with_errors(
|
||
app_,
|
||
mocker,
|
||
api_user_active,
|
||
mock_login,
|
||
mock_get_user,
|
||
mock_get_user_by_email,
|
||
mock_get_service_template
|
||
):
|
||
|
||
contents = 'phone\n+44 123\n+44 456'
|
||
file_data = (BytesIO(contents.encode('utf-8')), 'invalid.csv')
|
||
|
||
with app_.test_request_context():
|
||
with app_.test_client() as client:
|
||
client.login(api_user_active)
|
||
upload_data = {'file': file_data}
|
||
response = client.post(
|
||
url_for('main.send_messages', service_id=12345, template_id=54321),
|
||
data=upload_data,
|
||
follow_redirects=True
|
||
)
|
||
assert response.status_code == 200
|
||
content = response.get_data(as_text=True)
|
||
assert 'Your CSV file contained missing or invalid data' in content
|
||
assert '+44 123' in content
|
||
assert '+44 456' in content
|
||
assert 'Upload a CSV file' in content
|
||
|
||
|
||
@moto.mock_s3
|
||
def test_send_test_message_to_self(
|
||
app_,
|
||
mocker,
|
||
api_user_active,
|
||
mock_login,
|
||
mock_get_user,
|
||
mock_get_user_by_email,
|
||
mock_get_service_template
|
||
):
|
||
|
||
with app_.test_request_context():
|
||
with app_.test_client() as client:
|
||
client.login(api_user_active)
|
||
response = client.get(
|
||
url_for('main.send_message_to_self', service_id=12345, template_id=54321),
|
||
follow_redirects=True
|
||
)
|
||
assert response.status_code == 200
|
||
content = response.get_data(as_text=True)
|
||
assert 'Test run' in content
|
||
assert '+4412341234' in content
|
||
|
||
|
||
@moto.mock_s3
|
||
def test_download_example_csv(
|
||
app_,
|
||
mocker,
|
||
api_user_active,
|
||
mock_login,
|
||
mock_get_user,
|
||
mock_get_user_by_email,
|
||
mock_get_service_template
|
||
):
|
||
|
||
with app_.test_request_context():
|
||
with app_.test_client() as client:
|
||
client.login(api_user_active)
|
||
response = client.get(
|
||
url_for('main.get_example_csv', service_id=12345, template_id=54321),
|
||
follow_redirects=True
|
||
)
|
||
assert response.status_code == 200
|
||
assert response.get_data(as_text=True) == 'phone\r\n+4412341234\r\n'
|
||
assert 'text/csv' in response.headers['Content-Type']
|
||
|
||
|
||
@moto.mock_s3
|
||
def test_upload_csvfile_with_valid_phone_shows_all_numbers(
|
||
app_,
|
||
mocker,
|
||
api_user_active,
|
||
mock_login,
|
||
mock_get_user,
|
||
mock_get_user_by_email,
|
||
mock_get_service_template
|
||
):
|
||
|
||
contents = 'phone\n+44 7700 900981\n+44 7700 900982\n+44 7700 900983\n+44 7700 900984\n+44 7700 900985\n+44 7700 900986' # noqa
|
||
|
||
file_data = (BytesIO(contents.encode('utf-8')), 'valid.csv')
|
||
|
||
with app_.test_request_context():
|
||
with app_.test_client() as client:
|
||
client.login(api_user_active)
|
||
upload_data = {'file': file_data}
|
||
response = client.post(url_for('main.send_messages', service_id=12345, template_id=54321),
|
||
data=upload_data,
|
||
follow_redirects=True)
|
||
with client.session_transaction() as sess:
|
||
assert int(sess['upload_data']['template_id']) == 54321
|
||
assert sess['upload_data']['original_file_name'] == 'valid.csv'
|
||
assert sess['upload_data']['notification_count'] == 6
|
||
|
||
content = response.get_data(as_text=True)
|
||
|
||
assert response.status_code == 200
|
||
assert '+44 7700 900981' in content
|
||
assert '+44 7700 900982' in content
|
||
assert '+44 7700 900983' in content
|
||
assert '+44 7700 900984' in content
|
||
assert '+44 7700 900985' in content
|
||
assert '+44 7700 900986' in content
|
||
|
||
|
||
@moto.mock_s3
|
||
def test_create_job_should_call_api(
|
||
app_,
|
||
service_one,
|
||
api_user_active,
|
||
mock_get_user,
|
||
mock_get_user_by_email,
|
||
mock_login,
|
||
job_data,
|
||
mock_create_job,
|
||
mock_get_job,
|
||
mock_get_service_template
|
||
):
|
||
|
||
service_id = service_one['id']
|
||
job_id = job_data['id']
|
||
original_file_name = job_data['original_file_name']
|
||
template_id = job_data['template']
|
||
notification_count = job_data['notification_count']
|
||
|
||
with app_.test_request_context():
|
||
with app_.test_client() as client:
|
||
client.login(api_user_active)
|
||
with client.session_transaction() as session:
|
||
session['upload_data'] = {'original_file_name': original_file_name,
|
||
'template_id': template_id,
|
||
'notification_count': notification_count}
|
||
url = url_for('main.check_messages', service_id=service_one['id'], upload_id=job_id)
|
||
response = client.post(url, data=job_data, follow_redirects=True)
|
||
|
||
assert response.status_code == 200
|
||
assert 'We’ve started sending your messages' in response.get_data(as_text=True)
|
||
mock_create_job.assert_called_with(job_id, service_id, template_id, original_file_name, notification_count)
|