mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-02-05 10:53:28 -05:00
45cacd82d3
This commit extends the existing function to validate each row’s phone number to also validate that all the required data is present. It does this using the checking that the `Template` class can do when given a template and a `dict` of values.
69 lines
1.8 KiB
Python
69 lines
1.8 KiB
Python
from app.utils import (
|
|
validate_phone_number,
|
|
InvalidPhoneError
|
|
)
|
|
|
|
import pytest
|
|
|
|
valid_phone_numbers = [
|
|
'07123456789',
|
|
'07123 456789',
|
|
'07123-456-789',
|
|
'00447123456789',
|
|
'00 44 7123456789',
|
|
'+447123456789',
|
|
'+44 7123 456 789',
|
|
'+44 (0)7123 456 789'
|
|
]
|
|
|
|
invalid_phone_numbers = sum([
|
|
[
|
|
(phone_number, error) for phone_number in group
|
|
] for error, group in [
|
|
('Too many digits', (
|
|
'0712345678910',
|
|
'0044712345678910',
|
|
'0044712345678910',
|
|
'+44 (0)7123 456 789 10',
|
|
)),
|
|
('Not enough digits', (
|
|
'0712345678',
|
|
'004471234567',
|
|
'00447123456',
|
|
'+44 (0)7123 456 78',
|
|
)),
|
|
('Must be a UK mobile number (eg 07700 900460)', (
|
|
'08081 570364',
|
|
'+44 8081 570364',
|
|
'0117 496 0860',
|
|
'+44 117 496 0860',
|
|
'020 7946 0991',
|
|
'+44 20 7946 0991',
|
|
'71234567890',
|
|
)),
|
|
('Must not contain letters or symbols', (
|
|
'07890x32109',
|
|
'07123 456789...',
|
|
'07123 ☟☜⬇⬆☞☝',
|
|
'07123☟☜⬇⬆☞☝',
|
|
'07";DROP TABLE;"',
|
|
'+44 07ab cde fgh',
|
|
))
|
|
]
|
|
], [])
|
|
|
|
|
|
@pytest.mark.parametrize("phone_number", valid_phone_numbers)
|
|
def test_phone_number_accepts_valid_values(phone_number):
|
|
try:
|
|
validate_phone_number(phone_number)
|
|
except InvalidPhoneError:
|
|
pytest.fail('Unexpected InvalidPhoneError')
|
|
|
|
|
|
@pytest.mark.parametrize("phone_number, error_message", invalid_phone_numbers)
|
|
def test_phone_number_rejects_invalid_values(phone_number, error_message):
|
|
with pytest.raises(InvalidPhoneError) as e:
|
|
validate_phone_number(phone_number)
|
|
assert error_message == str(e.value)
|