mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-06-21 21:53:42 -04:00
08cb4a2576
Previously each navigation class had a list of endpoint to "exclude", which was only used in tests to ensure that all endpoints in the app were covered: either they are present in navigation, or excluded. However, over time the "exclude" lists have grown long and repetitive, and maintaining each of them individually adds extra work [1][2]. This switches to a more DRY approach, where the list of excluded endpoints is defined once, close to the single point of use in the test. Note the resulting test is _slightly_ less prescriptive, as it will now pass if an endpoint exist one in navigation, even if it should also exist in another. This seems a reasonable compromise. [1]: https://github.com/alphagov/notifications-admin/pull/3788/files#r572809972 [2]: https://github.com/alphagov/notifications-admin/pull/3794/files#diff-39387df3a9f89b313976957e7b5457be20deab1017b2d895541b142b957f1972