darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-05-31 19:40:15 -04:00
Code Issues Packages Projects Releases Wiki Activity
5,963 Commits 58 Branches 59 Tags
f2df914dc12d6998b5956aa59b9f04b668e02bac
Commit Graph

3942 Commits

Author SHA1 Message Date
Chris Hill-Scott
d68cc68def Make page title semi-consistent 
We tend to use ‘Add’ rather than ‘Create’ in other places.
 2018-08-23 09:52:50 +01:00
Chris Hill-Scott
9b9acfa291 Select a branding with a link, not form 
Selecting a branding just takes you to a new page, it doesn’t change
any state.

Links are generally the way you go from one page to another on the web.
 2018-08-23 09:52:50 +01:00
Chris Hill-Scott
1e28fe4ffd Remove redundant argument 
This `branding_dict` is not used in the Jinja template anywhere.
 2018-08-23 09:51:33 +01:00
Chris Hill-Scott
0e7ed2b0cf Put ‘add new’ button at top of page 
One of the most frequent tasks done on this page is adding a new
branding.

Current to do this you have to:
- scroll to the bottom
- scan for the ‘Create a new email branding’ option that visually looks
  just like all the other brandings
- submit a form

This commit makes change it to one clearly differentiated button at the
top of the page. This is consistent for how we let users add templates
and team members.
 2018-08-23 09:49:23 +01:00
Tom Byers
cff43abfc6 Add live-search to /email-branding page 2018-08-22 19:03:46 +01:00
Tom Byers
3ea94128c6 Add live-search to set-email-branding page 2018-08-22 19:03:38 +01:00
Tom Byers
47798b218c Make live-search into a component 2018-08-22 17:42:04 +01:00
Chris Hill-Scott
3483490f03 Fix colour preview not loading on page load 
The event was changed from `change` to `input`. The trigger was not updated accordingly.
 2018-08-22 16:51:16 +01:00
Chris Hill-Scott
b10f0747ae Use input event not keyup 
The `oninput` event is a more performant way to detect changes to a
textbox’s contents (compared to `onkeydown`, `onpaste`, etc).

It’s not supported in older browsers, but since this is a likely to be
used by platform admin users only that’s OK.
 2018-08-22 16:31:05 +01:00
Chris Hill-Scott
6501105768 Refactor to not repeat lots of Jinja code 2018-08-22 16:31:05 +01:00
Chris Hill-Scott
b73e42650d Refactor hex colour preview Javascript 
This commit improves the code that previews a hex colour when setting up
or changing an email branding.

Specifically it:
- refactors the Javascript to conform to our patterns (module pattern,
  preprocessed with Gulp)
- makes the code work when there are multiple colour previews on one
  page

It also does some visual prettifying, because I couldn’t help myself…
 2018-08-22 16:31:05 +01:00
Chris Hill-Scott
864e732c38 Merge pull request #2241 from alphagov/add-colours-and-domain-to-email-branding 
New columns for email branding
 2018-08-22 16:29:42 +01:00
Rebecca Law
473c8378fc Created a method to decide which colour to pass into the notifications-utils method to preview the template. 
Removed the ServiceCreateEmailBranding form - it is identical to the other form.
 2018-08-22 12:56:08 +01:00
Chris Hill-Scott
7530fbf731 Fix the tests and catch a few more examples 2018-08-20 18:05:46 +01:00
karlchillmaid
36e8a9b3cc Corrected the page title 
Corrected the page title to 'Data retention'
 2018-08-20 16:59:35 +01:00
karlchillmaid
60f64ee5e5 'Email reply-to address' updated 
Updated 'reply-to address' to include a hyphen
 2018-08-20 16:50:56 +01:00
karlchillmaid
e18f1727d1 'Email reply-to addresses' updated 
Updated 'reply-to address' to include a hyphen
 2018-08-20 16:48:21 +01:00
karlchillmaid
2c635faf5f 'Email reply-to address' updated 
Updated 'reply-to address' to include a hyphen
 2018-08-20 16:46:28 +01:00
karlchillmaid
15ed2e624a 'Email reply-to address' updated 
Updated 'reply-to address' to include a hyphen
 2018-08-20 16:45:08 +01:00
karlchillmaid
fb717e6933 'Email reply-to address' updated 
Updated 'reply-to address' to include a hyphen
 2018-08-20 16:43:42 +01:00
karlchillmaid
abed956a5a 'Email reply-to address' label change 
Updated 'reply-to address' to include a hyphen
 2018-08-20 16:41:16 +01:00
Rebecca Law
3fda171f80 New columns for email branding 
Added banner_colour, single_id_colour and domain to email branding view. Now able to set the fields.

However, the new fields are not being used yet.
 2018-08-20 13:27:17 +01:00
fidejoseph
3fbe85cdf8 Update email_domains.yml 
update: hscni.net
 2018-08-20 12:14:03 +01:00
Pete Herlihy
bbccbd8784 Adding derrystrabane.com (local council) 
For *reasons* they've gone with dot com addresses.
 2018-08-17 15:12:24 +01:00
Katie Smith
43e3ddb73a Merge pull request #2233 from alphagov/increase-sms-length 
Increase SMS maximum length from 459 to 612
 2018-08-17 14:03:29 +01:00
Katie Smith
6b5eaf7fff Improve number formatting on platform-admin page 
Minor changes to the number formatting for the `/platform-admin` page to
- Show the complaint percentage to 2 decimal places. (The number of
complaints is often below 0.0% so 1 decimal place isn't useful)
- Format the numbers in the status boxes to use a comma as a thousands
separator.
 2018-08-16 16:57:02 +01:00
Katie Smith
1b6c357dea Use new value of SMS_CHAR_COUNT_LIMIT from utils 
Admin, API and utils were all defining a value for SMS_CHAR_COUNT_LIMIT.
This value has been updated in notifications-utils to allow text
messages to be 4 fragments long and notifications-admin now gets the value of
SMS_CHAR_COUNT_LIMIT from notifications-utils instead of defining it in
config.
 2018-08-16 16:56:32 +01:00
Tom Byers
6249f4826b Merge pull request #2235 from alphagov/sort-branding-radios-alphabetically 
Sort branding radios alphabetically
 2018-08-16 16:49:12 +01:00
Alexey Bezhan
3a00574034 Merge pull request #2224 from alphagov/notifications-page-data-retention-period 
Notifications page data retention period
 2018-08-16 13:55:55 +01:00
Tom Byers
f85a9306a6 Move brandings sort into email_branding_client 2018-08-16 13:40:24 +01:00
Pete Herlihy
d5bd220378 Adding fire-uk.org to the list of domains 2018-08-15 16:35:59 +01:00
Tom Byers
853f13c70b Sort email branding selection alphabetically 
For branding combinations in service settings and
branding creation/editing in platform admin.
 2018-08-15 16:13:27 +01:00
Sakis
85ec7a28cb Merge pull request #2231 from alphagov/zipkin-headers 
Both trace_id and span_id headers must be present
 2018-08-15 16:10:09 +01:00
Tom Byers
6b0d79ad72 Stop email preview showing brand name 
This is a leftover from when email brands didn't
have a 'text' field.

It also adds some tests to check the brand name
is displaying correctly.
 2018-08-15 13:52:17 +01:00
Athanasios Voutsadakis
984e09cc6a Both trace_id and span_id headers must be present 2018-08-14 18:12:06 +01:00
Tom Byers
8ba8606963 Merge pull request #2230 from alphagov/add-branding-name-to-ui 
Show the 'name' of the email branding in the adding and editing screens
 2018-08-14 16:05:56 +01:00
Rebecca Law
2e98c9c562 Merge pull request #2225 from alphagov/308-331 
Updated count of services and orgs
 2018-08-14 15:58:00 +01:00
Tom Byers
fafe03e9f0 Remove unused imports for branding_radio macro 
Found while grepping for use of the branding_radio
macro.
 2018-08-14 14:18:16 +01:00
Tom Byers
f6642aa6e3 Remove branding_radios macro 
No longer used by any template so remove.

(It'll still be in the history if we need it.)
 2018-08-14 14:18:16 +01:00
Tom Byers
7c398a8a2f Update style radios for choosing brand combination 
They were already using the 'name' field in their
label but we don't want any other part of the
branding to appear now.
 2018-08-14 14:18:16 +01:00
Tom Byers
1269071da2 Add 'name' field to brand creation/edit page 2018-08-14 14:18:16 +01:00
Tom Byers
eb64033ff3 Update selection radios before edit/create new 
They were already using the 'name' field in their
label but we don't want any other part of the
branding to appear now.
 2018-08-14 14:18:16 +01:00
Sakis
54304a3498 Merge pull request #2228 from alphagov/zipkin-headers 
Use the zipkin headers from utils version 30.0.0
 2018-08-14 14:15:09 +01:00
Athanasios Voutsadakis
6786ff8fde Use the zipkin headers from utils version 30.0.0 2018-08-14 13:20:21 +01:00
Katie Smith
5b7ca676b5 Make the new Ruby docs live 
The Ruby docs are now finished, so we can change the documentation link
to point to the new docs.
 2018-08-14 10:55:02 +01:00
Pete Herlihy
8e36efca55 Updated count of services and orgs 
Now 331 from 108 organisations.
 2018-08-14 10:30:37 +01:00
Alexey Bezhan
e3a0adc293 Use per-service data retention period to display notifications page 
Uses the configured service data retention page to display retention
period length, notification counts and fetch notifications from the
API on the notifications page.
 2018-08-13 17:07:49 +01:00
Alexey Bezhan
52d48ad679 Add API client method to fetch service data retention by type 2018-08-13 17:06:16 +01:00
Alexey Bezhan
28b03fe748 Add limit_days argument to statistics API client method 
Allows getting notification counts for a given number of days to
support services with custom data retention periods (admin
dashboard page should still display counts for the last 7 days,
while the notifications page displays all stored notifications).
 2018-08-13 17:04:40 +01:00
Katie Smith
a978a2fbe5 Refactor contact link template 2018-08-13 13:40:03 +01:00