4 Commits

Author	SHA1	Message	Date
Ben Thorner	fa3e6435a6	Fix small issues identified in PR review ... In response to: [^1], [^2], [^3], [^4], [^5] and [^6]. [^1]: https://github.com/alphagov/notifications-admin/pull/4182#discussion_r825824485 [^2]: https://github.com/alphagov/notifications-admin/pull/4182#discussion_r825824805 [^3]: https://github.com/alphagov/notifications-admin/pull/4182#discussion_r825857745 [^4]: https://github.com/alphagov/notifications-admin/pull/4182#discussion_r825859850 [^5]: https://github.com/alphagov/notifications-admin/pull/4182#discussion_r825859982 [^6]: https://github.com/alphagov/notifications-admin/pull/4182#discussion_r826001823	2022-03-15 11:47:21 +00:00
Ben Thorner	857b8b04b0	Duplicate tests for options with branding set ... This is a step towards further refactoring of the page tests, which don't need to check in this level of detail anymore.	2022-03-15 11:47:20 +00:00
Ben Thorner	5a39e310aa	Migrate two more tests to the branding utility ... All of the mock / UI assertions in these tests are covered by the tests above them - these tests were mostly targetting which options were being shown, which we can check at a lower level.	2022-03-15 11:47:19 +00:00
Ben Thorner	1946d3c928	Migrate two branding tests to utils module ... This is much simpler than trying to test the function via the page, although there are still two scenarios to test there: - The page with radio buttons (using NHS as an example). - The page with a text form (using "other" as an example). In future work we could split this test in two to make it clearer what it's trying to test. For now, this keeps the diff simple.	2022-03-15 11:47:18 +00:00