4 Commits

Author	SHA1	Message	Date
Leo Hemsted	bbeb3595a8	update tests to work with new correct logged_in_client fixtures ... mostly making sure that the correct user is set up. some minor changes, such as giving the platform_admin service permissions (so that we can test that platform admins can send letters)	2017-02-17 09:44:53 +00:00
Chris Hill-Scott	929dc45224	Normalize whitespace in test arguments ... We have a bunch of different styles of handling when function definitions span multiple lines, which they almost always do with tests. Here’s why an argument per line, single indent is best: - cleaner diffs when you change the name of a method (one line change instead of multiple lines) - works better on narrow screens, eg Github’s diff view, or with two terminals side by side on a laptop screen - works with any editor’s indenting shortcuts, no need for an IDE Also, trailing comma in the list of arguments is good because adding a new argument to a method becomes a one line, not two line diff.	2017-02-06 10:44:37 +00:00
Leo Hemsted	93cdaf1811	allow users to see letters even if they dont have edit permissions ... same way as we handle seeing emails/sms	2016-10-31 18:01:31 +00:00
Leo Hemsted	f039397533	make letters error if user not logged in ... also added tests for the various hiding logic points also added new logged_in_client in conftest - so you dont need to patch all those stupid API calls for get user and get service	2016-10-27 16:46:51 +01:00