8 Commits

Author	SHA1	Message	Date
Ben Thorner	c17d438de8	DRY-up email revalidation check ... Previously this was duplicated between the "two_factor" and the "webauthn" views, and required more test setup. This DRYs up the check and tests it once, using mocks to simplify the view tests. As part of DRYing up the check into a util module, I've also moved the "is_less_than_days_ago" function it uses.	2021-06-14 12:52:54 +01:00
Ben Thorner	bf2e6802bf	Extract login utils out of two_factor view ... This better reflects how the code is reused in other views and is not specific to two factor actions. We have a pattern of testing utility functionality for each view (as opposed to testing the util + the view calls the util), so I'm leaving the tests as-is.	2021-06-14 11:19:06 +01:00
Ben Thorner	3250f2b3ed	Move redirect_to_signin helper to new util module ... We'll expand this module in later commits.	2021-06-14 11:09:42 +01:00
Ben Thorner	edb0b8214d	Move pagination utils into own module ... This continues the pattern established in [1], just to chip away a bit more at the random collection of stuff in utils/__init__.py. [1]: https://github.com/alphagov/notifications-admin/pull/3923	2021-06-14 11:00:05 +01:00
Ben Thorner	0326005aeb	Extract template / csv utility code into modules ... This follows a similar approach to the previous commits, noting that one module depends on the other, so we have to extract both together.	2021-06-09 15:19:00 +01:00
Ben Thorner	2a4aa8b4e1	Extract letter utility code into own module ... This provides more room for expansion, and reduces the amount of arbitrary code in the __init__.py file for the new package.	2021-06-09 13:59:06 +01:00
Ben Thorner	7c27646d6a	Extract user utility code into own module ... This provides more room for expansion, and reduces the amount of arbitrary code in the __init__.py file for the new package.	2021-06-09 13:19:05 +01:00
Ben Thorner	3f55c746aa	Turn utils into a module ... This provides more room for expansion, so we don't get another massive file to scroll through. We do also have some top-level files, such as "formatters.py", which we could consider moving under utils/ in future.	2021-06-09 12:50:01 +01:00