darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-25 02:19:12 -04:00
Code Issues Packages Projects Releases Wiki Activity
2,375 Commits 60 Branches 61 Tags
c745422578cdbf584e28c28482fbaabc7e90f548
Commit Graph

183 Commits

Author SHA1 Message Date
Martyn Inglis
d56c14e147 Actually use the right exception class. 
Two HTTPError classes exist. Need to use the one in notifications_python_client.
 2016-08-24 12:12:19 +01:00
Martyn Inglis
d149a9691a Added tests for the 2 use cases: 
used templates

unused templates
 2016-08-24 12:09:38 +01:00
Martyn Inglis
c44a6cb65d Merge branch 'master' into new-api-for-deleting-templates 2016-08-23 09:31:05 +01:00
Martyn Inglis
9d25f326b0 Using new endpoint for template statistics 
- gets notifications by template id, returning the most recent to illustrate the last use of that template.
 2016-08-22 16:25:35 +01:00
Martyn Inglis
55c4443a05 Admin app uses the new API response formats. 2016-08-18 15:30:57 +01:00
Leo Hemsted
bfcf4be447 separate branding/org test into two tests 
it's a bit more legible and the running time of these tests is
negligable so split up the test into its two logical components
 2016-08-16 14:46:59 +01:00
Chris Hill-Scott
6b5e64479a Add a page to set organisation and branding option 
Platform admin only.

Adds radio buttons to choose one of:
- three hard-coded branding options
- organisations from a list provided by the API
 2016-08-12 10:31:43 +01:00
Leo Hemsted
20c39d24b7 Merge pull request #863 from alphagov/allow-partial-service-updates 
Allow partial service updates from service API client
 2016-08-12 10:07:55 +01:00
Chris Hill-Scott
002b58a062 Make service API client do partial updates 
The service API client was updating every attribute of a service. Which,
while kinda clunky, is fine…

…until something calling it doesn’t pass in every attribute of the
current service. It was then defaulting optional parameters to `None`.
Which resulted in a bug whereby every time a service was set to live,
its `reply_to_address` and `sms_sender_name` got overwritten to be
empty.

This commit changes the `update` method to only require the service ID,
and pass whatever other named arguments it received straight through to
the API. The API handles partial updates just fine (I think).
 2016-08-11 17:07:33 +01:00
Leo Hemsted
6fc474a37f remove unused call to notification statistics 2016-08-11 12:07:50 +01:00
Leo Hemsted
3f3463b1ff Merge branch 'master' into remove-stats-from-send 2016-08-09 14:41:00 +01:00
Leo Hemsted
f2b6bfbfc2 Merge pull request #815 from alphagov/weekly-refactor 
Weekly stats aggregate page refactor
 2016-08-09 09:37:50 +01:00
Chris Hill-Scott
d0ef913520 Add a message if there are more than 50 rows 
Similar to how we do it on the check page, we should indicate if there
are more results than we can show. No-one’s really complained about the
absence of this, but it can’t hurt.
 2016-08-05 10:59:49 +01:00
Chris Hill-Scott
e621dddd6d Don’t show the download until the job is complete 
The CSV report isn’t very useful until it has all the rows from your
original file. So we shouldn’t show you the link until all notifications
have been created.

Until this point, it’s useful to know how much longer you need to wait,
so this commit adds a percentage count of how much of the file has been
processed.
 2016-08-05 10:59:49 +01:00
Leo Hemsted
e2875ea66e Merge branch 'master' into remove-stats-from-send 2016-07-29 11:08:42 +01:00
Leo Hemsted
a7c8e88ecb add tests and remove old aggregate code 2016-07-28 18:09:17 +01:00
minglis
817a52781f Merge pull request #803 from alphagov/remove-stats-from-job-page 
Remove stats from job page
 2016-07-26 11:24:00 +01:00
minglis
4db855c5b5 Merge pull request #804 from alphagov/too-many-messages 
Too many messages
 2016-07-26 11:23:55 +01:00
Leo Hemsted
45debe0d5b remove get_statistics_for_service_for_day from codebase 
two down, three to go
 2016-07-25 14:54:58 +01:00
Leo Hemsted
0accd88869 request stats for today from send page from GET /service/:id endpoint 
also amended test cases to ensure they mock out correct call
 2016-07-25 14:46:27 +01:00
Leo Hemsted
aa37dc4929 add tests for send check error messages 2016-07-25 10:41:50 +01:00
Leo Hemsted
d6e6d05893 add tests for send check error messages 2016-07-21 15:39:00 +01:00
Leo Hemsted
57e03349d2 remove get_statistics_for_service from statistics_api_client 2016-07-20 15:54:30 +01:00
Leo Hemsted
fade656e3b add new get_detailed_service mock to tests that the dashboard 2016-07-20 14:12:22 +01:00
Leo Hemsted
3ffd6c744c separate detailed and normal service_api_client.get_service 
to make it easier to mock and control return values
 2016-07-20 14:12:22 +01:00
Leo Hemsted
4451a8634d add detailed flag to GET service api client 
returns current (past 7 days) notification stats as well as service info
 2016-07-20 14:12:22 +01:00
Rebecca Law
43938936f3 If a user has already registered with the email they will get a different email when the register again. 
The email includes likes to sign in and send feedback
 2016-07-12 11:53:30 +01:00
Chris Hill-Scott
50c20ce680 Add formatted notification status to CSV 
This commit makes the CSV download use the same language for failure
reasons as the frontend.

It also adds a test around this stuff, which was patchily tested before.
 2016-07-11 13:12:46 +01:00
Chris Hill-Scott
cddfd6c517 Fix get started banner on dashboard 
This banner was always being shown because the template was never
getting sent the service’s templates from the API.

This commit fixes this to only show the banner when a service has no
templates, and adds some tests to make sure it doesn’t happen again.
 2016-07-04 13:15:32 +01:00
Adam Shimali
3bfcf0f8b3 Users can set a value that appears as the sender of a text message. 
It can be up to eleven characters alpha numeric, no special characters
allowed.
 2016-07-01 14:22:25 +01:00
Chris Hill-Scott
02dccde0bd Don’t show send/edit links for deleted template 
Since you can’t really send or edit a deleted template we should show
a message telling you that the template has been deleted.

This is important because deleted templates still show up in the
template statistics.
 2016-07-01 13:35:48 +01:00
Rebecca Law
584ad26a1a Merge branch 'master' into fix-password-changed-at 
Conflicts:
	tests/conftest.py
 2016-06-28 11:02:53 +01:00
Rebecca Law
de42391afa Keep Last changed text. 
Update user test data to include the password_changed_at attribute.
 2016-06-28 10:40:39 +01:00
Rebecca Law
7d64b77e5d Use password_changed_at field from User object rather than use a hard coded date. 
https://www.pivotaltracker.com/story/show/122205615
 2016-06-27 17:03:15 +01:00
Leo Hemsted
6ce087a7b5 send key_type = normal when creating api keys 2016-06-27 12:02:16 +01:00
Adam Shimali
f030d1cb8a Move check_messages in admin over to using get notification stats for 
day.
 2016-06-20 13:49:47 +01:00
Chris Hill-Scott
7416070199 Refactor job conftests to eliminate temp variables 
These tests were assigning something to a variable, then immediately
returning that variable. Why not just return the thing itself?
 2016-06-20 09:31:29 +01:00
Chris Hill-Scott
8ca7832541 Filter test messages from jobs on the dashboard 
While test messages technically have a file and are a job, there’s not
much reason to ever revisit them. So all they end up doing is cluttering
the dashboard and making it harder to find the actual files you’ve
actually uploaded from your computer.

So this commit:

- abstracts the name of test messages into config
- filters out any files whose filename represents a test message
- adds some more thorough tests for the jobs on the dashboard
 2016-06-20 09:31:20 +01:00
Leo Hemsted
845fee69c4 fix bug - calling wrong template_statistic endpoint causing 500 error on delete 
- also unrolled a test with a for loop into a parametrized test
 2016-06-14 11:01:33 +01:00
Leo Hemsted
65615360eb Merge pull request #658 from alphagov/last-used-message 
Last used message
 2016-06-07 16:13:30 +01:00
Leo Hemsted
c4305d1610 only get template statistics for specific template 2016-06-07 14:28:02 +01:00
Leo Hemsted
9db20819ef tests for last used message 
also now parsing the datetime correctly and removing its UTC tz info to make comparisons work
 2016-06-07 11:50:15 +01:00
Nicholas Staples
d53b4bd7cd Bug fixed when sending yourself a test the back button links to the correct url. 
Remove traceback.
 2016-06-07 09:55:04 +01:00
Leo Hemsted
9669024f49 table with sending/delivered/failed stats for each service today 2016-05-31 14:10:32 +01:00
Leo Hemsted
f2cca024dd Merge pull request #619 from alphagov/platform-admin-stats 
Headline stats on the platform admin page
 2016-05-31 13:53:21 +01:00
Leo Hemsted
83b151982e add stats boxes to platform admin page 
moved a couple of stats summary functions from dashboard to a shared statistics_utils file
 2016-05-31 12:17:06 +01:00
Chris Hill-Scott
16d83faa72 Put uploaded files on the dashboard 
This commit depends on and uses the data returned by:
- [x] https://github.com/alphagov/notifications-api/pull/345
- [x] https://github.com/alphagov/notifications-api/pull/347
- [x] https://github.com/alphagov/notifications-admin/pull/612

It puts the last 5 jobs on the dashboard. This should be changed to all the jobs
from the last 7 days when that parameter is available.

It also:
- links to the jobs page
- makes the numbers on the jobs page consistent with the dashboard
- makes the numbers on an individual job consistent with the appearance of the
  dashboard
 2016-05-26 09:00:00 +01:00
Nicholas Staples
2505d1421b Fixed download bug for services with api notifications. Re-organised the mock job and job_json methods. 2016-05-24 12:35:12 +01:00
Chris Hill-Scott
dd25eb0fe1 Give the job CSV a helpful filename 
If you’re downloading a bunch of reports from your jobs then it’s useful to be
able to differentiate between them. This commit makes it easy to do so by naming
the file with:
- the name of the template
- when the job was created
 2016-05-24 09:57:21 +01:00
Martyn Inglis
664ae33108 Formatting 2016-05-18 13:10:51 +01:00