Commit Graph

8771 Commits

Author SHA1 Message Date
Chris Hill-Scott
fce0397b55 Move service history into it own file
We’re going to do some work on this page, let’s put it in a sensible
place first before we add a bunch more code to the wrong place.
2019-10-21 16:29:05 +01:00
Katie Smith
3732e45126 Stop allowing uploaded letters to be sent for trial mode services
We weren't checking if a service was in trial mode when they try to send
an uploaded file. If a service is in trial mode, we now show a banner at
the top of the preview page and no send button.
2019-10-21 14:42:39 +01:00
Katie Smith
fe78d53643 Merge pull request #3137 from alphagov/upload-letter-errors
Update the errors seen when uploading a letter
2019-10-21 13:21:23 +01:00
Katie Smith
b0ffca2774 Only show overlay when content is outside the printable area
The overlay was showing for any invalid pdf - we only want to show the
overlay for invalid pdf files where there is content outside the
printable area.
2019-10-21 11:10:27 +01:00
Katie Smith
3b3f74bbf0 Use the new error messages when uploading a letter
We now use the pattern of showing a box at the top of the page with the
error. The error message has a heading and can have additional details.
Error messages and the invalid pages get stored in the S3 metadata.
2019-10-21 08:37:55 +01:00
Katie Smith
3223956ba2 Allow extra metadata fields when uploading letter to S3 2019-10-21 08:37:55 +01:00
Katie Smith
8f7a05200d Add function to map template-preview errors to user-friendly errors
Template preview now returns a short string as it's error message plus
a list of invalid pages.
2019-10-21 08:35:04 +01:00
Katie Smith
3ad639f571 Link to latest version of letter spec everywhere 2019-10-21 08:35:04 +01:00
karlchillmaid
b46716416a Update settings content 2019-10-21 08:16:43 +01:00
David McDonald
3e9a4b97e8 Merge pull request #3153 from alphagov/second-class-default
Send precompiled letters with a postage value to the API
2019-10-18 16:43:24 +01:00
David McDonald
3436a190a7 Send precompiled letters with a postage value to the API
We hardcode this as second class for the moment but eventually
will let the user pick.

Currently the API appears to do no validation, e.g. a json
schema, that rejects API calls with the extra key for postage.

Next steps will be to put a PR into the API that will expect a
postage value in the request and save it with the rest of the
notification. Then when that is done we can add the user interface
to the admin app to let the user pick the postage.
2019-10-18 16:35:16 +01:00
karlchillmaid
a4e1b74398 Update content 2019-10-18 09:24:02 +01:00
karlchillmaid
dfa979cdff Change 'process' to 'approve' 2019-10-17 16:51:41 +01:00
Chris Hill-Scott
b64336b5da Fix details/summary 2019-10-17 16:23:21 +01:00
Chris Hill-Scott
bc32315fbe Add endpoint for new page 2019-10-17 16:18:21 +01:00
Chris Hill-Scott
5494146401 Add HTML extension to template file 2019-10-17 16:17:09 +01:00
karlchillmaid
49163ef624 Update content 2019-10-17 16:16:42 +01:00
karlchillmaid
9a097386a1 Change 'sign' to 'accept'
Change 'sign' to 'accept' – because users can now accept online
2019-10-17 16:06:48 +01:00
karlchillmaid
13f704993c Change 'set up' to 'add'
For consistency
2019-10-17 15:31:23 +01:00
Chris Hill-Scott
5c9f238c12 Merge pull request #3097 from alphagov/add-js-tests-for-highlight-tags
Add JS tests for highlight tags module
2019-10-17 15:30:24 +01:00
karlchillmaid
cb4bb9d4c4 Change 'set up' to 'add'
'Add' matches the buttons users will see in Notify
2019-10-17 15:28:49 +01:00
Chris Hill-Scott
cb82cfedd1 Merge pull request #3146 from alphagov/transparent-conditional-text
Make text transparent on conditional placeholders
2019-10-17 15:27:39 +01:00
Chris Hill-Scott
f52847fd58 Merge pull request #3150 from alphagov/back-links-support
Add standard back links to the support journey
2019-10-17 15:27:34 +01:00
karlchillmaid
8696ceb43f Change 'set up' to 'add'
'Add' matches the buttons users will see in the service.
2019-10-17 15:25:31 +01:00
karlchillmaid
cd34e18604 Update content 2019-10-17 15:22:49 +01:00
Chris Hill-Scott
7e3b7711bc Add standard back links to the support journey
Removes the non-standard, bottom of page back links where present.

Adds sticky footer to pages with long text boxes.
2019-10-17 13:44:04 +01:00
karlchillmaid
9234b8830c Add ids to headings, add branding information
The ids are not needed for the first iteration of the Get started page, but we'll start using them as we add and iterate guidance and features content.

We should mention letter branding as a feature.
2019-10-16 13:58:15 +01:00
karlchillmaid
2e392aa9e3 Add ids to headings
These are not needed for the first iteration of the Get started page, but we'll start using them as we add and iterate guidance and features content.
2019-10-16 13:52:20 +01:00
karlchillmaid
8492f3f806 Add ids to headings 2019-10-16 13:50:37 +01:00
Pea (Malgorzata Tyczynska)
53ef438a1e Merge pull request #3135 from alphagov/enforce_letter_10_page_limit
Enforce letter 10 page limit
2019-10-16 13:14:30 +01:00
Pea Tyczynska
4b5a131072 Harmonise content of error message with the document laid out by our content designer 2019-10-16 13:02:11 +01:00
karlchillmaid
52b5936912 Add links to account pages 2019-10-16 12:08:45 +01:00
karlchillmaid
84b5f8e690 Update h1 2019-10-16 10:59:08 +01:00
karlchillmaid
07358f27b7 Fix if statements
Swap content round so the if statement works properly.
2019-10-16 10:44:07 +01:00
karlchillmaid
8c782b040a Add links 2019-10-16 10:35:39 +01:00
karlchillmaid
541a023708 Add ids to remaining H2s
These are not needed for the first iteration of the Get started page, but we'll start using them as we add and iterate guidance and features content.
2019-10-16 10:23:39 +01:00
karlchillmaid
26aa3d32d6 Add id to Permissions h2 2019-10-16 10:20:51 +01:00
karlchillmaid
50bb0764c9 Add anchor to h2 2019-10-16 10:19:32 +01:00
karlchillmaid
7764a1b440 Add anchor to h3 2019-10-16 10:17:52 +01:00
karlchillmaid
c781a7c07a Fix smart quotes 2019-10-16 08:56:44 +01:00
karlchillmaid
78f44e2433 Update content 2019-10-15 17:09:12 +01:00
karlchillmaid
feae9ebcdd Add draft content 2019-10-15 11:38:30 +01:00
karlchillmaid
0a355d7089 Create Get started page 2019-10-15 09:39:24 +01:00
Chris Hill-Scott
5d82dc8b36 Make text transparent on conditional placeholders
Otherwise you have a visible copy of the text underlapping the text in the textbox. Which, when they don’t quite align makes the text look bold. Seems to be more noticeable on some browsers/operating systems than others, but a bug all the same.
2019-10-11 10:05:51 +01:00
Pea Tyczynska
2ed1e382b4 Move letter length check to utils repo so template-preview can use it, too
Update requirements
2019-10-10 14:25:19 +01:00
Chris Hill-Scott
1cfb42c1e1 Merge pull request #3142 from alphagov/fix-email-branding-request-textbox-only
Fix email branding request page with only textbox
2019-10-09 17:10:32 +01:00
Chris Hill-Scott
7f033efc28 Fix email branding request page with only textbox
If there aren’t a range of options (normally presented as radio buttons)
to show the user on the email branding request page then we just show
the textbox. But we were still doing form validation on the radio
buttons, even though the user couldn’t see them to click them. This
stopped the user from being able to submit the form.

This commit fixes the problem by, in this specific case, pre-ticking the
‘Something else’ radio button.
2019-10-09 16:42:30 +01:00
Pea Tyczynska
c524b0bbf5 Rebase and set upload status to invalid if too many pages 2019-10-09 16:03:48 +01:00
Pea Tyczynska
6639209229 Check page count of actual notification not of template
But for jobs we are only checking preview row, otherwise it would
be too slow. We will check other row when creating the pdf
2019-10-09 16:03:48 +01:00
Pea Tyczynska
12ec2870af Move letter too long banner message over from utils, also refactor 2019-10-09 16:03:47 +01:00