Commit Graph

10726 Commits

Author SHA1 Message Date
Tom Byers
27f7e873f1 Merge pull request #3645 from alphagov/fix-focus-on-table
Make only the scrollable table focusable
2020-09-23 11:32:04 +01:00
Tom Byers
fb112bd5f7 Fix typo in status page issue
Co-authored-by: Chris Hill-Scott <me@quis.cc>
2020-09-23 11:27:31 +01:00
Tom Byers
80c84f2f52 Make reference to status page a link
Co-authored-by: Chris Hill-Scott <me@quis.cc>
2020-09-23 11:26:57 +01:00
Tom Byers
5e18988a3b Remove issue related to CSV table focus 2020-09-23 11:10:37 +01:00
Tom Byers
eba78ebf89 Update preparation and review dates 2020-09-23 11:09:06 +01:00
Chris Hill-Scott
dcd48f99dd Merge pull request #3632 from alphagov/training-broadcast-approved
Add a tour screen once a broadcast is approved
2020-09-23 11:07:03 +01:00
Chris Hill-Scott
6f389d044e Don’t use $yellow to indicate local environment
It clashes with the new `$govuk-focus-colour` now. This commit changes
it to half way between `govuk-colour("dark-grey")` (`#505a5f`) and
`govuk-colour("mid-grey")` (`#b1b4b6`) from the Design System. Dark was
too dark and mid was too light.

It also adds a line of JS to let us easily switch the header to blue by
clicking on it, which is useful for taking screenshots etc.
2020-09-23 11:02:21 +01:00
Chris Hill-Scott
b20ba2349e Replace uses of $yellow for focus
There are a few places where we missed updating to the new focus styles
because they were using the `$yellow` SASS variable and not the
`$focus-colour` variable.

This commit updates them to the new colour, and where needed adds the
black lower border to match.
2020-09-23 10:50:43 +01:00
Tom Byers
cf07d79024 Make difference between table frames obvious
...by naming the attributes related to
accessibility.

Also includes tests for this.
2020-09-23 10:33:58 +01:00
Tom Byers
041f061dec Make only the scrollable table focusable
The JS clones the scrollable table so was passing
its attributes across to the fixed one (which
provides the row headings).

This bug was pushed in:

https://github.com/alphagov/notifications-admin/pull/3637
2020-09-23 09:58:27 +01:00
Tom Byers
798c6ebc48 Exclude new page from navigation 2020-09-23 09:53:12 +01:00
Tom Byers
6ab85c4c78 Merge pull request #3637 from alphagov/make-table-focusable
Make table focusable
2020-09-23 09:36:17 +01:00
Tom Byers
2ec053ca3d Tweaks to email issue descriptions 2020-09-22 21:45:13 +01:00
Tom Byers
2212d3a5e0 Tweaks to issues summary & list + reporting 2020-09-22 21:44:38 +01:00
karlchillmaid
cd61479a4f Update PDF information 2020-09-22 20:47:05 +01:00
karlchillmaid
6cfc62216e Update summary 2020-09-22 19:15:13 +01:00
karlchillmaid
bd592ff67b Add status page information 2020-09-22 19:14:09 +01:00
Leo Hemsted
93d1137474 move service to broadcast org when broadcasting is enabled
we want to keep track of all broadcast services across govt easily. As
such, when broadcasting is enabled for a service, we've decided we're
going to add the service to a special broadcasting organisation.

This organisation is defined in the config file. It's hard coded for
production, if you want to test locally, you should set
BROADCAST_ORGANISATION_ID in your local environment.
2020-09-22 18:18:00 +01:00
Chris Hill-Scott
f50ef84c0d Suggest previously-used areas when adding new area
If you’re adding another area to your broadcast it’s likely to be close
to one of the areas you’ve already added.

But we make you start by choosing a library, then you have to find the
local authority again from the long list. This is clunky, and it
interrupts the task the user is trying to complete.

We thought about redirecting you somewhere deep into the hierarchy,
perhaps by sending you to either:
- the parent of the last area you’d chosen
- the common ancestor of all the areas you’d chosen

This approach would however mean you’d need a way to navigate back up
the hierarchy if we’d dropped you in the wrong place. And we don’t have
a pattern for that at the moment.

So instead this commit adds some ‘shortcuts’ to the chose library page,
giving you a choice of all the parents of the areas you’ve currently
selected. In most cases this will be one (unitary authority) or two
(county and district) choices, but it will scale to adding areas from
multiple different authorities.

It does mean an extra click compared to the redirect approach, but this
is still fewer, easier clicks compared to now.

This meant a couple of under-the-hood changes:
- making `BroadcastArea`s hashable so it’s possible to do
  `set([BroadcastArea(…), BroadcastArea(…), BroadcastArea(…)])`
- making `BroadcastArea`s aware of which library they live in, so we can
  link to the correct _Choose area_ page
2020-09-22 17:33:04 +01:00
karlchillmaid
8343de1f26 Update introduction content 2020-09-22 17:12:08 +01:00
Tom Byers
300af7126e Updates to issues in various places 2020-09-22 16:53:33 +01:00
Tom Byers
a75cde039f Merge pull request #3624 from alphagov/add-accessible-letter-specification
Add accessible letter specification
2020-09-22 16:36:15 +01:00
karlchillmaid
f6a31dfcaf Update details link 2020-09-22 16:19:25 +01:00
Tom Byers
0e0f5dcc5d Add copy from the draft document 2020-09-22 16:18:00 +01:00
Chris Hill-Scott
6047bd3520 Fix duplicated h2 2020-09-22 15:52:52 +01:00
Chris Hill-Scott
2d64306e88 Link to specification page, not PDF directly 2020-09-22 15:49:38 +01:00
Chris Hill-Scott
a384f4cace Add route for letter specification page 2020-09-22 15:36:20 +01:00
karlchillmaid
cab0a0723e Add details component 2020-09-22 14:57:10 +01:00
karlchillmaid
9e64eaaf83 Update content 2020-09-22 14:51:36 +01:00
Tom Byers
5241ea3ef0 Add basic page for accessibility statement 2020-09-22 11:46:57 +01:00
David McDonald
a538329d0e Use new redis key for service templates and broadcasts
We can drop use of the old key as we no longer need to read data from
the old key. Either data exists in the new key and we read it from there
or data doesn't exist in the new key and we go to the API to get it and
then set it in redis.

Note, the previous commit is important because it means we aren't at
risk of when this commit is being deployed out, of us getting stale data
from the old key.
2020-09-21 17:37:27 +01:00
karlchillmaid
4616349b16 Add note 2020-09-21 16:41:02 +01:00
karlchillmaid
e6f1caae88 Add link to letter specification page 2020-09-21 16:22:15 +01:00
karlchillmaid
10a93cdbdb Add punctuation 2020-09-21 16:11:15 +01:00
karlchillmaid
68c9486b1f Remove content from this page
This content has moved to the new Letter specification page.

Will need to add the link to that page.
2020-09-21 16:09:53 +01:00
karlchillmaid
ddb671457c Update page content 2020-09-21 16:08:02 +01:00
David McDonald
e3baa9ba35 Step 1 of renaming cache keys for templates
We want to change cache keys for templates and broadcasts to include
their service ID. So cache keys should change from
`template-{template_id}-versions` to
`service-{service_id}-template-{template_id}-versions`.

The first step of this which needs to be deployed as a change first is
to delete both keys when updating service templates (even if they key is
not yet set). This means that when we release code in the next PR to
start setting the new key, we won't run into a case where either the old
or the new key can remain set with stale data.
2020-09-21 14:04:10 +01:00
Leo Hemsted
422825f03b Merge pull request #3629 from alphagov/fix-broadcast-back-links
fix back links for broadcast libraries
2020-09-21 11:37:21 +01:00
Leo Hemsted
a6b25b5991 add back links
previously the back link went to choosing a library.

Now, if you view a district from a county, go back to the county page.
Otherwise, go back to the top level of the library.
2020-09-21 11:24:05 +01:00
Chris Hill-Scott
fec8dc8911 Adjust wording of first paragraph
I’ve swapped the order of the first paragraph so it joins into one
sentence, and leads with ‘Notify has not broadcast your alert’ which
is the response to what the user has just done. I don’t think we need
to say ‘still’ because the idea is users will swap back and forth
between training and real depending on the situation.
2020-09-21 10:53:39 +01:00
Chris Hill-Scott
5c22bd56ce Add a tour screen once a broadcast is approved
For a training broadcast the user doesn’t get that immediate feedback
that something has happened, like they would with a real alert, or even
sending themselves a text message.

This commit adds another tour-style page which will interrupt their
journey and hopefully reinforce the message we’ve given them earlier in
the tour.

We’re adding this because we’ve found in research that users don’t have
a good grasp of the consequences and severity of emergency alerts,
versus regular text messages.
2020-09-21 09:41:19 +01:00
Tom Byers
a9c1d64326 Add tests for the focus style & new attributes 2020-09-19 22:03:45 +01:00
Tom Byers
de89e3cc11 Make fullscreen focusable
Includes:
- adding tabindex=0 to make it focusable
- giving it a focus style matching GOVUK Frontend
- giving it a label matching the table caption

Taken from this article:

https://adrianroselli.com/2017/11/a-responsive-accessible-table.html#ResponsiveScrollingKeyboard
2020-09-19 22:03:45 +01:00
Katie Smith
7040c7bdd0 Merge pull request #3636 from alphagov/fix-status-display
Fix the display of sms statuses
2020-09-18 16:51:01 +01:00
Katie Smith
a67ea9a623 Fix the display of sms statuses 2020-09-18 16:26:08 +01:00
Tom Byers
dd9ab6f8cf Merge pull request #3635 from alphagov/make-selection-summary-more-detailed
Make selection summary more detailed
2020-09-18 14:20:56 +01:00
Tom Byers
4b28846c6b Make selection summary (counter) more detailed 2020-09-18 12:10:32 +01:00
Tom Byers
704de9ebf3 Add tests for various different counter states 2020-09-18 12:10:32 +01:00
Tom Byers
2f18e4b2f0 Update test helper that generates checkboxes
It was using GOVUK Elements HTML and we have since
moved to GOVUK Frontend.
2020-09-18 11:50:32 +01:00
Tom Byers
b19330ae1e Merge pull request #3634 from alphagov/add-announcements-to-live-search
Add announcements to live search
2020-09-18 11:31:06 +01:00