darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-06-19 20:52:32 -04:00
Code Issues Packages Projects Releases Wiki Activity
7,699 Commits 57 Branches 61 Tags
a1025111d9a59508328cffcdc19e1b290fb192a4
Commit Graph

5183 Commits

Author SHA1 Message Date
Chris Hill-Scott
a1025111d9 Allow overflow on right-aligned table cells 
The right aligned cells contain ‘Change’ links. These have a large
`border` to make the clickable area bigger. This commit removes the
`overflow: hidden` from these cells, so that the larger border remains
visible.
 2019-04-26 11:43:41 +01:00
Chris Hill-Scott
da19c0b4ad Remove bullets from lists in tables 
I think this is something we inherited from the Digital Marketplace
code. We only use this for organisation settings are the moment, but
the list markers are redundant because each item will never wrap onto a
new line; it will truncate instead. Still keeps a little sliver of
spacing just so it doesn’t look like a paragraph.
 2019-04-24 16:11:32 +01:00
Chris Hill-Scott
d3caaf94b1 Make archive/suspend links not buttons 
They don’t immediately perform an action, so semantically they are
links, not buttons.
 2019-04-24 16:11:32 +01:00
Chris Hill-Scott
7c8ce6c62a Make platform admin settings table body copy size 
No reason why it should be smaller and harder to read than the
user-facing settings table.
 2019-04-24 16:11:32 +01:00
Chris Hill-Scott
5ac2abb7bc Make center column of table wider 
Most of the content of our ‘settings’ tables is in the value, not the
key. The value is in the middle column. So we should allocate the most
space to the value.

The previous layout was based on the premise that most pages divided the
grid like this:
```
 _______ _______ _______ _______ _______ _______ _______ _______
|  1/8  |  1/8  |  1/8  |  1/8  |  1/8  |  1/8  |  1/8  |  1/8  |
|               |               |               |               |
|      2/8      |      2/8      |      2/8      |      2/8      |
|               |               |               |               |
|–Navigation––––|–Main column–––––––––––––––––––––––––––––––––––|
|               |                       |                       |
|               |          3/8          |          3/8          |
|               |                       |                       |
|               |–Label–––––––––––––––––|–Value––––––––––––Link–|
|               |                       |                       |
|_______________|_______________________|_______________________|
```

This was because a lot of pages had a left column for emails, and a
right column for text messages, so it felt consistent for tables to
always default to 50% of the width of the main column.

This consistency has faded with time, especially as we added letters.

So this commit changes these tables to allocate more space to the
central column, but still sticking to the grid like this:

```
 _______ _______ _______ _______ _______ _______ _______ _______
|  1/8  |  1/8  |  1/8  |  1/8  |  1/8  |  1/8  |  1/8  |  1/8  |
|       |       |       |       |       |       |       |       |
|      2/8      |      2/8      |              4/8              |
|               |               |                               |
|–Navigation––––|–Main column–––––––––––––––––––––––––––––––––––|
|               |               |                       |       |
|               |      2/8      |          3/8          |  1/8  |
|               |               |                       |       |
|               |–Label–––––––––|–Value–––––––––––––––––|–––Link|

|_______________|_______________|_______________________|_______|
```

Since there’s more space to display the value of a setting this commit
also truncates settings that are too long to fit in the width of the
column (for example a long email address) rather than the previous
behaviour of truncating them. This all just makes things look a bit
cleaner.
 2019-04-24 16:11:32 +01:00
Chris Hill-Scott
f726551714 Remove unused method 
We use `.get_free_sms_fragment_limit_for_year()` instead, which
functionally is the same thing (has a default argument of `year=None`).
 2019-04-24 13:10:41 +01:00
Chris Hill-Scott
9c846979be Don’t error if service without an organisation requests to go live 
It was trying to look at `organisation.domains`, which caused an
`AttributeError` if there wasn’t an organisation.
 2019-04-23 16:48:15 +01:00
Chris Hill-Scott
9f1bc285fa Merge branch 'master' into record-user-that-requested-to-go-live 2019-04-23 15:38:44 +01:00
Pete Herlihy
fc24509fd2 Added officeforstudents.org.uk to email domains 2019-04-23 11:12:14 +01:00
Chris Hill-Scott
7beea0b2ac Merge pull request #2922 from alphagov/features-footer-second-pass 
Features and footer updates
 2019-04-18 13:17:16 +01:00
karlchillmaid
ba4bc5a5aa Add and update links 2019-04-18 11:34:58 +01:00
karlchillmaid
67a75bedf6 Update content 2019-04-18 11:29:57 +01:00
karlchillmaid
96772374a4 Update link text 2019-04-18 11:26:57 +01:00
karlchillmaid
33ec4228db Update bulk sending, postage and upload 2019-04-18 11:22:31 +01:00
Chris Hill-Scott
9d32d40ee4 Merge pull request #2908 from alphagov/allow-invited-users-to-count 
Let inviting a user complete the go live checklist
 2019-04-18 11:17:56 +01:00
karlchillmaid
30cff547bf Update introduction 
Update introduction
 2019-04-18 10:59:18 +01:00
karlchillmaid
17a3abf6a6 Reformat API documentation link 2019-04-18 10:56:45 +01:00
karlchillmaid
39b84e63c3 Reformat API documentation link 2019-04-18 10:55:22 +01:00
Katie Smith
a70ab1bd9d Add Metropolitan Thames Valley to email domains 2019-04-17 17:19:07 +01:00
Tom Byers
b3d73030ee Remove use of spread operator 
This is a temporary fix for the fact that the
babel plugin for the spread operator calls a
function called `_iterableToArray` which assumes
the JavaScript runtime supports Symbols.

IE11 doesn't support Symbols so this causes an
error when it runs our JS.

This swaps out use of the spread operator for a
use of
[apply](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/apply)
to unpack the `arguments` object.

Related issue on babel:

https://github.com/babel/babel/issues/7597
 2019-04-17 12:40:49 +01:00
Chris Hill-Scott
39c4740d03 Fix links to support 2019-04-16 16:51:28 +01:00
karlchillmaid
50747d190e Correct apostrophes 2019-04-16 16:49:36 +01:00
karlchillmaid
d37a3557c4 Correct apostrophe, add VAT 2019-04-16 16:47:52 +01:00
karlchillmaid
43f23046d5 Correct apostrophe 2019-04-16 16:46:44 +01:00
karlchillmaid
fccab8103c Correct link, apostrophe and contraction 2019-04-16 16:44:35 +01:00
Chris Hill-Scott
3e969280fc Remove pricing stuff from organisation model 
We’re not linking to the agreement from the pricing page any more, so we don’t need to talk about whether an organisation has signed it or not.
 2019-04-16 15:45:36 +01:00
karlchillmaid
f3a2e695fb Merge pull request #2858 from alphagov/features-content-updates 
Update features and footer content and answer some common support questions.
 2019-04-16 15:42:51 +01:00
Chris Hill-Scott
f05e5af6d8 Update footer to reflect new features navigation" 2019-04-16 15:22:37 +01:00
Chris Hill-Scott
1f0195c1d1 Remove ‘using notify’ from nav (it’s a redirect now) 2019-04-16 15:20:00 +01:00
Chris Hill-Scott
0303d6a018 Indent sub navigation items 2019-04-16 15:19:28 +01:00
karlchillmaid
6366417568 Merge pull request #2914 from alphagov/correct-time-formatting 
Correct time formatting
 2019-04-16 15:07:04 +01:00
Rebecca Law
da8eead475 Update service with the user that requested to go live. 
When a service is marked as live update the service with the go live datetime.
 2019-04-16 15:01:54 +01:00
Chris Hill-Scott
ae403c5b5a Update app/templates/views/trial-mode.html 
Co-Authored-By: karlchillmaid <karl.chillmaid@digital.cabinet-office.gov.uk>
 2019-04-16 14:44:45 +01:00
Chris Hill-Scott
042a61a930 Update app/templates/views/trial-mode.html 
Co-Authored-By: karlchillmaid <karl.chillmaid@digital.cabinet-office.gov.uk>
 2019-04-16 14:44:37 +01:00
Chris Hill-Scott
8872e30567 Update app/templates/views/support/index.html 
Co-Authored-By: karlchillmaid <karl.chillmaid@digital.cabinet-office.gov.uk>
 2019-04-16 14:44:21 +01:00
Chris Hill-Scott
99ef4d61ff Update app/templates/views/pricing.html 
Co-Authored-By: karlchillmaid <karl.chillmaid@digital.cabinet-office.gov.uk>
 2019-04-16 14:44:02 +01:00
Chris Hill-Scott
78333b70b9 Update app/templates/views/pricing.html 
Co-Authored-By: karlchillmaid <karl.chillmaid@digital.cabinet-office.gov.uk>
 2019-04-16 14:43:53 +01:00
Chris Hill-Scott
232b8aa9c8 Update app/templates/views/pricing.html 
Co-Authored-By: karlchillmaid <karl.chillmaid@digital.cabinet-office.gov.uk>
 2019-04-16 14:43:43 +01:00
Chris Hill-Scott
163f8561e1 Update app/templates/views/message-status.html 
Co-Authored-By: karlchillmaid <karl.chillmaid@digital.cabinet-office.gov.uk>
 2019-04-16 14:43:34 +01:00
Chris Hill-Scott
534c5b1986 Update app/templates/views/features/letters.html 
Co-Authored-By: karlchillmaid <karl.chillmaid@digital.cabinet-office.gov.uk>
 2019-04-16 14:43:22 +01:00
Chris Hill-Scott
59e981030a Update app/templates/views/features/emails.html 
Co-Authored-By: karlchillmaid <karl.chillmaid@digital.cabinet-office.gov.uk>
 2019-04-16 14:43:10 +01:00
karlchillmaid
0ee322f137 Merge branch 'master' into features-content-updates 2019-04-16 13:50:50 +01:00
karlchillmaid
527d8ff10f Correct table 2019-04-16 13:49:46 +01:00
Tom Byers
1d88324175 Revert "Update diff-dom package to 3.1.0" 
This reverts commit 01b97986f6.
 2019-04-16 13:09:15 +01:00
karlchillmaid
b7c955c010 Make the formatting of postage times consistent 2019-04-16 10:39:50 +01:00
karlchillmaid
0bf1068a3e Make the formatting of postage times consistent 
Make the formatting of postage times consistent with the rest of the service, and the GOV.UK style guide.
 2019-04-16 10:34:46 +01:00
karlchillmaid
521c7824d6 Update link 2019-04-16 10:25:33 +01:00
karlchillmaid
487919970b Update link 2019-04-16 10:25:02 +01:00
karlchillmaid
3f4ca1018d Updated link 2019-04-16 10:23:10 +01:00
karlchillmaid
d12c184d7e Update links 2019-04-16 10:21:01 +01:00