darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-28 06:11:03 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,367 Commits 50 Branches 59 Tags
8b99f484d4f24a60be00a18cbc2a52fbcd8c2cd4
Commit Graph

181 Commits

Author SHA1 Message Date
Chris Hill-Scott
0f6a090470 Fix admin app putting service into research mode 
We changed the `update_service` method to only update indivdual
attributes of a service, and only allow it to update specified
attributes: 0cfe10639a

We neglected to specify `research_mode` as one of the allowed
attributes.

This broke the app’s ability to put a service in or out of research
mode.

This commit:
- makes sure the tests cover this eventuality
- fixes the bug by specifying `research_mode` as one of the allowed
  attributes
 2016-08-23 10:16:27 +01:00
Martyn Inglis
54e4311d1b Merged in the defensive code by mistake 2016-08-22 16:56:43 +01:00
Martyn Inglis
9fbd410474 Merge branch 'master' into use_new_template_stats_endpoint 
Conflicts:
	app/notify_client/template_statistics_api_client.py
 2016-08-22 16:47:42 +01:00
Martyn Inglis
f59e05fb1a Handle the API migration 
If it;s the new format API hide the results

- Temp fix until new Admin code ships. Should be live for 5 mins.
 2016-08-22 12:35:34 +01:00
Martyn Inglis
55c4443a05 Admin app uses the new API response formats. 2016-08-18 15:30:57 +01:00
Leo Hemsted
fde8d81868 send organisation back in correct variable 2016-08-15 11:15:49 +01:00
Leo Hemsted
fb510d2522 only set organisation on GET and add allowed fields to service client 
we were overwriting it before validating the form for POST, so lost info
 2016-08-12 12:37:18 +01:00
Chris Hill-Scott
6b5e64479a Add a page to set organisation and branding option 
Platform admin only.

Adds radio buttons to choose one of:
- three hard-coded branding options
- organisations from a list provided by the API
 2016-08-12 10:31:43 +01:00
Leo Hemsted
20c39d24b7 Merge pull request #863 from alphagov/allow-partial-service-updates 
Allow partial service updates from service API client
 2016-08-12 10:07:55 +01:00
Chris Hill-Scott
955566b127 Don’t allow changing service users on update 2016-08-11 17:10:10 +01:00
Chris Hill-Scott
da1fa2e61c Make _attach_current_user a pure function 
Mutating dictionaries is gross and doesn’t work as you’d expect. Better
to have the function return a new dictionary instead.

Means we can be explicit that `created_by` is one of the allowed params
when updating a service.
 2016-08-11 17:07:55 +01:00
Chris Hill-Scott
0cfe10639a Only allow update service to modify named attrs 
To prevent typos and inadvertently updating something we shouldn’t,
this adds some filtering to the update_service method to make sure it
is only allowed to update certain attributes of a service.
 2016-08-11 17:07:43 +01:00
Chris Hill-Scott
002b58a062 Make service API client do partial updates 
The service API client was updating every attribute of a service. Which,
while kinda clunky, is fine…

…until something calling it doesn’t pass in every attribute of the
current service. It was then defaulting optional parameters to `None`.
Which resulted in a bug whereby every time a service was set to live,
its `reply_to_address` and `sms_sender_name` got overwritten to be
empty.

This commit changes the `update` method to only require the service ID,
and pass whatever other named arguments it received straight through to
the API. The API handles partial updates just fine (I think).
 2016-08-11 17:07:33 +01:00
Leo Hemsted
6fc474a37f remove unused call to notification statistics 2016-08-11 12:07:50 +01:00
Leo Hemsted
3f3463b1ff Merge branch 'master' into remove-stats-from-send 2016-08-09 14:41:00 +01:00
Leo Hemsted
e2875ea66e Merge branch 'master' into remove-stats-from-send 2016-07-29 11:08:42 +01:00
Leo Hemsted
4ea23a7484 move away from statistics_api towards service_api 2016-07-29 10:28:18 +01:00
Leo Hemsted
2ab23fa4ef move weekly summary page over to new notifications/weekly endpoint 2016-07-28 16:23:22 +01:00
Leo Hemsted
eaf9b6dc54 pass 'today_only' flag to the back-end from send page 
also bump notification-utils requirement to 8.7.0 for changes
to RecipientCSV
 2016-07-25 15:26:43 +01:00
Leo Hemsted
45debe0d5b remove get_statistics_for_service_for_day from codebase 
two down, three to go
 2016-07-25 14:54:58 +01:00
Leo Hemsted
0accd88869 request stats for today from send page from GET /service/:id endpoint 
also amended test cases to ensure they mock out correct call
 2016-07-25 14:46:27 +01:00
Leo Hemsted
57e03349d2 remove get_statistics_for_service from statistics_api_client 2016-07-20 15:54:30 +01:00
Leo Hemsted
3ffd6c744c separate detailed and normal service_api_client.get_service 
to make it easier to mock and control return values
 2016-07-20 14:12:22 +01:00
Leo Hemsted
4451a8634d add detailed flag to GET service api client 
returns current (past 7 days) notification stats as well as service info
 2016-07-20 14:12:22 +01:00
Leo Hemsted
1cd2841c17 rename api_client to service_api_client 2016-07-15 15:23:23 +01:00
Rebecca Law
43938936f3 If a user has already registered with the email they will get a different email when the register again. 
The email includes likes to sign in and send feedback
 2016-07-12 11:53:30 +01:00
Rebecca Law
cdd666a23b Add api client call to email users that are already registered 2016-07-08 11:00:23 +01:00
Leo Hemsted
630b5df552 Save api_key.key_type from radio buttons 2016-07-06 15:10:36 +01:00
Adam Shimali
3bfcf0f8b3 Users can set a value that appears as the sender of a text message. 
It can be up to eleven characters alpha numeric, no special characters
allowed.
 2016-07-01 14:22:25 +01:00
Leo Hemsted
6ce087a7b5 send key_type = normal when creating api keys 2016-06-27 12:02:16 +01:00
Adam Shimali
f030d1cb8a Move check_messages in admin over to using get notification stats for 
day.
 2016-06-20 13:49:47 +01:00
Chris Hill-Scott
6d7d5a4e46 Make jobs filterable by notification status 
We can filter all notifications by status already. This commit reuses
the same code to filter the notifications for a job by status.

This means that, visually we can show the count on a job the same as
we do for all notifications, which is similar to how we show the counts
on the dashboard, so hopefully it feels like a bit more of a solid
thing.

This also applies to CSV downloads and AJAX updates, which will inherit
any filtering that their parent page has applied.
 2016-06-14 11:12:46 +01:00
Leo Hemsted
c4305d1610 only get template statistics for specific template 2016-06-07 14:28:02 +01:00
Adam Shimali
813e1c3351 Expand permissions to all possible values on admin before posting to 
api. This makes template work for both existing and invited users.

API will no longer need to convert from what ui presents as permissions
 2016-06-06 12:40:21 +01:00
Martyn Inglis
c9297459e2 Research mode 
- adds a new link on service settings page to switch service into/out of research mode
- platform admin only
- shows an indicator in the footer
 2016-06-01 16:07:43 +01:00
Leo Hemsted
f2cca024dd Merge pull request #619 from alphagov/platform-admin-stats 
Headline stats on the platform admin page
 2016-05-31 13:53:21 +01:00
Leo Hemsted
83b151982e add stats boxes to platform admin page 
moved a couple of stats summary functions from dashboard to a shared statistics_utils file
 2016-05-31 12:17:06 +01:00
Rebecca Law
6af2b71696 Removed the else statement in the job_api_client.get_job 2016-05-26 09:00:00 +01:00
Rebecca Law
47352af38a Add limit_days query param to the get_job endpoint. 2016-05-25 12:04:51 +01:00
Leo Hemsted
2f1a807be3 delete template button POSTs archived:true 2016-05-23 15:04:24 +01:00
Rebecca Law
c4de547b74 Merge pull request #568 from alphagov/template_history_view 
Template history view
 2016-05-17 08:50:40 +01:00
Adam Shimali
18a0b94d98 Admin app settings to save reply to email address for service. 2016-05-16 13:10:51 +01:00
Rebecca Law
fcf277c413 Merge branch 'master' into template_history_view 
Conflicts:
	requirements.txt
 2016-05-13 17:30:33 +01:00
Nicholas Staples
64e7a7b010 Update all dates to use utc, only in the template is it converted to british time. 
Template versions and template version pages added.

Fix merge changes.
 2016-05-12 21:34:39 +01:00
Martyn Inglis
6699442f6b Added provider management pages in. 
- see priority
- change priority
 2016-05-11 09:43:55 +01:00
Chris Hill-Scott
50427ecd3f Add a page to show delivery rates week-by-week 
Implements
https://github.com/alphagov/notifications-api/pull/286

Will always show weeks as Monday to Sunday.
 2016-05-05 10:56:20 +01:00
Adam Shimali
09117e5eeb Updated flask-login to version 0.3.2 2016-05-04 14:06:14 +01:00
Chris Hill-Scott
00030bc254 Add usage to the dashboard 
Takes the number of emails and SMS fragments sent from:
https://github.com/alphagov/notifications-api/pull/273

Using these numbers it’s possible to show:
- how much of your allowance is left
- or how much you have spent

For now the allowance and rates are hard coded.

Only for users that have manage service.
 2016-05-03 11:06:12 +01:00
NIcholas Staples
96297d2989 Merge pull request #522 from alphagov/sms_msg_limit 
Sms msg limit
 2016-04-29 12:29:45 +01:00
Nicholas Staples
471eac209e Handling template content size error. All tests passing. 2016-04-29 09:38:59 +01:00