Commit Graph

3745 Commits

Author SHA1 Message Date
Chris Hill-Scott
84de1c5625 Let caseworkers send one off messages
The main task that we think ‘caseworker’ users do is send one off
messages.

So this commit:
- makes sure users who don’t have the `view_activity` permission (ie
  not ‘admin’ users) can still send messages
- adds navigation so that these users have a place to go from which to
  start the process of sending a one off message
2018-07-05 11:53:42 +01:00
Chris Hill-Scott
2855cf45c7 Style of conditional radios to match design system
Updated thickness of border and spacing to match
https://design-system.service.gov.uk/components/radios/#conditionally-revealing-content
2018-07-05 11:47:31 +01:00
Chris Hill-Scott
6452676b54 Remove show/hide behaviour from permissions form
In research we found that:
- people didn’t initially realise that the permissions expanded when the
  ‘admin’ option was selected
- not having all the options visible at once makes it hard to know what
  permissions you are (and more importantly aren’t) giving to people

This commit makes it so that:
- the options within the ‘admin’ option are always visible
- a bit of Javascript logic makes it so you can pick ‘caseworker’ and
  ‘manage service’, for example (by deselecting one when you pick the
  other)
2018-07-05 11:47:31 +01:00
Chris Hill-Scott
f4d2958d58 Allow setting of caseworking on a user
This commit changes the form that the user sees when inviting or editing
another user, if the service has the ‘caseworking’ permission set.

This will allow creating a new type of user, one who only has the
`send_messages` permission, without the `view_activity` permission.

We are doing this because we think there are a number of services with a
lot of users who don’t need to see the dashboard, or the other team
members, and that we can make a simpler interface for these users.
2018-07-05 11:47:30 +01:00
Chris Hill-Scott
d952b5ca3c Refactor radios for reuse
This commit splits up the radio buttons macro into a couple of different
macros which can be used independently of each other.

This makes this code easier to reuse when implementing custom radio
controls.
2018-07-05 11:47:30 +01:00
Chris Hill-Scott
39bb0ecbf7 Make permission checking a method
Having a function that takes an instance as its only argument suggests
that it should instead be a method on that instance.
2018-07-05 11:47:30 +01:00
Chris Hill-Scott
1f0003903f Refactor form classes for future reuse
There are three parts to a ‘user’ form:
- the email address
- the permissions
- the auth type setting

This commit breaks them up into abstract classes so that they can be
composed more flexibly in future commits.
2018-07-05 11:47:29 +01:00
Chris Hill-Scott
a220ab7877 Encapsulate view_activity logic within the form
This means that:
- we don’t have to manually set it after processing the form
- we can set it dynamically based on some other attribute later on
2018-07-05 11:47:29 +01:00
Chris Hill-Scott
650f4cc3d8 Add platform admin button to enable caseworking
Eventually the ability to have the caseworking view for your service
will be self-service. But while we’re still building it only we should
be able to enable it, for our own testing purposes.

So this commit adds platform admin functionality to switch the feature
on and off for our services.
2018-07-05 11:47:29 +01:00
Chris Hill-Scott
239a43127d Merge pull request #2137 from alphagov/save-same-service-name
Don’t error if a user keeps same service name
2018-07-05 11:01:48 +01:00
Katie Smith
b27d29805b Raise error if getting complaints page with invalid page param
If the `page` parameter passed to the `platform-admin/complaints`
pageis not an integer, we should return a `404` error page.
2018-07-04 10:38:46 +01:00
Katie Smith
6c27a17e1e Paginate complaints page
The API now returns paginated complaint data, so the
`/platform-admin/complaints` page can now be paginated.
2018-07-03 11:09:33 +01:00
Katie Smith
f5bb2efc72 Merge pull request #2130 from alphagov/new-platform-admin-stats
Add new platform admin stats page
2018-07-03 08:57:47 +01:00
Rebecca Law
87e8f91b06 Merge pull request #2140 from alphagov/increase-page-size
Try increasing the page size
2018-07-02 15:58:15 +01:00
Rebecca Law
05caa102f0 Increasing the page size to see if we get more rows back the downloaded csv. 2018-07-02 15:48:00 +01:00
Chris Hill-Scott
6cc6b9d4da Add alternative cabinet office domain name 2018-07-02 14:26:12 +01:00
Chris Hill-Scott
d86291cb7a Don’t error if a user keeps same service name
Sometimes a user will hit the green button without actually changing
the service name (we saw this in a usability testing session).

Currently this gives an error saying ‘service name already in use’,
which is technically true (it’s in use by the current service) but
practically just annoying.

This commit adds some logic to silently ignore such requests.
2018-07-02 11:00:02 +01:00
Katie Smith
9c5fd5f23c Validate date format on new platform admin page
Check that the format of the dates entered is in the `YYYY-MM-DD` as
specified and show an error message if it is not. If the date was not in
the specified format, there would be no error message but the content of
the page would change which was misleading.
2018-06-29 15:31:41 +01:00
Katie Smith
ca16bef7f7 Add PlatformStatsAPIClient
In API, the endpoint for the new platform admin stats page has been
moved to a platform stats blueprint. This means we now need a platform
stats client.
2018-06-29 15:31:41 +01:00
Katie Smith
d9aeac4dca Add new platform admin page
Added a new platform admin page, at '/plaform-admin-new' which shows
different data. This no longer offers the option to filter by test-key,
only by date, and also gives a more detailed break-down of the
notifications and failures sent with a normal / research key.

The existing platform admin stats page ('/platform-admin') has not been
deleted yet so that both pages can be compared.
2018-06-29 15:31:40 +01:00
Katie Smith
7a40ad6ac0 Add new methods to Service and Complaint api clients
* Added a new method to the ComplaintApiClient to get the total
complaints by date range from the API.
* Added a new method to the ServiceAPIClient to get the new platform
admin stats data from the API.
2018-06-29 15:31:40 +01:00
Pete Herlihy
f829725d80 Adding sch.uk to the email domain list...
The DfE (Department for Education) has allocated every school in the country a domain name of the form of: www.schoolname.county.sch.uk.
2018-06-29 13:49:54 +01:00
Chris Hill-Scott
9cc5fd4713 Mark agreement signed by Ofgem 2018-06-28 17:15:14 +01:00
Chris Hill-Scott
adf1493fb5 Add guidance about horizontal lines
We’ve supported this for a while but don’t tell anyone how to do it.

This commit also alters the spacing of things so the description groups
better with the example.
2018-06-28 16:06:04 +01:00
Chris Hill-Scott
418a744283 Merge pull request #2129 from alphagov/gov.scot
Mark agreement signed by Scottish Government
2018-06-28 14:38:45 +01:00
Chris Hill-Scott
276047b1d6 Fix untypographic apostrophe 2018-06-28 10:53:27 +01:00
Rebecca Law
8deef9ada9 Merge pull request #2127 from alphagov/download-activity
Add the download activity link for notifications
2018-06-27 14:57:33 +01:00
Rebecca Law
472f87b325 Fix order of imports 2018-06-25 16:57:49 +01:00
Chris Hill-Scott
18b20574e1 Mark agreement signed by Scottish Government
We have it for the whole organisation now.
2018-06-25 16:48:03 +01:00
Rebecca Law
72b0637f92 Add the download activity link for notifications.
This works locally for a long running request and a large number of messages. However I suspect that nginx may be timing out the request. I'd like to try this on staging.
2018-06-25 16:29:40 +01:00
Leo Hemsted
4adee9cc43 Merge pull request #2125 from alphagov/handle-405s
handle 405 METHOD NOT ALLOWEDs
2018-06-25 11:40:17 +01:00
Leo Hemsted
e81f302084 handle 405 METHOD NOT ALLOWEDs
(show the "something went wrong" error page).

also catch any other werkzeug http exceptions and show an appropriate
template, if it exists
2018-06-22 18:07:18 +01:00
Chris Hill-Scott
a25f8207f7 Merge pull request #2122 from alphagov/kent.gov.uk
Mark agreement signed by Kent County Council
2018-06-21 14:59:02 +01:00
Chris Hill-Scott
3b0b090b22 Update count of services and organisations 2018-06-21 14:46:32 +01:00
Chris Hill-Scott
1a50650144 Merge pull request #2118 from alphagov/264-270
Updated service and org count on as at 18 June 2018
2018-06-21 14:39:20 +01:00
Chris Hill-Scott
42938e29b9 Fix syntax 2018-06-21 14:38:11 +01:00
Chris Hill-Scott
340fd1a2d0 Mark agreement signed by Kent County Council
Signed 20/6/2018
2018-06-21 09:43:38 +01:00
Chris Hill-Scott
6c0440225e Add Sussex, Tonbridge & Malling Borough Council
All three has signed the agreement recently.
2018-06-20 13:36:31 +01:00
Pete Herlihy
c381e22467 Updated service and org count on as at 18 June 2018
As per https://docs.google.com/spreadsheets/d/1JYhE5sJaOJUVMPPDenO2eKqElC75Rygxb1_2mpRKy98/edit#gid=503930061
2018-06-18 17:12:32 +01:00
Chris Hill-Scott
81dc9a0092 Merge pull request #2063 from alphagov/pyup-update-flask-0.12.2-to-1.0.2
Update flask to 1.0.2
2018-06-18 13:51:14 +01:00
Pete Herlihy
79161702b4 Snuck a new one in... 2018-06-15 17:06:00 +01:00
Pete Herlihy
e197e2b4fc 263 services and 86 organisations
Details here... https://docs.google.com/spreadsheets/d/1JYhE5sJaOJUVMPPDenO2eKqElC75Rygxb1_2mpRKy98/edit#gid=0
2018-06-15 16:55:00 +01:00
Pete Herlihy
81de3701b5 Found a couple of commas down the back of the sofa.... 2018-06-15 16:03:45 +01:00
Pete Herlihy
2e6deaabeb Added the message back 2018-06-15 15:33:21 +01:00
Pete Herlihy
7dcbad1ba8 Tidied up the formatting on the feedback tickets 2018-06-15 15:30:45 +01:00
Pete Herlihy
669a8a7053 Tweaked the formatting of the Zendesk messages 2018-06-15 15:11:13 +01:00
Katie Smith
0633af4e4a Truncate contact link text on settings page
The contact link on the settings page should be truncated instead of the
text being wrapped and overflowing on to multiple lines. This adds in an
option to the text_field macro to truncate long text fields. This
setting has been used to truncate the API callback URLs too on the
services/<service_id>/api/callbacks page.
2018-06-12 10:21:24 +01:00
Katie Smith
33277ce3e2 Make a contact_link required when turning upload_document permission on
When a platform admin user clicks on the button to add the
'upload_document' permission to a service, they should be taken to the
page to add a contact_link if the service does not already have one.
2018-06-12 10:21:24 +01:00
Katie Smith
8a559aceb5 Display contact link on service settings page
The contact link for the service now gets displayed on the service
settings page if the service has the 'upload_document' permission. There
are no changes to the appearance of the service settings page if a
service does not have the 'upload_document' permission.
2018-06-12 10:21:24 +01:00
Katie Smith
02988c224b Merge pull request #2100 from alphagov/contact-url-page
Add page to change a service's contact link
2018-06-12 10:20:51 +01:00