Commit Graph

5701 Commits

Author SHA1 Message Date
karlchillmaid
b27fd30d45 Replace wasn't with was not 2019-09-23 13:22:16 +01:00
karlchillmaid
4b2990e735 Replace isn't with is not 2019-09-23 13:22:00 +01:00
karlchillmaid
90b8af63d5 Replace isn't with is not 2019-09-23 13:22:00 +01:00
karlchillmaid
73ce6eef83 Replace won't with will not 2019-09-23 13:22:00 +01:00
karlchillmaid
653c2c399f Replace won't with will not 2019-09-23 13:21:59 +01:00
karlchillmaid
4c6f32df73 Replace won't with will not 2019-09-23 13:21:59 +01:00
karlchillmaid
2b0462f44f Replace won't with will not 2019-09-23 13:21:59 +01:00
karlchillmaid
5fea8739cd Replace won't with will not 2019-09-23 13:21:59 +01:00
karlchillmaid
c62f4ed706 Replace won't with will not 2019-09-23 13:21:59 +01:00
karlchillmaid
8811903040 Replace won't with will not 2019-09-23 13:21:59 +01:00
karlchillmaid
89ecee5d6f Replace don't with do not 2019-09-23 13:21:58 +01:00
karlchillmaid
6163b6f65f Replace don't with do not 2019-09-23 13:21:58 +01:00
karlchillmaid
fc4eb24795 Replace don't with do not 2019-09-23 13:21:58 +01:00
karlchillmaid
4f7d618d89 Update content to remove negative contraction 2019-09-23 13:21:58 +01:00
karlchillmaid
c96e29e1e8 Replace don't with do not 2019-09-23 13:21:58 +01:00
karlchillmaid
cc9bb476e5 Replace don't with do not 2019-09-23 13:21:57 +01:00
karlchillmaid
1a603c8d48 Replace can't with cannot 2019-09-23 13:21:08 +01:00
karlchillmaid
42663947fa Replace can't with cannot 2019-09-23 13:21:07 +01:00
karlchillmaid
fdb3ecc7d3 Replace can't with cannot 2019-09-23 13:21:07 +01:00
karlchillmaid
5f79a12a9d Replace can't with cannot 2019-09-23 13:21:07 +01:00
karlchillmaid
aa1e857e03 Replace can't with cannot 2019-09-23 13:21:07 +01:00
karlchillmaid
123d12bcdd Replace can't with cannot 2019-09-23 13:21:07 +01:00
karlchillmaid
4b23729ff6 Replace can't with cannot 2019-09-23 13:20:25 +01:00
karlchillmaid
0ff57d8514 Replace can't with cannot 2019-09-23 13:20:25 +01:00
karlchillmaid
92d3b99c7e Replace can't with cannot 2019-09-23 13:20:25 +01:00
karlchillmaid
3d36a99518 Replace can't with cannot 2019-09-23 13:20:24 +01:00
karlchillmaid
ce9d509601 Replace can't with cannot 2019-09-23 13:20:24 +01:00
karlchillmaid
a2455abda4 Replace can't with cannot 2019-09-23 13:20:24 +01:00
Chris Hill-Scott
68c9147fec Merge pull request #3119 from alphagov/retire-old-static-content
Retire old static content pages
2019-09-23 13:19:01 +01:00
Chris Hill-Scott
56772533e6 Replace negative contraction with Cannot
In accordance with style guide
2019-09-18 14:21:25 +01:00
Chris Hill-Scott
20f857753a Use constants for organisation type
This reduces the chances of making a typo, because doing so will raise
an exception rather than fail silently.
2019-09-16 11:33:50 +01:00
Chris Hill-Scott
077dc194c6 Tell people to change their branding
In some cases it’s not appropriate for teams to have GOV.UK branding.
But they all start with it by default, if we can’t make a better guess.
We should be more explicit about this to reduce the number of teams
sending emails with the wrong branding.
2019-09-16 11:21:28 +01:00
Chris Hill-Scott
86e3da043f Remove old branding illustrations
These aren’t used any more.
2019-09-16 11:21:07 +01:00
Chris Hill-Scott
59ab064185 Play back current branding
We get a few tickets at the moment where people are asking for the
branding they already have.

We think that playing back the name of the branding on this page should
reduce how often that happens.
2019-09-16 11:20:23 +01:00
Chris Hill-Scott
afcdedf598 Allow elaboration when ‘something else’ is chosen
Letting people input a bit of free text should reduce the amount of back
and forth we have to do over support tickets when setting up someone’s
branding.

If something else is the only option then we don’t show the radio button
at all and have just the free text input on the page (not behind a
progressive disclosure).
2019-09-16 11:18:22 +01:00
Chris Hill-Scott
6d0d10e8de Only show relevant choices of email branding
Users who work in local government can’t have GOV.UK branding on their
emails. And only those working for Companies House (for example) can
request the Companies House branding.

This commit adds:
- new choices of email branding, which offer the name of the branding,
  rather than the style
- logic to filter this list to only the applicable options, based on
  what we know about the user, service and organisation

This is a change from the previous approach which put the onus on users
to figure out the style of branding they wanted, when we might already
know that a lot of the options weren’t available to them, or would be
inconsistent with the branding of other services in their organisation.
2019-09-16 11:03:52 +01:00
Chris Hill-Scott
29a0611e42 Refactor organisation branding into model
This is the same way we handle lazy-loading the branding in the service
model.
2019-09-16 11:02:34 +01:00
Katie Smith
81da8e762d Update for new template preview sanitise response 2019-09-12 09:54:36 +01:00
Katie Smith
79053dec93 Allow uploaded letters to be sent if valid
Added a send button which only appears on the page if the query string
indicates that the PDF is valid. Before actually sending, we check that
the service has the right permissions and that the metadata for the
letter confirms the letter is valid (because the query string can be
changed).
2019-09-12 09:54:36 +01:00
Katie Smith
7368245c9a Show letter preview once file is uploaded
This shows the sanitised letter preview if the file had no validation
errors or the preview with the overlay if it failed validation.
2019-09-12 09:54:36 +01:00
Katie Smith
8a322b844b Sanitise uploaded letters and store in S3
This sanitises uploaded letters and stores the sanitised result in S3
with if it passes validation or the original PDF in S3 if validation
fails. A metadata value of 'status' is set to either 'valid' or
'invalid'.
2019-09-12 09:54:36 +01:00
Katie Smith
5fa9e071c7 Add check that PDF file can be opened and is not malformed
This checks that the PDF file is not malformed in some way (e.g. by
missing the EOF marker). We check this by trying to get the page count
of the letter which will be needed to display the preview of the letter.
2019-09-12 09:54:36 +01:00
Katie Smith
a103dbf801 Add max file size check when uploading a letter 2019-09-12 09:54:36 +01:00
Katie Smith
be6b5b922a Add virus scan stage when uploading a letter 2019-09-12 09:54:36 +01:00
Katie Smith
c577416866 Add letter upload form which redirects to blank preview page
Added a form to upload a single letter. Currently this only uses the
form to validate that a file is submitted and that the file is a PDF. If
either of these validations fail, the form will display an error.
Otherwise, we redirect to a new preview page which just has the filename
as the heading for now.
2019-09-12 09:54:36 +01:00
Chris Hill-Scott
47d5593f5f Merge pull request #3114 from alphagov/no-ie8
Remove code specific to IE8 and below
2019-09-11 11:14:27 +01:00
Chris Hill-Scott
8b8893ed1d Let NHS Trusts and CCGs choose own organisation
All we do via support is ask which organisation they work for and
manually assign their service to it. This commit makes that process self
service.

We think we have all the trusts and clinical commissioning groups
loaded into the database now.

This will make the go live process smoother for these teams.
2019-09-06 16:26:51 +01:00
Chris Hill-Scott
d37566a79b Merge pull request #3117 from alphagov/gp-self-define
Let GP surgeries create their own organisations before going live
2019-09-06 16:24:25 +01:00
karlchillmaid
71fe13652d Change 'the' to 'our'
Change 'the' to 'our' for consistency
2019-09-05 16:55:30 +01:00
karlchillmaid
9e79f5bd75 Add 'API' to the link for clarity 2019-09-05 16:47:28 +01:00