darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-07 11:53:52 -05:00
Code Issues Packages Projects Releases Wiki Activity
9,321 Commits 52 Branches 59 Tags
4e42fa6f5d2bb1c8f0ecf5c129d33e82dd1f1abe
Commit Graph

13 Commits

Author SHA1 Message Date
Tom Byers
174c10c7ff Clear old cookies to be based on consent 
We have been clearing all the Google Analytics
cookies on each page request.

It is now possible for a user to consent to having
Google Analytics cookies so this should have been
checking for that before deleting them.

This makes that change, with tests for those
scenarios.
 2020-01-22 12:14:23 +00:00
Tom Byers
9a0d522964 Add JS tests for analytics & cookies JS 
Includes:
- tests for the analytics interface ported from
  GOVUK Frontend Toolkit
- tests for the cookie banner that appears on all
  pages except the cookies page
- tests for the cookies page JS
- tests for the hasConsentFor function
- adding a deleteCookie helper to remove
  cookies during tests
- polyfill for insertAdjacentText

The last one is because JSDOM doesn't support
insertAdjacentText but our target browsers
do. This polyfill also includes one for
insertAdjacentHTML.
 2020-01-20 10:03:36 +00:00
Leo Hemsted
66db735e09 Revert "Merge pull request #3238 from alphagov/cookies-update" 
This reverts commit eec4bec761, reversing
changes made to 64480e2fff.
 2020-01-15 14:40:48 +00:00
Tom Byers
900aa19bd3 Add JS tests for analytics & cookies JS 
Includes:
- tests for the analytics interface ported from
  GOVUK Frontend Toolkit
- tests for the cookie banner that appears on all
  pages except the cookies page
- tests for the cookies page JS
- tests for the hasConsentFor function
- adding a deleteCookie helper to remove
  cookies during tests
- polyfill for insertAdjacentText

The last one is because JSDOM doesn't support
insertAdjacentText but our target browsers
do. This polyfill also includes one for
insertAdjacentHTML.
 2020-01-06 13:38:34 +00:00
Tom Byers
47781cc929 Change treatment of space character in URLs 
jQuery changed it from using '+' to '%20' between
versions 1 and 3. This updates the test to match.
 2019-11-11 12:08:21 +00:00
Tom Byers
3fba2c381d Make screenMock helper mock more DOM APIs 
jQuery 3 also calls `.getClientRects` to get the
position and dimension of elements.
 2019-11-08 17:37:06 +00:00
Tom Byers
2a7f464df7 Merge pull request #3106 from alphagov/add-js-tests-for-preview-pane 
Add js tests for preview pane
 2019-10-23 15:22:23 +01:00
Tom Byers
a67d1901c0 Add mock for window.location 2019-10-03 07:56:57 +01:00
Tom Byers
2fdf8161d2 Fix radios helpers 
They were using a 'name' property which wasn't
being set in the data. Radios share the same name
attribute so they can get it from the parent
group.

Also includes fixes for tests where the original
API is used.
 2019-10-03 07:56:57 +01:00
Tom Byers
bbb1ca33e9 Add utility helper for making form data sendable 
Useful for assertions where the data you're
comparing is already in this format.
 2019-10-03 07:56:22 +01:00
Tom Byers
5bd1e4bb7e Move template list fixture function into helpers 
This will be needed in other tests so should be
made into a helper.
 2019-10-01 08:26:08 +01:00
Tom Byers
3c1576dacf Add helper for mocking/stubbing form.submit 
JSDOM doesn't implement the submit method on form
elements. It does have a submit method but this
just fires a 'not implemented' error.

We need to spy on form submissions fired by
clicking on the submit button but can't because
this event calls the submit method internally so
spying on `form.submit` doesn't work.

This adds a helper which spies on the internal
method that is actually called. When JSDOM
implements the submit method properly this should
be removed.
 2019-09-05 10:52:13 +01:00
Tom Byers
baf8c1fddb Split helpers into separate files 2019-08-27 17:00:22 +01:00