Commit Graph

3753 Commits

Author SHA1 Message Date
Chris Hill-Scott
901b924e35 Remove redundant variable definition
This unused variable is a hangover from when the permissions
were displayed horizontally in a table.
2018-09-25 17:00:54 +01:00
Pea (Malgorzata Tyczynska)
6d32d8b756 Merge pull request #2324 from alphagov/state_postage
Display postage on letter notification page
2018-09-25 13:36:34 +01:00
Pea Tyczynska
d982385042 Change wording following content review 2018-09-25 11:05:32 +01:00
Chris Hill-Scott
5dd45da08c Add line about MOU to checklist
2/3 of our incomplete requests to go live are incomplete because the
Data Sharing and Financial Agreement isn’t signed.

We reckon we can be pushier about this by saying it’s ‘incomplete’ where
we know the agreement is signed.

Where the agreement is signed we should confirm this, rather than make
the line disappear. This is so it makes more sense to someone who sees
it as ‘incomplete’, signs it, then comes back to the page.

If we don’t know whether or not the agreement is signed we should wait
until someone has got in touch with us by requesting to go live to
figure it out. So that’s why we’re not showing that line at all.
2018-09-25 10:33:50 +01:00
Chris Hill-Scott
c2ef522986 Make task list read better for screen readers
This duplicates how the task list pattern is coded in the GOV.UK
Prototype kit[1]. It adds ARIA attributes and the use of a
semantically-meaningful element (`<strong>`) to give more information to
screen reader users.

1. https://govuk-prototype-kit.herokuapp.com/docs/templates/task-list
2018-09-25 10:31:40 +01:00
Chris Hill-Scott
45b1b11abb Refactor go-live readyness into service model
All this info is info about the service. So it’s better to put it on
the service model because:
- encapsulation
- later reuse
2018-09-24 14:52:30 +01:00
Pea Tyczynska
64f356d7b0 Display postage on letter notification page 2018-09-24 11:29:33 +01:00
Katie Smith
fee47aa348 Hide Postage setting when letters are not enabled for service
We don't show the sender addresses and letter branding on the settings page
if a service doesn't have letters enabled, so we should also hide the
postage for services that can't send letters.

(Postage can only be seen by Platform Admin users at the moment, but this will
change later).
2018-09-20 15:46:32 +01:00
Katie Smith
2726467fc7 Minor quote and heading fixes 2018-09-19 16:53:31 +01:00
Chris Hill-Scott
d9da219b7e Use a macro for form tags
This will stop us repeatedly forgetting to add `novalidate` and
`autocomplete='off'` to our forms (which is how most of them are set
up).

It uses sensible defaults, based on how we most-commonly configure
forms:
- most of our forms are `post`ed (but this can be overridden)
- `autocomplete` should only be enabled where it makes sense, otherwise
  it’s more annoying than useful (but this can be overriden)
- we should never be using HTML5 form validation because our own error
  styles and messages are better
2018-09-19 12:43:15 +01:00
Chris Hill-Scott
5ab876aeab Don’t trigger HTML5 validation on go live request
We should probably have a reusable thing for this…
2018-09-19 11:34:20 +01:00
Katie Smith
9660f372f3 Change naming in code to use 'postage'
Renamed everything that was previously called 'letter class' or 'postage
class' to 'postage', which is the new name we have decided to use.
2018-09-19 09:20:09 +01:00
karlchillmaid
eb9768c91b Removed heading above radios
Removed heading above radios
2018-09-18 11:14:11 +01:00
karlchillmaid
02ad9ed0a3 Updated postage labels
Updated postage labels
2018-09-18 11:13:32 +01:00
karlchillmaid
c125e24432 Updated postage content
Updated postage content
2018-09-18 11:05:33 +01:00
Katie Smith
de9759b99a Add letter class row to settings page, visible to platform admin
Added a new row to the settings table, 'Post class', which shows the
default letter class of a service and is only visible to Platform Admin.

Also added a new page to enable Platform Admin users to change the
default letter class for a service - this only has two options at the
moment, 1st class only and 2nd class only.
2018-09-18 10:31:01 +01:00
Katie Smith
afeb0d44e2 Merge pull request #2304 from alphagov/346-362
Updated service and org count to 362 and 115
2018-09-12 10:36:04 +01:00
karlchillmaid
7c460302a0 Merge pull request #2270 from alphagov/add-document-download-guidance-to-template
Add 'send a document by email' guidance to email template formatting guidance
2018-09-12 10:11:54 +01:00
Pete Herlihy
8b6b7a39d1 Updated service and org count to 362 and 115 2018-09-11 16:55:10 +01:00
karlchillmaid
22b6b8f412 Added a reminder to upload the document
Added a reminder to upload the document using the API.
2018-09-10 14:47:22 +01:00
Chris Hill-Scott
3b889ec0fe Merge pull request #2299 from alphagov/friendlier-datetimes
Use friendlier relative dates for ‘last edited’
2018-09-10 11:55:11 +01:00
Alexey Bezhan
5198009550 Merge pull request #2300 from alphagov/submit-returned-letters
Add a platform admin page to submit returned letter references
2018-09-07 15:06:24 +01:00
Chris Hill-Scott
09daf03ec9 Merge pull request #2290 from alphagov/link-to-notification
Link to single notification page from API integration page
2018-09-07 13:25:57 +01:00
Chris Hill-Scott
08d40526b8 Make sure brands with no name can still be clicked 2018-09-07 11:45:44 +01:00
Alexey Bezhan
b75681dfbc Add a platform admin page to submit returned letter references
A platform admin form accepts a list of references (one per line)
received from DVLA and sends them to the API to update notification
statuses.

References we get from DVLA start with `NOTIFY00\d`, which isn't
part of the reference we store in the database, so we remove them
before sending the data to the API.

The new `returned-letter` status should be treated as `delivered`
for now until we decide a way to display returned letters to users.
2018-09-07 11:13:01 +01:00
Chris Hill-Scott
c76b865d88 Use friendlier relative dates for ‘last edited’
Because ‘2 months ago’ is more human-sounding than ‘70 days ago’.

Using this pattern (borrowed from the API integration page) will also
use Javascript to keep the time updated, so ‘just now’ will turn into
‘1 minute ago’ without having to reload the page.
2018-09-06 16:19:41 +01:00
Chris Hill-Scott
afe6d04d96 Merge pull request #2298 from alphagov/no-html5-validation
Don’t use HTML5 validation on email branding form
2018-09-06 16:10:23 +01:00
Chris Hill-Scott
8978aa33c6 Don’t use HTML5 validation 2018-09-06 16:03:28 +01:00
Chris Hill-Scott
7010c0fbd5 Remove annoyances from email branding forms 2018-09-06 15:50:54 +01:00
Chris Hill-Scott
3ed0cc1437 Fix live search on email brand selection
At some point the element with a `class` of `brand-styles` was removed
from the page, meaning the search stopped working.
2018-09-06 12:02:40 +01:00
Chris Hill-Scott
e4341f5d5b Indicate messages sent with a test key
If a message has been sent with a test key it’s a bit confusing to just
say ‘Delivered’ on the page, because it hasn’t gone to anyone’s phone.

So this commit adds a bit of hint text to disambiguate what ‘Delivered’
actually means in this context.
2018-09-06 10:50:19 +01:00
Chris Hill-Scott
2ddf3d5cfe Link to notification from API integration
It’s useful to be able to see what the email or text message looks like,
especially if you’ve sent it with a test API key (so it isn’t in your
inbox or on your phone). We already have the page for this, so we just
need to link to it.
2018-09-06 10:50:18 +01:00
Chris Hill-Scott
46dcaf3e54 Mark which brands are used as default on list
So that:
- we can see when a brand should be getting used as a default but isn’t
- we’re careful updating brands which will get auto-applied to new
  services
2018-09-05 10:32:44 +01:00
Chris Hill-Scott
f387f1e6ba Merge pull request #2268 from alphagov/request-to-go-live-better-data
Make the data we get from the go live requests more useful
2018-09-04 16:25:59 +01:00
karlchillmaid
42417b3509 Removed link to documentation
Removed link to documentation until we have Features content we can link to, or the documentation has been updated.
2018-09-04 10:02:54 +01:00
karlchillmaid
3f3f8c5977 Reinstated link to API client documentation
Reinstated link to API client documentation because we're only showing this guidance to users who already have the send a document feature.
2018-09-03 17:04:21 +01:00
Chris Hill-Scott
891ae95d2b Restrict DD guidance to teams who can use it
Document download is in private beta, which means most teams using
Notify can’t see or use it.

We shouldn’t confuse people by showing them this guidance, especially
while it’s API-only.
2018-09-03 16:21:42 +01:00
karlchillmaid
80070797f4 Added filename extension
Added filename extension
2018-09-03 15:05:19 +01:00
karlchillmaid
3bbb944786 Added send a document guidance to the template
Added send a document guidance to the template
2018-09-03 15:03:44 +01:00
karlchillmaid
7ce12c88c9 Commented out the link to documentation
Commented out the link to documentation because sending a document is only described in the Python documentation at the moment.

Discussed with Chris H:
Added a line asking users to contact the team. Support can explain the situation if we get any requests. We'll remove this and reinstate the original line once this feature is available across more API clients and the documentation is updated.
2018-09-03 13:37:02 +01:00
Tom Byers
3655e63d34 Merge pull request #2262 from alphagov/remove_branding_type_from_set_email_branding_page
Remove branding type from set email branding page
2018-08-31 13:56:44 +01:00
Chris Hill-Scott
d2503e8a26 Merge pull request #2266 from alphagov/remove-reference-to-service-branding
Remove reference to service branding on the settings page
2018-08-31 13:48:29 +01:00
Chris Hill-Scott
7f458ad066 Explain text message sender
We sometimes have to do this over support tickets as part of the go-live
process; now we’re directing people to add a sender (as part of the task
list) we can explain what it is in context.
2018-08-31 10:50:59 +01:00
karlchillmaid
6ccd0e6775 Added send a document by email guidance
Added send a document by email guidance
2018-08-30 16:56:09 +01:00
Chris Hill-Scott
86ad77e545 Add question about research consent
Since GDPR came into effect it’s less clear about whether we can
contact teams for user research purposes.

If we make people opt-in (or not) we know we’re safe to contact them (or
not).

Since we mostly care about how services are using Notify for real (ie
live services) or services that are considering adopting it (ie those
who have contacted us with a question) it feels like the go-live process
is the most appropriate place to collect this consent.
2018-08-30 15:31:46 +01:00
Chris Hill-Scott
12e0e12ced Replace channels and volumes with volumes/channel
Now that we’re a more mature platform we don’t care so much about the
load that one service might put on our platform.

We do care about intended volumes for two reasons:
- modelling the benefits that services get from using Notify
- managing stocks of envelopes (while our letter volumes are small
  enough that they could be skewed by one new service)

Changing to the ‘how many per year’ question also has the benefit of
mapping directly to the data we store in the ‘beta partners’
spreadsheet.
2018-08-30 15:31:46 +01:00
Chris Hill-Scott
80339046df Remove question about which features people use
This is an optional question. We don’t really use the answer to it now
that we have some adoption of all these features.
2018-08-30 15:31:45 +01:00
Chris Hill-Scott
2ff81ea59d Reword templates line on go live task list
This version might read a little clearer and look a little neater.
2018-08-30 14:36:40 +01:00
Pete Herlihy
18985821a9 Advising about future letter pricing from 1 October
This is just the pricing page, we'll sort the pricing table etc separately...

W're removing non-crown pricing as we won't be charged differently any more.  But we will retain the concept of non-crown as we may change differently ourselves in the future.
2018-08-30 11:53:52 +01:00
Chris Hill-Scott
896072f169 Remove reference to service branding on settings
This attribute is deprecated in favour of an attribute on the
`email_branding` itself.
2018-08-30 09:20:44 +01:00