Kenneth Kehl
8c9721d8e2
notify-api-412 use black to enforce python coding style
2023-08-25 09:12:23 -07:00
Kenneth Kehl
476644369d
notify-admin-211 remove nhs-specific code
2023-08-24 07:49:42 -07:00
Steven Reilly
13d0e46b52
blunt rename of org ( #620 )
2023-07-12 12:09:44 -04:00
stvnrlly
944715ac46
big commit with letters removal
2022-12-05 15:33:44 -05:00
stvnrlly
3e7b5b4370
update tests based on updated orgs
2022-09-15 18:47:04 +00:00
Ben Thorner
6030e9e5bb
Decouple the set of org types from their labels
...
In response to: [^1].
[^1]: https://github.com/alphagov/notifications-admin/pull/4196#discussion_r838383086
2022-03-30 17:46:53 +01:00
Ben Thorner
8a7eed9b26
Minor refactorings to help read branding rules
...
I did consider having a "has_govuk_branding" variable, but I think
it's better to reinforce what this means with comments.
2022-03-30 17:46:42 +01:00
Ben Thorner
1cc5413f96
Move and clarify "NHS_BRANDING_ID" constant
...
This is specific to email branding [^1]. Using the name to match
the current branding is more error-prone.
[^1]: a165f62b60
2022-03-30 17:46:41 +01:00
Ben Thorner
21eea0189d
DRY-up listing NHS organisation types
...
The model should be the source of truth for this.
2022-03-30 17:46:40 +01:00
Ben Thorner
8f55972aae
Split "get_available_choices" by branding type
...
We already had different functionality for email branding and will
soon be adding more for email branding pools.
Note that the "get_available_choices" class method was only used for
email branding - we can do it in the constructor for letters.
2022-03-30 17:46:39 +01:00
Ben Thorner
2fc0a105f4
Move branding choices logic into utility module
...
This was a lot of code to be in a form and it's going to get even
more complicated with email branding pools. Moving it out means we
can also simplify the tests that target this code.
2022-03-15 11:47:16 +00:00
