darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-06-25 01:41:19 -04:00
Code Issues Packages Projects Releases Wiki Activity
2,696 Commits 57 Branches 61 Tags
270e3c17dda1be3fc4e8d3b6aa8a2b17a1cd69dd
Commit Graph

1817 Commits

Author SHA1 Message Date
Chris Hill-Scott
270e3c17dd Reword questions to make sense with radio buttons 2016-11-01 11:39:57 +00:00
Chris Hill-Scott
d832a9107c Use radio buttons not textboxes for multi-choice 
No need to make people type when they can click, and gives us consistent
data.
 2016-11-01 11:39:22 +00:00
Chris Hill-Scott
fc60016566 Remove ‘all services’ page 
It’s not needed any more, because the platform admin page does the same
thing better.
 2016-10-30 09:16:46 +00:00
Chris Hill-Scott
14b99e5a24 Go to platform admin page when logging in 
If you’re a platform admin, you should go straight to the platform admin
page when you log in.

The all services page is just a crappier version of the same thing,
without all the stats, etc.
 2016-10-30 09:16:35 +00:00
Leo Hemsted
ef00427564 Merge pull request #1001 from alphagov/service-email-fix 
ensure robustness of email_safe function
 2016-10-28 16:18:11 +01:00
Leo Hemsted
c6291a614e Update request-to-go-live.html 
fix typo
 2016-10-28 16:16:26 +01:00
Leo Hemsted
a5d228d837 ensure robustness of email_safe function 
* remove leading, trailing, or consecutive periods
* strip unicode accents, umlauts, diacritics etc
 2016-10-28 16:11:08 +01:00
imdadahad
847bb8ed57 Merge pull request #998 from alphagov/invite-nongov-users 
Invite nongov users
 2016-10-28 15:40:37 +01:00
Imdad Ahad
f3a4432ed7 Stop non-gov user seeing/changing email and add test 2016-10-28 11:45:05 +01:00
Imdad Ahad
e58b63f504 Update regex/config and remove unused imports 2016-10-28 11:44:35 +01:00
Imdad Ahad
2676ee9bcf Add additional tests and refactor 2016-10-28 10:47:32 +01:00
Imdad Ahad
5ecdbb8596 Refactor to use a cleaner and lean regex 2016-10-28 10:45:05 +01:00
bandesz
df313ad3d4 Add minimal 404 page for Cloudfront 2016-10-27 13:13:49 +01:00
Leo Hemsted
26a985720c fix 500 errors with excel files > 500k size limit 
werkzeug's internal workings keep files under 500kb in memory, and files
greater than 500kb as a TemporaryFile

(https://github.com/pallets/werkzeug/blob/0.11-maintenance/werkzeug/formparser.py#L38)

when we encounter a CSV or TSV, we call normalise_newlines, which invokes
`.read()`, however when we were passing straight into pyexcel, we called
`file.getvalue()` - this exists on BytesIO (small files) but not on
TemporaryFile objects (large files) - we were seeing 500 errors
 2016-10-26 16:35:14 +01:00
Imdad Ahad
da0c03e8a1 Remove gov-only email text on page 2016-10-26 14:02:23 +01:00
Imdad Ahad
1fb0e22570 Update forgotten password to allow non-gov with test 2016-10-26 14:01:01 +01:00
Imdad Ahad
bb85782230 Remove link for adding service if nonwhitelist user 2016-10-25 18:12:46 +01:00
Imdad Ahad
84762edef4 Abort 403 if nonwhitelist user tries to add service 2016-10-25 18:11:37 +01:00
Imdad Ahad
f33e0d0e94 Add function to check if given email in whitelist 2016-10-25 18:10:15 +01:00
Imdad Ahad
1b046ab94d Update invite user form to allow non-whitelist users through 2016-10-25 18:08:20 +01:00
imdadahad
a93333572f Merge pull request #995 from alphagov/fix-500s 
Fix 500s
 2016-10-25 12:20:31 +01:00
Pete Herlihy
7bf18c9fd1 Merge pull request #997 from alphagov/go-live-page 
Updated the request to go live page
 2016-10-24 16:28:18 +01:00
Imdad Ahad
a707bd546c Updates: 
* Fix tests
* Add tests for new message format
 2016-10-24 16:10:41 +01:00
Pete Herlihy
ae48bdef98 Made the request to go live fields mandatory 2016-10-24 15:46:22 +01:00
Pete Herlihy
24cad78ecb Reverting width of fields to 100% on request to go live 2016-10-24 15:38:00 +01:00
Imdad Ahad
462bacb88c Merge branch 'go-live-page' of github.com:alphagov/notifications-admin into go-live-page 2016-10-24 15:36:07 +01:00
Imdad Ahad
876832801e Fix tests and other bits 2016-10-24 15:35:51 +01:00
Pete Herlihy
0bb7fdb216 Added non breaking space to the request to go live page 2016-10-24 15:33:13 +01:00
Pete Herlihy
3c53a8a269 Added reminder to get MoU in place to top of terms page 2016-10-24 14:44:38 +01:00
Pete Herlihy
8cddc327f8 Added MoU banner warning to the request to go live page 2016-10-24 14:36:37 +01:00
Imdad Ahad
0bde2d238f Fix casing and multi-line stuff 2016-10-24 13:38:55 +01:00
Pete Herlihy
0706909419 Reduced field widths to half on go live page 2016-10-24 13:17:50 +01:00
Pete Herlihy
f343d23915 Added new request to go live fields to deskpro tickets 2016-10-24 13:01:23 +01:00
Pete Herlihy
3ff5be00a8 Added new form elements to request to go live page 2016-10-24 12:52:51 +01:00
Pete Herlihy
7c74864dfe Added request to go live form elements 2016-10-24 12:45:45 +01:00
Imdad Ahad
76a61ff737 Update dashboard json endpoints: 
* Remove login_required decorator
 2016-10-21 17:36:42 +01:00
Imdad Ahad
a05a36f2a8 Remove newline 2016-10-21 14:28:55 +01:00
Imdad Ahad
2a2a733a41 Fix 500s when requesting json after logged out: 
* Update permissions decorator to make sure user is logged in first, else 401
* Stop further ajax json calls on failure
 2016-10-21 14:24:21 +01:00
Leo Hemsted
09d7f6e8a6 Merge pull request #992 from alphagov/logging 
Add error logging
 2016-10-19 17:33:07 +01:00
Chris Hill-Scott
61328e21fc Add a scary banner 2016-10-19 13:30:15 +01:00
Chris Hill-Scott
27154bd9d2 Remove links to new pages 
So that we can iterate them a bit first.
 2016-10-19 13:20:07 +01:00
Henry Hadlow
e4c2fba33d Add Design patterns and content guidance 2016-10-19 13:05:43 +01:00
Henry Hadlow
db30e7aea1 Add Information security guidelines 2016-10-19 13:05:16 +01:00
Henry Hadlow
de53e9dd24 Fix quote mismatches in footer nav 2016-10-19 13:04:50 +01:00
Henry Hadlow
f5dd38769d Rearrange routes to same order as in footer nav 2016-10-19 13:03:42 +01:00
Leo Hemsted
3058a7122e log exceptions in the admin app 
(we weren't previously logging anything on error!)
 2016-10-19 11:54:51 +01:00
Leo Hemsted
bd07aa97a7 remove monotonic as a dependency 
"On Python 3.3 or newer, monotonic will be an alias of time.monotonic from the standard library"
 2016-10-19 10:39:22 +01:00
Chris Hill-Scott
2d2e701e22 Open links to documentation in new tabs 
Because users have difficulty getting back to the Notify admin
interface.

The `rel` attribute mitigates against [a nasty cross-domain
vulnerability](https://mathiasbynens.github.io/rel-noopener/).
 2016-10-18 13:50:25 +01:00
Chris Hill-Scott
6946d3af54 Make API key combination of secret and service ID 
In research we’ve seen people mix up the service ID and API key because
they’re both 36 character UUIDs. We can’t get rid of the service ID
because it’s used to look up the API key.

Instead, we should change API key to be one long string, which contains
both the service ID, API key and (optionally) the name of the key. For
example:

```
casework_production-8b3aa916-ec82-434e-b0c5-d5d9b371d6a3-dcdc5083-2fee-4fba-8afd-51f3f4bcb7b0
```

We still need to keep the old, separate, key and service ID for a while
until people have updated their clients. But they’re now both on this
page, rather than on two separate pages, which should make for less
fussing anyway.

This shouldn’t be rolled out until the new clients are available.

- [ ] https://github.com/alphagov/notifications-python-client/pull/36
- [ ] https://github.com/alphagov/notifications-node-client/pull/10
- [ ] https://github.com/alphagov/notifications-ruby-client/pull/15
- [ ] https://github.com/alphagov/notifications-java-client/pull/38
- [ ] PHP????
 2016-10-18 12:21:00 +01:00
Chris Hill-Scott
4ddc99781f Make revoked message in API keys table lighter 
It’s secondary information so works better in the secondary text colour.
 2016-10-18 11:57:46 +01:00