Commit Graph

4775 Commits

Author SHA1 Message Date
Pete Herlihy
7b4610e8f0 And so did FCO Consular Services
So 142 and 61 now....
2018-01-24 13:57:23 +00:00
Pete Herlihy
36b9c3b967 Cafcass got in before we merged :)
60 orgs now and 141 services.
2018-01-24 13:57:22 +00:00
Pete Herlihy
8cc25e8cd7 135-140 ande 58-59
* ESFA IDAMS – Department for Education
* SRFT Care Call – Salford Royal NHS Foundation Trust
* Data Statistics – Ministry of Housing, Communities & Local Government
* Home Office Atlas – Home Office
* Bracknell Forest Council - Waste & Recycling – Bracknell Forest Council
2018-01-24 13:57:22 +00:00
Chris Hill-Scott
4391dff43b Content style fixes on request to go live page
It’s ‘per month’ – ‘a month’ is a colloquialism.

Large numbers should be chunked using commas; ‘20,000’ already is, this commit makes ‘1000’ consistent.
2018-01-24 13:24:03 +00:00
Pete Herlihy
58059ba507 Merge branch 'master' into cookie-page-updates 2018-01-24 12:30:02 +00:00
Chris Hill-Scott
86e21f2b4b Remove platform admin letter/international buttons
Users can choose whether to have these features on or off now. And
a platform admin can still use the same controls to switch the features
on or off on behalf of a user. There’s no need for the separate buttons.
2018-01-24 11:49:39 +00:00
Chris Hill-Scott
555392b5da Allows services to choose if they can send letters
Our support ticket analysis shows that the most common action request
after going live is turning on letters.

We just do this for any team that requests it – there’s no gatekeeping.
So we should just allow people to make the change themselves.

This will be a better experience for our users, and less work for us.
The design of the page replicates roughly what we have for international
text messaging.
2018-01-24 11:49:39 +00:00
Chris Hill-Scott
a44aee05cb Update date ranges to GOV.UK style 2018-01-24 11:33:26 +00:00
Pete Herlihy
707ee8e748 Reword the health warning in the roadmap. 2018-01-24 10:57:02 +00:00
Pete Herlihy
30cf635bee [WIP] Updated roadmap 23 Jan 2018 2018-01-24 10:57:01 +00:00
Pete Herlihy
e547732c78 Adding a link to the Notify blog 2018-01-24 10:43:48 +00:00
Chris Hill-Scott
efcc684f9d Add missing full stop 2018-01-24 10:39:31 +00:00
Chris Hill-Scott
eb95bcbdb1 ‘Onto’ not ‘on to’ 2018-01-24 10:38:01 +00:00
Chris Hill-Scott
e48fe539b9 Update cookie information link…
…to a more reputable-looking site.
2018-01-24 10:36:53 +00:00
Chris Hill-Scott
05c93822e0 Add information about pricing to inbound SMS page
One of the things that came out of the support analysis was that people
were asking how much inbound SMS costs. There wasn’t a significant
volume of these requests, but the fix seems low-effort and
non-disruptive enough that we should do it.

Content by Thom.
2018-01-22 14:05:45 +00:00
Chris Hill-Scott
fb28e6867c Merge branch 'master' into master 2018-01-19 12:18:17 +00:00
Leo Hemsted
e6400c43c4 Merge branch 'master' into bank-hols 2018-01-18 15:47:21 +00:00
Chris Hill-Scott
375e15511c Make page title match <h1>
This is what we do as convention, unless there’s a good reason not to, and is better than ’Email verification’.
2018-01-18 14:30:18 +00:00
Chris Hill-Scott
92674641ac Tell people they can close tab once email auth’d
We’ve seen people come back to this page once signed in and be confused what it’s for and how they get back to Notify.

The best way to avoid confusion is (we think) getting people to close this tab.
2018-01-18 14:30:17 +00:00
chrisw
e6690c8a78 Updated email preview to mimic sent emails 2018-01-17 16:54:35 +00:00
chrisw
e52921bc00 add view link in message log for letter notifications 2018-01-17 15:39:39 +00:00
Alexey Bezhan
a23efc9a93 Replace Deskpro ad-hoc requests with a client from utils
Moves the duplicated calls to Deskpro to notification_utils and
rewrites feedback and service go-live requests to use the shared
client.
2018-01-17 14:31:27 +00:00
Rebecca Law
86d1df2a31 Gunicorn will timeout a process after 30 seconds.
The marshmallow schema takes too long, we need to fix the performance of that first.
2018-01-17 12:47:15 +00:00
Rebecca Law
9cf392ed7f Merge branch 'master' into enable-download-link 2018-01-17 11:08:39 +00:00
Leo Hemsted
2edb1eb704 remove free sms fragment limit from go live flow 2018-01-16 17:40:31 +00:00
Pete Herlihy
1629ca4f67 131-135 and 55-58
* Department of Agriculture, Environment and Rural Affairs – DAERA Assisted Digital
* The National Archives – The National Archives
* Falkirk Council – My Falkirk 
* Ministry of Housing, Communities & Local Government – MHCLG
2018-01-16 13:02:14 +00:00
Leo Hemsted
f297beb9bc add 2018 and 2019 bank holidays
also refactor to use iso timestamps
2018-01-16 12:46:46 +00:00
Chris Hill-Scott
3b564b4f29 Add option for one off in request to go live
When we first made this form you couldn’t send one off messages with
Notify. It’s interesting to us because it might help identity teams who
would benefit from email auth, or other features that we build in the
future for caseworkers.
2018-01-16 11:41:47 +00:00
Chris Hill-Scott
48106f22a3 Include organisation type in request to go live
This is so we can catch organisations that are going live with the wrong
free text message allowance.
2018-01-16 11:41:47 +00:00
Chris Hill-Scott
e573f492db Check for unknown permissions
This guards against anyone mispelling or using the wrong words for a
permission, which could introduce unexpected or hard to catch errors.
2018-01-16 11:24:37 +00:00
Chris Hill-Scott
f2418c171c Move roles to models file
Any time we can keep code out of the view files is good. This user stuff
seems like a sensible place to put it, since we’re going to use it
there.
2018-01-16 11:23:48 +00:00
Chris Hill-Scott
d9a63c07a9 Refactor user permissions to use args, not list
This makes the interface a bit cleaner and less verbose.
2018-01-16 11:22:57 +00:00
Chris Hill-Scott
784f577c4d Improve redraw performance
It’s noticeable when clicking from row to row in the spreadsheet that
the page jumps around a fair bit on load because there are a couple of
Javascript-powered components.

This commit makes sure:
- the radio select component doesn’t change height when rendering for
  the first time
- the scrollable table doesn’t show parts of the table that should be
  hidden by overflow for a fraction of second before all the JS has
  run
- the right-hand shadow on horizontally scrollable tables doesn’t fade
  in on initial page load but shows at 100% opacity immediately
2018-01-15 14:45:38 +00:00
Chris Hill-Scott
072f8e0f87 Make row in URL match displayed row
Spreadsheets start at row 1 (the header row), and the values don’t start
until row 2. The row numbers in our URLs start at 0, which is a concept
that only makes sense to programmers.

It’s more predictable and consistent to make the number in the URL match
the row number displayed on the page when previewing the spreadsheet.
2018-01-15 14:45:38 +00:00
Chris Hill-Scott
b95a7403b4 Make clickable area of link bigger
Fitt’s law[1] states that bigger click areas are quicker and easier for
people to click. Therefore we should make click areas as big as
possible, without being ambiguous about what the outcome of clicking
will be or increasing the potential for accidental clicks.

The click areas of the row numbers in the table were very small – this
commits makes them as big as the containing table cells.

Uses this technique to achieve the bigger click areas without disrupting
the layout:
http://authenticff.com/journal/css-pro-tip-expanding-clickable-area

1. https://en.wikipedia.org/wiki/Fitts%27s_law
2018-01-15 14:45:37 +00:00
Chris Hill-Scott
ba0a010d64 Link each row in the spreadsheet
We’ve heard from some users, especially those sending letters, that
they’d like to check that a spreadsheet they’ve uploaded has populated
the template correctly.

My reckon is that seeing just one row of the spreadsheet populate the
template isn’t enough to give people confidence that everything’s
working properly.

This commit adds links to all but the currently-previewed row. Clicking
that link will populate the preview with values from that row. These
pages already exist; they were created in this PR:
https://github.com/alphagov/notifications-admin/pull/1696
2018-01-15 14:45:37 +00:00
Chris Hill-Scott
b5c114b66e Remove error handling code when no errors
`ok.html` is only used if the file has no errors. Therefore there will
never been any need to highlight which rows in the file have errors.
2018-01-15 14:45:36 +00:00
Chris Hill-Scott
c68b10590d Merge branch 'master' into styleguide-l 2018-01-15 14:12:07 +00:00
Chris Hill-Scott
36f68b960a Update this file to match the other one 2018-01-15 14:11:57 +00:00
Chris Hill-Scott
27a83f6c97 Treat ‘service manual’ as a proper noun
ie capitalise it to match https://www.gov.uk/service-manual
2018-01-15 14:11:17 +00:00
Chris Hill-Scott
1260dee094 fix typo 2018-01-15 14:10:03 +00:00
Rebecca Law
8a026dfdeb The downloading of the CSV is working for as many as 190, 000 notifications.
This PR re-enables the download link and filters the notifications by templates type.
2018-01-15 12:29:03 +00:00
Chris Hill-Scott
67b54d850f Add link back to API integration from callbacks
Matches what we do on the API keys and whitelist pages.
2018-01-15 10:10:12 +00:00
Chris Hill-Scott
b3673a94a2 Link to callbacks from inbound page
If you’ve got an inbound number and are using the API you’ll probably
be interested in this new feature we’ve got. And if you do know about
it, you might not be able to find it because we’ve moved it.
2018-01-15 10:10:11 +00:00
Katie Smith
7386d5ec1c Fix 500 error from notifications/letter.json page
The letters notification page makes ajax calls to update the status - these
were failing because it's making a POST request without a CSRF token.
(The email and SMS notification pages contain a search form that includes
the hidden CSRF input, so this was only occurring with the letters
page.)

This commit adds a hidden form for the letters page which just contains
the CSRF token.
2018-01-15 09:21:12 +00:00
Chris Hill-Scott
ebd5721d42 Correct description of how service name appears
This has changed since we made prefixing text messages its own setting.
2018-01-12 16:55:54 +00:00
Rebecca Law
135b0ad131 Revert download link.
There is some inconsistencies about how it is working, that needs to be solved.
2018-01-12 16:15:53 +00:00
Rebecca Law
59ac514655 Fix bug. 2018-01-12 14:03:31 +00:00
Rebecca Law
08e5f68461 A little refactoring 2018-01-12 12:06:07 +00:00
Pete Herlihy
c616f180c7 Updated go-live page links to email and text message guidance
Now mirrors the terms of use.
2018-01-11 15:51:11 +00:00