Commit Graph

2897 Commits

Author SHA1 Message Date
Chris Hill-Scott
1ae068d96e Merge pull request #1540 from alphagov/reply-inbound
Let users reply to an inbound message with an existing template
2017-10-18 12:33:42 +01:00
Chris Hill-Scott
ad8a35b045 Merge pull request #1545 from alphagov/digit-spacing
Add some letter spacing to textboxes that accept digits
2017-10-17 17:07:05 +01:00
Chris Hill-Scott
a7a19fdf5b Merge pull request #1544 from alphagov/remove-html-validation
Remove HTML5 validation
2017-10-17 17:06:52 +01:00
Chris Hill-Scott
6baa9fe327 Merge pull request #1542 from alphagov/track-all-form-errors
Track form validation errors in Google analytics
2017-10-17 17:06:44 +01:00
Chris Waszczuk
1493e8bd41 Merge pull request #1543 from gov-cjwaszczuk/master
Allow one-off email sending to select the reply-to address
2017-10-17 11:30:29 +01:00
chrisw
e149d0eb91 Allow one-off email sending to select the reply-to address 2017-10-17 11:15:26 +01:00
Pete Herlihy
2c53a1e2fe 88-89 and 40-41 2017-10-17 10:21:26 +01:00
Chris Hill-Scott
7fc2a5b134 Remove HTML5 validation
This commit:
- uses WTForms email fields wherever we collect email addresses
- makes sure we don’t let the default HTML5 form validation get trigged
  (using `novalidate`[1])

We don’t want to use the default validation because:
- it looks out of place
- it’s not well supported by assistive technology

1. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/form#attr-novalidate
2017-10-16 17:17:54 +01:00
Chris Hill-Scott
57069e427d Add some letter spacing to two factor textbox
Entering, or reading back sequences of digits is easier when they’re a
bit more spaced out.

This is because we read words as shapes, but read numbers
digit-by-digit.

So this commit adjusts the tracking of the type to put a bit more space
in for textboxes that are going to accept digits.
2017-10-16 17:12:16 +01:00
Chris Hill-Scott
d5edb8dbfb Track form validation errors in Google analytics
We started tracking upload errors in eb264f34b7

This has been useful.

This commit adds tracking of other form validation errors, so we can
pick up if there’s a form field that’s causing people particular
trouble.

Also had to rewrite a very old test to look for page content in a
smarter way.
2017-10-16 15:26:21 +01:00
Chris Hill-Scott
d3ddb7cf0d Merge pull request #1541 from alphagov/wider-notify
Open Notify to the wider public sector
2017-10-16 14:39:33 +01:00
Chris Hill-Scott
54c320e0fa Open Notify to the wider public sector
Notify is now available, as a pilot, to local government and the NHS. So
telling people that it’s only for government departments and agencies is
- wrong
- might stop them from signing up

The word ‘organisation’ matches what’s used on the list of services, and
on the hint text on the email field on the sign up page.
2017-10-16 11:53:28 +01:00
Chris Hill-Scott
f01df65751 Rename count from ‘departments’ to ’organisations’
They’re not all departments.

Could also say ‘departments and agencies’ as per the Performance Platform page. Which is more accurate?
2017-10-16 11:14:43 +01:00
Chris Hill-Scott
34371d030c Link to conversation from notification page
If you’re using inbound SMS then I reckon it’s useful to be able to
naviagate from one message to the context in which that message sits
(ie the conversation).

This commit adds that link.

This is maybe a stopgap until we do something more like chat, where you
can reply on the same screen where you see the conversation, but maybe
it turns out we don’t want to do that – lets see how this works.
2017-10-16 10:38:09 +01:00
Chris Hill-Scott
05513c6fa7 Refactor to reuse search box HTML 2017-10-16 09:34:40 +01:00
Chris Hill-Scott
91cdc9ffcb Auto populate the phone number when replying
Currently the only way of ‘replying’ to an inbound message is by
copy/pasting the phone number from the inbound page into the send one
off page. Rather than making people copy/paste, this commit puts the
phone number in the session, if the user is going through the new reply
flow.
2017-10-16 09:34:19 +01:00
Chris Hill-Scott
88f169d970 Add a page to pick a template to reply with
If your service is receiving inbound messages, you might want to reply
to them. Without an API integration, the only way to do this is by doing
the send one off flow. But currently there is no direct link from the
page which shows the inbound messages.

So this commit:
- adds a link to a new page…
- …which shows the available (ie only text message) templates with which
  you can reply
2017-10-16 09:33:59 +01:00
chrisw
a94415632d Add multiple letter contact blocks for services from Admin app 2017-10-12 09:47:58 +01:00
Pete Herlihy
bf4bf3282d Adding Civil Service Local News to make it 87 2017-10-10 15:35:56 +01:00
Pete Herlihy
541f32e466 84-86 and 39 to 40 orgs...
HMCTS SENDIST (?) - and RPA
2017-10-09 10:50:47 +01:00
Chris Hill-Scott
c62ee26b15 Merge pull request #1530 from alphagov/security-features
Adding security features to the features page
2017-10-05 15:19:04 +01:00
Chris Hill-Scott
6ee62fa9be Merge pull request #1531 from alphagov/october-roadmap
Updated roadmap for October 2017 onwards
2017-10-05 15:11:30 +01:00
Pete Herlihy
e8a2fbaea4 Added link to the info risk management page 2017-10-05 15:11:16 +01:00
Pete Herlihy
ac79ee9891 Adding security features to the features page 2017-10-05 15:11:15 +01:00
Chris Hill-Scott
5a15871b88 Dashes not underscores 2017-10-05 15:00:18 +01:00
Pete Herlihy
c50989c706 Tidied up for code style 2017-10-05 14:58:25 +01:00
Pete Herlihy
d418075dab Added page with the information risk management approach 2017-10-05 14:39:57 +01:00
Pete Herlihy
18bacab039 Added route to information_risk_management page 2017-10-05 14:24:12 +01:00
Pete Herlihy
a3f3689c31 Updated roadmap for October 2017 onwards 2017-10-05 13:58:05 +01:00
Chris Hill-Scott
61ce4c5a02 Merge pull request #1525 from alphagov/only-mandate-mandatory-columns
Only mandate mandatory address columns
2017-10-04 10:14:39 +01:00
Chris Hill-Scott
775fa1ac2d Merge pull request #1524 from alphagov/key-types-and-letters
Add note about relationship between team API key and letters
2017-10-04 10:14:32 +01:00
Chris Hill-Scott
76bee708af Merge pull request #1523 from alphagov/79-84
79 - 84
2017-10-03 14:13:52 +01:00
Chris Hill-Scott
95f6257852 Merge pull request #1512 from alphagov/email-reply-tweaks
Tweak email reply to pages, add IDs
2017-10-03 14:12:56 +01:00
Chris Hill-Scott
4154dbba1f Only mandate mandatory address columns
If you miss ‘postcode’ from your file then you get told that you need
‘address_line_1’, ‘address_line_2’, ‘address_line_3’, etc.

This is incorrect – the only required address columns are lines 1 and 2,
plus the postcode. So this commit corrects the error message to be
factually accurate.

We had a user report this to Fajer as a bug.
2017-10-03 14:08:25 +01:00
Chris Hill-Scott
d7fc7b082f Make trial mode message less verbose
Frontloads the ‘not’ part of the message, and makes it shorter, so
it’s more likely to be read and understood. Also makes it fit better
with the new ‘Can’t be used to send letters’ message.
2017-10-03 13:32:10 +01:00
Chris Hill-Scott
9c25b2d2da Add note about letters
When trying to send letters using the API, the ‘team and whitelist’ key
is confusing. We don’t have addresses for your team members, nor is
there a whitelist for letter addresses. The actual behaviour is that
you’ll get an error if you try to use this key to send letters.

So, for services who have letters available, we should add a hint
telling users that team and whitelist is probably not the key they’re
looking for.
2017-10-03 13:29:12 +01:00
Pete Herlihy
cdacdc388a 79 - 84
Pembrokeshire County Council
G Cloud Team
Government Whips' Office
DCLG Housing and Planning Data Collection Team
Returner team - Government Equalities Office
2017-10-03 13:04:17 +01:00
Chris Waszczuk
c2a50a7c37 Merge pull request #1520 from gov-cjwaszczuk/master
Added letters info to service / admin dashboard & activity page
2017-10-03 10:40:59 +01:00
chrisw
43395bc9d9 Added letters info to service / admin dashboard & activity page 2017-10-03 10:28:34 +01:00
venusbb
33a2909a76 reverse code not seperating trial_mode_services 2017-10-02 14:26:08 +01:00
Chris Hill-Scott
7b12b7e03d Merge pull request #1513 from alphagov/add-letters-to-go-live
Add letters to the request to go live page
2017-10-02 10:53:08 +01:00
Leo Hemsted
cf3f4d5cee Merge pull request #1516 from alphagov/empty-inbound-sms
make sure inbound sms page doesn't break if you receive a blank inbou…
2017-09-29 13:51:30 +01:00
Leo Hemsted
bb44479b3e disable statsd when testing
or it won't run if you're offline
2017-09-29 10:16:20 +01:00
Leo Hemsted
57b4971ac1 update conftest and tests to contain accurate test data
specifically, we identify inbound vs outbound by presence of
"notify_number", so ensure that test content actually contains that
field
2017-09-29 10:15:17 +01:00
Pete Herlihy
74992da1c8 Adding acas.org.uk to whitelist 2017-09-29 09:24:07 +01:00
Chris Hill-Scott
26d1bda43c Update email-message.scss
Got my first and last mixed up…
2017-09-28 16:15:48 +01:00
Chris Hill-Scott
84a225ffdb Merge pull request #1517 from alphagov/right-padding-email-message
Fix overridden padding on email subject
2017-09-28 16:03:55 +01:00
Leo Hemsted
b1e809e82a make sure inbound sms page doesn't break if you receive a blank inbound message 2017-09-28 15:37:18 +01:00
Chris Hill-Scott
c35088796a Hide ID when only one reply to address is shown
Most user will only have one reply to address. Which means they should
never have to worry about IDs. And if you only have one then you never
need its ID, because the last remaining address will always be the
default.

So IDs should only be shown when a service has created more than one
reply to address.

This required a bit of visual tweaking of the _user list_ pattern,
because its spacing wasn’t defined in a way that worked when only the
name of the thing, and not its details were shown on the page.
2017-09-28 11:35:52 +01:00
Imdad Ahad
a273cfe951 Merge pull request #1511 from alphagov/imdad-katie-feat-make-add-letter-contact-validation
Make the letter contact block (service settings form) compulsory
2017-09-28 11:23:56 +01:00