darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-24 09:58:43 -04:00
Code Issues Packages Projects Releases Wiki Activity
14,648 Commits 60 Branches 61 Tags
004343a2c51d8a4faae366753115cba767678712
Commit Graph

14648 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris Hill-Scott
39236cd9bb Merge pull request #2012 from alphagov/innovateukgovuk 
Add Innovate UK to list of domains
 2018-04-05 16:42:16 +01:00
Chris Hill-Scott
2eebb654c6 Add Innovate UK to list of domains 
They are a non-crown body, they haven’t signed the agreement yet.
 2018-04-05 16:35:01 +01:00
Chris Hill-Scott
fccd4367e4 Even out spacing on templates page 
…when search box is present
 2018-04-05 14:55:02 +01:00
chrisw
78d16709d6 reading messages for inbox from new most_recent endpoint 
avoids us having to work out and display most recent messages
only on the front-end - it's now all done in api
 2018-04-05 13:54:37 +01:00
Chris Hill-Scott
61b4f9a13c Merge pull request #2009 from alphagov/template-id-back-in-session 
Make send test letter preview use template ID
 2018-04-05 09:51:43 +01:00
Chris Hill-Scott
0b905249a7 Make send test letter preview use template ID 
The check page expects template ID to be passed through in the URL not
the session now. The send test letter page wasn’t changed.

This commit changes it, and adds a test to make sure this path is
covered.
 2018-04-04 17:10:22 +01:00
chrisw
1d32c766e8 remove X messages from Y users msg 2018-04-04 15:43:07 +01:00
chrisw
f5c467e4ff add pagination to inbox page 2018-04-04 15:41:17 +01:00
Chris Hill-Scott
bf58a4347b Merge pull request #2008 from alphagov/template-id-back-in-session 
Put template_id back in the session
 2018-04-04 15:36:30 +01:00
Chris Hill-Scott
b2722a0cd7 Put template_id back in the session 
The start job endpoint needs the template ID in order to make the API
call.

It doesn’t make sense to add it to the start job URL, because users
could potentially start a job with the wrong template by hacking the URL
(which would blow up at some point, if the template didn’t match the
columns in the file).
 2018-04-04 15:28:30 +01:00
Rebecca Law
fc846cf4a2 Merge pull request #2001 from alphagov/store-less-in-session 
Stop storing `template_id` and `original_file_name` in session
 2018-04-04 14:42:38 +01:00
Rebecca Law
c4fde48c53 Merge pull request #2005 from alphagov/3-years 
Limit number of navigable financial years to 3
 2018-04-04 14:42:19 +01:00
Chris Waszczuk
b1196373c8 Merge pull request #2007 from alphagov/revert-1985-add-pagination-to-inbox-page 
Revert "add pagination to inbox page"
 2018-04-04 14:30:23 +01:00
Chris Waszczuk
6153389e01 Revert "add pagination to inbox page" 2018-04-04 14:18:03 +01:00
Chris Waszczuk
628d8ac5a8 Merge pull request #1985 from alphagov/add-pagination-to-inbox-page 
add pagination to inbox page
 2018-04-04 13:15:29 +01:00
Chris Waszczuk
59c83cd78e Merge pull request #2004 from alphagov/session-size-stuff 
remove any old file upload data on sign in
 2018-04-04 13:15:02 +01:00
Chris Hill-Scott
ba9935c49e Remove ‘check’ page’s reliance on session 
A of this commit’s parent we are storing `template_id` and
`original_file_name` in the URL. Getting them from the URL is better,
so the check page no longer needs to look for them in the session. This
commit removes the code that looks for these values in the session.
 2018-04-04 11:37:43 +01:00
Chris Hill-Scott
3dab34cd38 Store template ID and original file name in URL 
At the moment you can’t press refresh on the check page if there’s
errors. This is because the session gets cleared when there’s errors.
This is a bad user experience.

The data that this page is relying on (from the session) is:
- template ID
- original file name

Neither of these things need to be in the session because:
- they are not secret
- the user can modify them already (by choosing a different template or
  renaming their file locally)

So this commit additionally stores them in the URL.
 2018-04-04 11:30:27 +01:00
Chris Hill-Scott
2e795be2a7 Merge pull request #2006 from alphagov/sfc 
Remove learning and skills council from domains
 2018-04-04 09:56:49 +01:00
Chris Hill-Scott
25ce8f3c4a Remove learning and skills council from domains 
Because:
- they’re not a council
- they don’t exist any more (part of SFA, which has become ESFA)
 2018-04-04 09:50:17 +01:00
Chris Hill-Scott
d75f89daf5 Limit number of navigable financial years to 3 
Because more than 3 looks ugly.
 2018-04-03 18:13:38 +01:00
Leo Hemsted
0dabd4ffc0 remove any old file upload data on sign in 
if a user signs in again, clear their file upload data from any
aborted journeys from before, so that their cookies don't fill up

also add some temporary logging when the session starts getting full.
 2018-04-03 14:58:50 +01:00
Chris Hill-Scott
146bb3284e Merge pull request #2003 from alphagov/bump-utils-askterisks 
Bump utils to 25.2.3
 2018-04-03 13:07:49 +01:00
chrisw
50661faac0 add pagination to inbox page 2018-04-03 12:12:30 +01:00
Chris Hill-Scott
53556ee56b Bump utils to 25.2.3 2018-04-03 12:08:59 +01:00
Chris Hill-Scott
8fb909101b Reword the download agreement page 2018-04-03 10:58:48 +01:00
Rebecca Law
98a40ac55b Merge pull request #2000 from alphagov/reduce-ajax-request-per-second 
Reduce ajax call interval
 2018-03-29 15:49:36 +01:00
Rebecca Law
0d23c87599 In an attempts to reduce the traffice this pull request changes the interval the ajax calls to 5 seconds from 2 seconds for the dashboad page. 2018-03-29 15:42:19 +01:00
Chris Hill-Scott
56db33a2c5 Merge pull request #1999 from alphagov/no-click-shim 
Stop shims from blocking clicks on lower elements
 2018-03-29 14:23:16 +01:00
Chris Hill-Scott
51d3277fde Stop shims from blocking clicks on lower elements 
https://developer.mozilla.org/en-US/docs/Web/CSS/pointer-events
 2018-03-29 14:19:33 +01:00
Chris Hill-Scott
2ca4aaa83e Merge pull request #1998 from alphagov/expanding-session 
Don’t store info about bad uploads in session
 2018-03-29 14:03:46 +01:00
Chris Hill-Scott
890deec3ae Merge pull request #1997 from alphagov/dft.gov.uk 
Record MoU signed by Department for Transport
 2018-03-29 12:13:52 +01:00
Chris Hill-Scott
becee15e1e Add logging for session not being set bug 
This is so we can be alerted to it before our users alert us to it.
 2018-03-29 12:07:37 +01:00
Chris Hill-Scott
e74d261ec3 Don’t store info about bad uploads in session 
Because we now[1] store info about each file upload separately in the
session the session isn’t overridden every time you upload a file. This
is good because you can do multiple file uploads idempotently.

Generally we are cleaning up after ourselves because we pop anything to
do with that upload from the session. However there is an edge case: if
you never send the file then the info about the file stays in the
session in perpetuity[2]. This is generally happening when people are
uploading files that are impossible to send, ie ones that have errors.

So this commit makes two changes:

1. remove info about a file upload from the session as soon as we know
   that it contains errors
2. `POST` reuploads to the same endpoint as initial uploads because
   otherwise we need to keep info about bad uploads in the session,
   which would prevent us from doing 1.

1. https://github.com/alphagov/notifications-admin/pull/1968
2. or at least until the session is cleared by the user logging out
 2018-03-29 11:56:53 +01:00
Chris Hill-Scott
dd20388c5a Record MoU signed by Department for Transport 2018-03-29 10:01:41 +01:00
snyk-bot
34bd1883c3 fix: package.json to reduce vulnerabilities 
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/npm:minimatch:20160620

Latest report for alphagov/notifications-admin:
https://snyk.io/test/github/alphagov/notifications-admin
 2018-03-29 02:10:58 +00:00
Chris Hill-Scott
a3374f32d8 Merge pull request #1994 from alphagov/ips.gov.uk 
Add IPS to list of domains
 2018-03-28 15:53:37 +01:00
Chris Hill-Scott
69c1753b1f Add IPS to list of domains 
Identity and Passport Service is the old name for HM Passport Office, but they still use the domain for their emails.

> Identity and Passport Service became Her Majesty's Passport Office in May 2013.

– https://www.gov.uk/government/organisations/identity-and-passport-service/about
 2018-03-28 15:38:56 +01:00
Chris Hill-Scott
33b7247e5d Merge pull request #1993 from alphagov/luton.gov.uk 
Record agreement signed by Luton Borough Council
 2018-03-28 15:08:26 +01:00
Chris Hill-Scott
22d88147dc Record agreement signed by Luton Borough Council 2018-03-28 14:53:25 +01:00
Chris Hill-Scott
b4bc53955f Merge pull request #1964 from alphagov/serve-mou 
Let users download the data sharing and financial agreement
 2018-03-28 13:52:11 +01:00
Chris Hill-Scott
1f94574076 Merge pull request #1991 from alphagov/twfire.gov.uk 
Record Tyne and Wear Fire and Rescue Authority
 2018-03-28 13:43:17 +01:00
Chris Hill-Scott
c2abae91ab Record Tyne and Wear Fire and Rescue Authority 
They have now signed the non-crown agreement.
 2018-03-28 13:39:11 +01:00
Chris Hill-Scott
2d83235f65 Merge pull request #1990 from alphagov/ccs 
Mark CCS as part of Cabinet Office
 2018-03-28 13:30:57 +01:00
Chris Hill-Scott
9354da5c60 Mark CCS as part of Cabinet Office 
As such they don’t need to sign an agreement.
 2018-03-28 12:54:02 +01:00
Chris Hill-Scott
dca5546cbd Only offer agreement download to non-crown for now 
We don’t have the crown agreement in a nice downloadable format at the
moment.
 2018-03-28 12:43:03 +01:00
Chris Hill-Scott
0c87dca0a6 Merge pull request #1989 from alphagov/rtgl-using-notify 
Add link to request to go live from ‘Using Notify’
 2018-03-28 10:25:38 +01:00
Chris Hill-Scott
2ec62e8b3d Merge pull request #1983 from alphagov/scottish-crown 
Record Scottish Government as a crown body
 2018-03-28 10:24:10 +01:00
Chris Hill-Scott
f1d609f2ab Merge pull request #1988 from alphagov/pyup-update-pyexcel-xlsx-0.5.5-to-0.5.6 
Update pyexcel-xlsx to 0.5.6
 2018-03-28 09:55:08 +01:00
Chris Hill-Scott
ed3004821c Merge pull request #1987 from alphagov/pyup-update-pyexcel-0.5.7-to-0.5.8 
Update pyexcel to 0.5.8
 2018-03-28 09:54:59 +01:00