Remove basic view setting and preview

tests/app/main/views/test_activity.py

@@ -211,7 +211,7 @@ def test_link_to_download_notifications(
     ) == expected_download_link(service_id=SERVICE_ONE_ID)
 
 
-def test_download_not_available_in_basic_view(
+def test_download_not_available_to_users_without_dashboard(
     client_request,
     active_caseworking_user,
 ):

tests/app/main/views/test_jobs.py

@@ -71,7 +71,7 @@ from tests.conftest import (
     )),
 ])
 @freeze_time("2012-12-12 12:12")
-def test_jobs_page_shows_scheduled_jobs_in_basic_view(
+def test_jobs_page_shows_scheduled_jobs_if_user_doesnt_have_dashboard(
     client_request,
     service_one,
     active_user_with_permissions,

tests/app/main/views/test_service_settings.py

@@ -173,11 +173,10 @@ def test_should_show_overview(
         'Send letters Off Change',
 
     ]),
-    (['letters', 'caseworking'], [
+    (['letters'], [
 
         'Service name service one Change',
         'Sign-in method Text message code Change',
-        'Basic view On Change',
 
         'Label Value Action',
         'Send emails Off Change',
@@ -2440,135 +2439,6 @@ def test_invitation_pages(
     assert normalize_spaces(page.select('main p')[0].text) == expected_p
 
 
-@pytest.mark.parametrize('permissions, expected_selected', [
-    ('caseworking', 'on'),
-    ('', 'off'),
-])
-def test_see_basic_view_page(
-    client_request,
-    service_one,
-    permissions,
-    expected_selected,
-):
-    service_one['permissions'] = permissions
-    page = client_request.get(
-        "main.service_set_basic_view",
-        service_id=SERVICE_ONE_ID
-    )
-    assert page.h1.text.strip() == 'Basic view'
-    assert page.select_one('main a')['href'] == url_for(
-        'main.preview_basic_view',
-        service_id=SERVICE_ONE_ID,
-    )
-    assert page.select_one('input[checked]')['value'] == expected_selected
-
-
-@pytest.mark.parametrize('value, expected_updated_permissions', [
-    ('on', {'email', 'caseworking', 'sms'}),
-    ('off', {'email', 'sms'}),
-])
-def test_update_basic_view(
-    mocker,
-    client_request,
-    service_one,
-    value,
-    expected_updated_permissions,
-):
-    mocked_update = mocker.patch(
-        'app.service_api_client.update_service_with_properties',
-        return_value=service_one,
-    )
-    client_request.post(
-        "main.service_set_basic_view",
-        service_id=SERVICE_ONE_ID,
-        _data={
-            'enabled': value,
-        },
-        _expected_status=302,
-        _expected_redirect=url_for(
-            'main.service_settings',
-            service_id=SERVICE_ONE_ID,
-            _external=True,
-        ),
-    )
-    assert set(
-        mocked_update.call_args[0][1]['permissions']
-    ) == expected_updated_permissions
-
-
-def test_preview_basic_view(
-    client_request,
-    mock_get_service_templates,
-    mock_has_no_jobs,
-):
-    page = client_request.get(
-        "main.preview_basic_view",
-        service_id=SERVICE_ONE_ID,
-        _follow_redirects=True,
-    )
-
-    with client_request.session_transaction() as session:
-        assert session['basic'] is True
-
-    assert page.h1.text.strip() == 'Templates'
-    page.select('.navigation-service-basic-view-preview')
-    assert normalize_spaces(page.select_one('.navigation-service').text) == (
-        'service one '
-        'Preview of basic view '
-        'Back to settings '
-        'Switch service'
-    )
-    page.select_one('a.navigation-service-basic-view-back-link')['href'] == url_for(
-        'main.service_set_basic_view',
-        service_id=SERVICE_ONE_ID,
-    )
-
-    client_request.get(
-        "main.service_set_basic_view",
-        service_id=SERVICE_ONE_ID,
-    )
-
-    with client_request.session_transaction() as session:
-        assert 'basic' not in session
-
-
-def test_cant_preview_basic_view_for_another_service(
-    client_request,
-    mock_get_service_templates,
-    mock_has_no_jobs,
-    fake_uuid,
-):
-    client_request.get(
-        "main.preview_basic_view",
-        service_id=SERVICE_ONE_ID,
-        _follow_redirects=True,
-        _expected_status=200,
-    )
-    client_request.get(
-        "main.preview_basic_view",
-        service_id=fake_uuid,
-        _expected_status=403,
-    )
-
-
-def test_actual_basic_view_cant_escape_basic_view(
-    client_request,
-    active_caseworking_user,
-    mock_get_service_templates,
-):
-    client_request.login(active_caseworking_user)
-    client_request.get(
-        "main.preview_basic_view",
-        service_id=SERVICE_ONE_ID,
-        _expected_status=403,
-    )
-    client_request.get(
-        "main.service_set_basic_view",
-        service_id=SERVICE_ONE_ID,
-        _expected_status=403,
-    )
-
-
 def test_service_settings_when_inbound_number_is_not_set(
     logged_in_client,
     service_one,